Skip to content

Conversation

anbnyc
Copy link
Contributor

@anbnyc anbnyc commented Aug 12, 2025

What does this PR do?

Customer reported their integration dashboard shows data when the widget is closed, but not when it is open. This is because the query does not have a source parameter, and the Graph Editor defaults to source:postgresql when the widget is opened (source1, source2). We can prevent this by explicitly setting the source parameter.

Query works (implicit sqlserver):
image

Query doesn't work (explicit postgresql):
image

Query works again (explicit sqlserver):
image

image

Motivation

Sales prospect noticed broken integration dashboard: https://datadog.zendesk.com/agent/tickets/2210932

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link
Contributor Author

anbnyc commented Aug 12, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

⚠️ Recommendation: Add qa/skip-qa Label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.

@anbnyc
Copy link
Contributor Author

anbnyc commented Aug 12, 2025

/to-staging

@dd-devflow-routing-codex
Copy link

View all feedbacks in Devflow UI.

2025-08-12 14:21:31 UTC ℹ️ Start processing command /to-staging
If you need support, contact us on Slack #devflow!


2025-08-12 14:21:32 UTCDevflow: /to-staging

This command is disabled.
Reason: This repository doesn't have a shared staging branch, you need to use /integrate or /integrate -b <your-branch>

If you need support, contact us on Slack #devflow with those details!

@anbnyc
Copy link
Contributor Author

anbnyc commented Aug 12, 2025

/integrate

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Aug 12, 2025

View all feedbacks in Devflow UI.

2025-08-12 14:21:58 UTC ℹ️ Start processing command /integrate


2025-08-12 14:22:12 UTC ❌ Integrate failure

No services specified for deployment and BIA didn't detect any impacted services

@anbnyc
Copy link
Contributor Author

anbnyc commented Aug 12, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Aug 12, 2025

View all feedbacks in Devflow UI.

2025-08-12 15:35:00 UTC ℹ️ Start processing command /merge


2025-08-12 15:35:12 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-08-12 19:36:06 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@anbnyc
Copy link
Contributor Author

anbnyc commented Aug 13, 2025

working in staging:
image

@anbnyc
Copy link
Contributor Author

anbnyc commented Aug 13, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Aug 13, 2025

View all feedbacks in Devflow UI.

2025-08-13 16:16:04 UTC ℹ️ Start processing command /merge


2025-08-13 16:16:13 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-08-13 20:17:06 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@anbnyc
Copy link
Contributor Author

anbnyc commented Aug 13, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Aug 13, 2025

View all feedbacks in Devflow UI.

2025-08-13 18:37:14 UTC ℹ️ Start processing command /merge


2025-08-13 18:37:19 UTC ❌ MergeQueue

PR already in the queue with status waiting

@sarah-witt sarah-witt added this pull request to the merge queue Aug 13, 2025
Merged via the queue into master with commit c0ea266 Aug 13, 2025
41 of 43 checks passed
@sarah-witt sarah-witt deleted the alec.barrett/sql-server-source branch August 13, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants