-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update README.md #21328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #21328
Conversation
We made two changes to the documentation page: 1 - in the Annotations v1 example, we were not using the container name for check, which is incorrect and it will not work. Replaced the postgresql.check_names for postgres.check_names to match the container name. 2. We added a note to guide customers to match their container name in the integration check_names. We are open to suggestion regarding the added note in the documentation.
|
This PR does not modify any files shipped with the agent. To help streamline the release process, please consider adding the |
|
/merge |
|
View all feedbacks in Devflow UI.
This merge request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
devflow unqueued this merge request: It did not become mergeable within the expected time |
We made two changes to the documentation page:
1 - in the Annotations v1 example, we were not using the container name for check, which is incorrect and it will not work. Replaced the postgresql.check_names for postgres.check_names to match the container name.
2. We added a note to guide customers to match their container name in the integration check_names. We are open to suggestion regarding the added note in the documentation.
What does this PR do?
We made two changes to the documentation page:
1 - in the Annotations v1 example, we were not using the container name for check, which is incorrect and it will not work. Replaced the postgresql.check_names for postgres.check_names to match the container name.
2. We added a note to guide customers to match their container name in the integration check_names. We are open to suggestion regarding the added note in the documentation.
Based on customer confusion in case https://datadog.zendesk.com/agent/tickets/2237581
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged