Fix for Spark driver init readiness pending #22252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
steveny91
reviewed
Jan 2, 2026
steveny91
reviewed
Jan 2, 2026
spark/assets/configuration/spec.yaml
Outdated
Comment on lines
138
to
141
| - name: startup_wait_retries | ||
| description: | | ||
| How many times to retry when Spark returns a startup message instead of JSON. | ||
| Set to -1 to disable, 0 to retry forever, or a positive number to limit retries. |
Contributor
There was a problem hiding this comment.
nit - Can we be a bit more descriptive here? What does retry forever mean? When it retries, does it sit there any block the check execution? What is the behavior when setting it to the different values?
Contributor
|
Please ping me for a review after you address the feedback from @steveny91. Thanks! |
estherk15
added
the
editorial review
Kyle-Neale
force-pushed
the
kyle.neale/fix-spark-readiness-waiting
branch
from
ed1ffdd to
95960be
Compare
steveny91
reviewed
Jan 6, 2026
Co-authored-by: Steven Yuen <[email protected]>
steveny91
previously approved these changes
Jan 6, 2026
temporal-github-worker-1
bot
dismissed
steveny91’s stale review
Review from steveny91 is dismissed. Related teams and files:
- agent-integrations
- spark/datadog_checks/spark/data/conf.yaml.example
steveny91
approved these changes
Jan 7, 2026
datadog-agent-integrations-bot bot
pushed a commit
that referenced
this pull request
Jan 12, 2026
* Fix for Spark driver init readiness pending * Add changelog * Lint * Add config param for retries * Simplify description * Address comments * Update spark/assets/configuration/spec.yaml Co-authored-by: Steven Yuen <[email protected]> * ddev sync models and config --------- Co-authored-by: Steven Yuen <[email protected]> (cherry picked from commit 7477060)
3 tasks
datadog-agent-integrations-bot bot
pushed a commit
that referenced
this pull request
Jan 12, 2026
* Fix for Spark driver init readiness pending * Add changelog * Lint * Add config param for retries * Simplify description * Address comments * Update spark/assets/configuration/spec.yaml Co-authored-by: Steven Yuen <[email protected]> * ddev sync models and config --------- Co-authored-by: Steven Yuen <[email protected]> (cherry picked from commit 7477060)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prevents JSON decode errors when the Spark driver is starting but not quite ready.
Motivation
Customer inquiry via support ticket.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged