-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Assets for DataDog/jmeter-datadog-backend-listener/pull/58 #22300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
d9bb7e3 to
52b7bc8
Compare
52b7bc8 to
219b9be
Compare
219b9be to
cdadb39
Compare
cdadb39 to
43ab1b5
Compare
43ab1b5 to
93b447a
Compare
Removed unnecessary screenshot and adjusted header formatting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cec87bde90
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Thanks for the PR, I've created DOCS-13218 for documentation team review |
rtrieu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor suggestion to add anchor link
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Review from rtrieu is dismissed. Related teams and files:
- documentation
- jmeter/README.md
rtrieu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left mostly suggestions to simplify descriptions to be more concise, but feel free to ignore.
| Datadog Backend Listener for Apache JMeter is an open source JMeter plugin used to send test results to the Datadog platform. It provides real-time reporting of test metrics like latency, the number of bytes sent and received, and more. You can also send to Datadog complete test results as log entries. | ||
| Datadog Backend Listener for Apache JMeter is a JMeter plugin used to send test results to the Datadog platform. It includes the following features: | ||
|
|
||
| - Real time reporting of test metrics (latency, bytes sent and more). See the [Metrics](#metrics) section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Real time reporting of test metrics (latency, bytes sent and more). See the [Metrics](#metrics) section. | |
| - Real-time reporting of test metrics (latency, bytes sent and more). See the [Metrics](#metrics) section. |
| Datadog Backend Listener for Apache JMeter is a JMeter plugin used to send test results to the Datadog platform. It includes the following features: | ||
|
|
||
| - Real time reporting of test metrics (latency, bytes sent and more). See the [Metrics](#metrics) section. | ||
| - Real time reporting of test results as Datadog log events. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Real time reporting of test results as Datadog log events. | |
| - Real-time reporting of test results as Datadog log events. |
| 3. Launch JMeter (or quit and re-open the application). | ||
| 4. Go to `Options > Plugins Manager > Available Plugins`. | ||
| 5. Search for "Datadog Backend Listener". | ||
| 6. Click the checbox next to the Datadog Backend Listener plugin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 6. Click the checbox next to the Datadog Backend Listener plugin. | |
| 6. Click the checkbox next to the Datadog Backend Listener plugin. |
| To start reporting metrics to Datadog: | ||
|
|
||
| 1. Right click on the thread group or the test plan for which you want to send metrics to Datadog. | ||
| 1. Right click on the thread group or the test plan for which you want to send metrics to Datadog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 1. Right click on the thread group or the test plan for which you want to send metrics to Datadog. | |
| 1. Right-click on the thread group or the test plan for which you want to send metrics to Datadog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On line 49, "description" in the table header should be capitalized to "Description" for consistency.
| jmeter.bytes_sent.min,gauge,10,byte,,Minimum value of the number of bytes sent.,0,jmeter,jmeter, | ||
| jmeter.bytes_sent.p90,gauge,10,byte,,P90 value of the number of bytes sent.,0,jmeter,jmeter, | ||
| jmeter.bytes_sent.p95,gauge,10,byte,,P95 value of the number of bytes sent.,0,jmeter,jmeter, | ||
| jmeter.bytes_sent.p99,gauge,10,byte,,P99 value of the number of bytes sent.,0,jmeter,jmeter, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| jmeter.bytes_sent.p99,gauge,10,byte,,P99 value of the number of bytes sent.,0,jmeter,jmeter, | |
| jmeter.bytes_sent.p99,gauge,10,byte,,99th percentile of bytes sent.,0,jmeter,jmeter, |
| jmeter.final_result.responses.error_percent,gauge,,percent,,Percentage of failed samples for a label (final test result only).,0,jmeter,jmeter, | ||
| jmeter.final_result.responses_count,gauge,,response,,Total number of samples collected for a label (final test result only).,0,jmeter,jmeter, | ||
| jmeter.final_result.throughput.rps,gauge,,request,second,Requests per second for a label (final test result only).,0,jmeter,jmeter, | ||
| jmeter.latency.avg,gauge,10,second,,Average value of the latency.,0,jmeter,jmeter, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| jmeter.latency.avg,gauge,10,second,,Average value of the latency.,0,jmeter,jmeter, | |
| jmeter.latency.avg,gauge,10,second,,Average latency.,0,jmeter,jmeter, |
| jmeter.latency.avg,gauge,10,second,,Average value of the latency.,0,jmeter,jmeter, | ||
| jmeter.latency.count,gauge,10,request,,Number of samples used to compute the latency distribution.,0,jmeter,jmeter, | ||
| jmeter.latency.count,count,10,request,,Number of samples used to compute the latency distribution.,0,jmeter,jmeter, | ||
| jmeter.latency.max,gauge,10,second,,Maximum value of the latency.,0,jmeter,jmeter, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| jmeter.latency.max,gauge,10,second,,Maximum value of the latency.,0,jmeter,jmeter, | |
| jmeter.latency.max,gauge,10,second,,Maximum latency.,0,jmeter,jmeter, |
| jmeter.latency.count,count,10,request,,Number of samples used to compute the latency distribution.,0,jmeter,jmeter, | ||
| jmeter.latency.max,gauge,10,second,,Maximum value of the latency.,0,jmeter,jmeter, | ||
| jmeter.latency.min,gauge,10,second,,Mininimum value of the latency.,0,jmeter,jmeter, | ||
| jmeter.latency.median,gauge,10,second,,Median value of the latency.,0,jmeter,jmeter, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| jmeter.latency.median,gauge,10,second,,Median value of the latency.,0,jmeter,jmeter, | |
| jmeter.latency.median,gauge,10,second,,Median latency.,0,jmeter,jmeter, |
| jmeter.latency.max,gauge,10,second,,Maximum value of the latency.,0,jmeter,jmeter, | ||
| jmeter.latency.min,gauge,10,second,,Mininimum value of the latency.,0,jmeter,jmeter, | ||
| jmeter.latency.median,gauge,10,second,,Median value of the latency.,0,jmeter,jmeter, | ||
| jmeter.latency.min,gauge,10,second,,Minimum value of the latency.,0,jmeter,jmeter, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| jmeter.latency.min,gauge,10,second,,Minimum value of the latency.,0,jmeter,jmeter, | |
| jmeter.latency.min,gauge,10,second,,Minimum latency.,0,jmeter,jmeter, |
What does this PR do?
Adds assets for DataDog/jmeter-datadog-backend-listener#58 - see that PR for more information.
The JMeter integration code is in the jmeter-datadog-backend-listener repo, but the assets are in integrations-core, hence the two-part PR.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged