Skip to content

Conversation

@steveny91
Copy link
Contributor

@steveny91 steveny91 commented Jan 26, 2026

What does this PR do?

Fixes the build command to remove deprecation notice. Updates the rust toolchain to make it compatible.

error: rustc 1.86.0 is not supported by the following packages:
  time@0.3.46 requires rustc 1.88.0
  time@0.3.46 requires rustc 1.88.0
  time-core@0.1.8 requires rustc 1.88.0
  time-core@0.1.8 requires rustc 1.88.0
Either upgrade rustc or select compatible dependency versions with
`cargo update <name>@<current-ver> --precise <compatible-ver>`
where `<compatible-ver>` is the latest version supporting rustc 1.86.0

and

The `app` build target is deprecated and will be removed in a future release. Use the `binary` build target instead.
info: syncing channel updates for '1.86.0-x86_64-unknown-linux-gnu'

@github-actions
Copy link

⚠️ Recommendation: Add qa/skip-qa label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.

@steveny91 steveny91 added the qa/skip-qa Automatically skip this PR for the next QA label Jan 26, 2026
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 13048f31fb

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@steveny91
Copy link
Contributor Author

@codex review

@steveny91 steveny91 changed the title ddev build updates Update ddev build command and rust toolchain Jan 26, 2026
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c4746d4e69

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".


- name: Install Rust toolchain
uses: dtolnay/rust-toolchain@b56f20b9f22943bc548a7945b40601028db81a31 # 1.86.0 Latest rust stable version as of 2025-05-08 (https://forge.rust-lang.org/)
uses: dtolnay/rust-toolchain@stable # Stable to abide by enterprise policy

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Pin rust-toolchain action to a commit

Using dtolnay/rust-toolchain@stable pulls a floating ref, so the workflow can change behavior whenever the upstream tag moves. That creates non‑reproducible builds and a supply‑chain risk if the action is updated or compromised. This can surface as sudden build failures or unexpected toolchain behavior on any run after the tag advances. Consider pinning to a commit SHA (as is done for other actions in this workflow) and updating it intentionally when needed.

Useful? React with 👍 / 👎.

@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.06%. Comparing base (7532c0a) to head (3081be7).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants