Skip to content

Conversation

@AAraKKe
Copy link
Contributor

@AAraKKe AAraKKe commented Jan 27, 2026

What does this PR do?

This is a follow up from the PR #22410. As @sarah-witt pointed out we won't always runs actions from master, in fact, we should aim to have all our actions pinned from extras and marketplace.

This PR modifies the setup step to get the script to make it general, without special cases depending on the repo we are in, and ensures that the scripts needed to run test-target are taken from the same ref where the workflow is being used from through action_path.

Motivation

Simplify the test-target workflow and ensure it works seamlessly across our repos.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@AAraKKe AAraKKe added the qa/skip-qa Automatically skip this PR for the next QA label Jan 27, 2026
@AAraKKe AAraKKe force-pushed the aarakke/move-non-core-setup-step-to-composite-action branch from 307bd95 to 1363e70 Compare January 27, 2026 09:19
@AAraKKe AAraKKe marked this pull request as ready for review January 27, 2026 09:22
@AAraKKe AAraKKe requested a review from a team as a code owner January 27, 2026 09:22
@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.75%. Comparing base (7532c0a) to head (65437c5).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@sarah-witt sarah-witt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AAraKKe AAraKKe added this pull request to the merge queue Jan 27, 2026
Merged via the queue into master with commit 8c4d81d Jan 27, 2026
317 checks passed
@AAraKKe AAraKKe deleted the aarakke/move-non-core-setup-step-to-composite-action branch January 27, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants