-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update rust toolchain action #22422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update rust toolchain action #22422
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 18f9e793ca
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
What does this PR do?
This pr fixes
ddevbuild. We were not able to build with the pinned version of rust toolchain.To prevent this in the future we are also adding dependabot for our pinned actions with a weekly cadence. We should get a PR, at mots, once per week updating the pinned actions in our repo.
We are also adding some tags to the jobs of the build ddev pipeline to better analyze them now that we have the option and making sure we run the workflow on pushes to master with modified files in ddev as well as in a nightly schedule. This is so we catch any issues with build happening because of dependency updates on the build systems.
Motivation
Make sure we get fresh actions and enrich the worfklow with specific tags.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged