Cisco ACI: Add flag to bypass potential OOB IP comparison for topology#22572
Open
garrison-stauffer wants to merge 9 commits intomasterfrom
Open
Cisco ACI: Add flag to bypass potential OOB IP comparison for topology#22572garrison-stauffer wants to merge 9 commits intomasterfrom
garrison-stauffer wants to merge 9 commits intomasterfrom
Conversation
Contributor
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: c866f57 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
zoedt
reviewed
Feb 6, 2026
|
|
||
| # Config for submitting device/interface metadata to NDM | ||
| self.send_ndm_metadata = self.instance.get('send_ndm_metadata', False) | ||
| self.topology_skips_ip_match = self.instance.get('topology_skips_ip_match', False) |
Contributor
There was a problem hiding this comment.
if we're adding a new flag - here's a pr with other stuff to update with this !
https://github.com/DataDog/integrations-core/pull/18099/files
also, uncertain how clear to the customer how clear this may be 🤔 may need to riff on this one a bit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR addresses an issue that can happen when comparing data from Fabric nodes API (
/api/mo/topology.json) to the LLDP API (/api/node/class/lldpAdjEp.json).It appears that these endpoints will return different IPs for nodes. This PR loosens a constraint that requires the IPs to match before tagging the DataDog Device ID. This new behavior is only available when the feature is enabled in config for now.
Motivation
A customer reported this issue.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged