Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c92047bccc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # This file is autogenerated. | ||
| # To change this file you should edit assets/configuration/spec.yaml and then run the following commands: | ||
| # ddev -x validate config -s <INTEGRATION_NAME> |
There was a problem hiding this comment.
This change removes the Datadog license header from existing Python files in torchserve/datadog_checks/torchserve/config_models (the same pattern appears in __init__.py, defaults.py, instance.py, and shared.py), which will trip CI validation: validate.yml enables license-headers (.github/workflows/validate.yml:34), run-validations.yml executes ddev validate license-headers (.github/workflows/run-validations.yml:197-199), and the validator explicitly errors when an existing file’s header changes (datadog_checks_dev/datadog_checks/dev/tooling/license_headers.py:94-100).
Useful? React with 👍 / 👎.
drichards-87
left a comment
drichards-87
left a comment
There was a problem hiding this comment.
Left a suggestion from Docs and approved the PR.
| - name: interval | ||
| description: | | ||
| Refresh interval in second to use for the models to be 'autodiscovered'. | ||
| Refresh interval in seconds used for models to be 'autodiscovered'. |
There was a problem hiding this comment.
| Refresh interval in seconds used for models to be 'autodiscovered'. | |
| Refresh interval, in seconds, for models to be 'autodiscovered'. |
|
|
||
| ## @param interval - integer - optional | ||
| ## Refresh interval in second to use for the models to be 'autodiscovered'. | ||
| ## Refresh interval in seconds used for models to be 'autodiscovered'. |
There was a problem hiding this comment.
| ## Refresh interval in seconds used for models to be 'autodiscovered'. | |
| ## Refresh interval, in seconds, for models to be 'autodiscovered'. |
2 participants
What does this PR do?
Add some secret fields in spec.yamls, fix typos, and regenerate configs.
Motivation
Clean up spec.yamls for remote configuration.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged