Skip to content

Comments

ddev doesn't force writing github uname and token to config file#22691

Merged
iliakur merged 5 commits intomasterfrom
ik/ddev-reads-github-user-and-token-from-envvars
Feb 20, 2026
Merged

ddev doesn't force writing github uname and token to config file#22691
iliakur merged 5 commits intomasterfrom
ik/ddev-reads-github-user-and-token-from-envvars

Conversation

@iliakur
Copy link
Contributor

@iliakur iliakur commented Feb 19, 2026

What does this PR do?

Lets us set github username and token using only envvars without forcing us to have them in config.toml.

Motivation

I'm fed up with having to set this in the config.toml file every time. Also, security is pushing away from storing credentials in files.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@github-actions
Copy link

github-actions bot commented Feb 19, 2026

⚠️ Recommendation: Add qa/skip-qa label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.

@iliakur iliakur added the qa/skip-qa Automatically skip this PR for the next QA label Feb 19, 2026
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0e9b4abd75

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@iliakur iliakur marked this pull request as draft February 19, 2026 17:08
@iliakur iliakur marked this pull request as ready for review February 19, 2026 17:16
@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.52%. Comparing base (a76e4b3) to head (25c7c93).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

NouemanKHAL
NouemanKHAL previously approved these changes Feb 19, 2026
Copy link
Member

@NouemanKHAL NouemanKHAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I like the testing around this! 💯

Copy link
Contributor

@nubtron nubtron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nubtron
nubtron previously approved these changes Feb 20, 2026
Copy link
Contributor

@nubtron nubtron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see, that's what you're fixing!

Co-authored-by: NouemanKHAL <noueman.khalikine@datadoghq.com>
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed stale reviews from NouemanKHAL and nubtron February 20, 2026 08:59

Review from NouemanKHAL is dismissed. Related teams and files:

  • agent-integrations
    • ddev/changelog.d/22691.fixed
    • ddev/tests/config/test_model.py

Review from nubtron is dismissed. Related teams and files:

  • agent-integrations
    • ddev/changelog.d/22691.fixed
    • ddev/tests/config/test_model.py
Copy link
Member

@NouemanKHAL NouemanKHAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@iliakur iliakur added this pull request to the merge queue Feb 20, 2026
Merged via the queue into master with commit 48e08f8 Feb 20, 2026
332 checks passed
@iliakur iliakur deleted the ik/ddev-reads-github-user-and-token-from-envvars branch February 20, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ddev qa/skip-qa Automatically skip this PR for the next QA team/agent-integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants