ddev doesn't force writing github uname and token to config file#22691
ddev doesn't force writing github uname and token to config file#22691
Conversation
|
This PR does not modify any files shipped with the agent. To help streamline the release process, please consider adding the |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0e9b4abd75
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
NouemanKHAL
left a comment
There was a problem hiding this comment.
LGTM! I like the testing around this! 💯
nubtron
left a comment
There was a problem hiding this comment.
Hmm doesn't ddev already support this?
https://github.com/DataDog/integrations-core/blob/master/ddev/src/ddev/config/model.py#L9-L15
nubtron
left a comment
There was a problem hiding this comment.
Ah, I see, that's what you're fixing!
Co-authored-by: NouemanKHAL <noueman.khalikine@datadoghq.com>
Review from NouemanKHAL is dismissed. Related teams and files:
- agent-integrations
- ddev/changelog.d/22691.fixed
- ddev/tests/config/test_model.py
Review from nubtron is dismissed. Related teams and files:
- agent-integrations
- ddev/changelog.d/22691.fixed
- ddev/tests/config/test_model.py
What does this PR do?
Lets us set github username and token using only envvars without forcing us to have them in
config.toml.Motivation
I'm fed up with having to set this in the config.toml file every time. Also, security is pushing away from storing credentials in files.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged