Skip to content

Revert "[SNMP] Add type metadata field to_generic-if profile" #22695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TCheruy wants to merge 1 commit into from
+1 −15
Closed

Revert "[SNMP] Add type metadata field to_generic-if profile" #22695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions snmp/datadog_checks/snmp/data/default_profiles/_generic-if.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@ metadata:
symbol:
OID: 1.3.6.1.2.1.31.1.1.1.18
name: ifAlias
type:
symbol:
OID: 1.3.6.1.2.1.2.2.1.3
name: ifType
id_tags:
- symbol:
OID: 1.3.6.1.2.1.31.1.1.1.1
Expand Down
2 changes: 1 addition & 1 deletion snmp/tests/compose/data/f5-big-ip.snmprec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
1.3.6.1.2.1.2.2.1.2.112|4x|2f436f6d6d6f6e2f696e7465726e616c
1.3.6.1.2.1.2.2.1.3.32|2|6
1.3.6.1.2.1.2.2.1.3.48|2|6
1.3.6.1.2.1.2.2.1.3.80|2|1
1.3.6.1.2.1.2.2.1.3.80|2|0
1.3.6.1.2.1.2.2.1.3.96|2|0
1.3.6.1.2.1.2.2.1.3.112|2|6
1.3.6.1.2.1.2.2.1.4.32|2|1460
Expand Down
10 changes: 0 additions & 10 deletions snmp/tests/test_e2e_core_metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,11 +116,9 @@ def test_e2e_core_metadata_f5(dd_agent_check):
'device_id': device_id,
'id_tags': ['interface:/Common/internal'],
'index': 112,
'is_physical': True,
'mac_address': '42:01:0a:a4:00:33',
'name': '/Common/internal',
'oper_status': 1,
'type': 6,
},
{
'admin_status': 1,
Expand All @@ -129,11 +127,9 @@ def test_e2e_core_metadata_f5(dd_agent_check):
'device_id': device_id,
'id_tags': ['interface:mgmt'],
'index': 32,
'is_physical': True,
'mac_address': '42:01:0a:a4:00:33',
'name': 'mgmt',
'oper_status': 1,
'type': 6,
},
{
'admin_status': 1,
Expand All @@ -142,11 +138,9 @@ def test_e2e_core_metadata_f5(dd_agent_check):
'device_id': device_id,
'id_tags': ['interface:1.0'],
'index': 48,
'is_physical': True,
'mac_address': '42:01:0a:a4:00:33',
'name': '1.0',
'oper_status': 1,
'type': 6,
},
{
'admin_status': 1,
Expand All @@ -155,11 +149,9 @@ def test_e2e_core_metadata_f5(dd_agent_check):
'device_id': device_id,
'id_tags': ['interface:/Common/http-tunnel'],
'index': 80,
'is_physical': False,
'mac_address': '42:01:0a:a4:00:34',
'name': '/Common/http-tunnel',
'oper_status': 4,
'type': 1,
},
{
'admin_status': 1,
Expand Down Expand Up @@ -254,11 +246,9 @@ def test_e2e_core_metadata_cisco_3850(dd_agent_check):
'device_id': 'default:' + device_ip,
'id_tags': ['interface:Gi0/0'],
'index': 1,
'is_physical': True,
'mac_address': '00:00:00:00:00:00',
'name': 'Gi0/0',
'oper_status': 2,
'type': 6,
}
assert interface == actual_interface

Expand Down
Loading