-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(.builders): store hashes of all dependency resolution inputs in metadata.json #22952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dkirov-dd
wants to merge
3
commits into
master
Choose a base branch
from
dk/AI-6466/store-hashes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,6 +22,7 @@ | |
| RESOLUTION_DIR = REPO_DIR / '.deps' | ||
| LOCK_FILE_DIR = RESOLUTION_DIR / 'resolved' | ||
| DIRECT_DEP_FILE = REPO_DIR / 'agent_requirements.in' | ||
| WORKFLOW_FILE = REPO_DIR / '.github/workflows/resolve-build-deps.yaml' | ||
| CACHE_CONTROL = 'public, max-age=15' | ||
| VALID_PROJECT_NAME = re.compile(r'^([A-Z0-9]|[A-Z0-9][A-Z0-9._-]*[A-Z0-9])$', re.IGNORECASE) | ||
| UNNORMALIZED_PROJECT_NAME_CHARS = re.compile(r'[-_.]+') | ||
|
|
@@ -76,6 +77,32 @@ def hash_file(path: Path) -> str: | |
| return sha256(f.read()).hexdigest() | ||
|
|
||
|
|
||
| def hash_directory(path: Path) -> str: | ||
| """Compute a combined SHA256 hash of all files in a directory.""" | ||
| h = sha256() | ||
| for file_path in sorted(path.rglob('*'), key=lambda p: p.relative_to(path)): | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| rel = file_path.relative_to(path) | ||
| if file_path.is_file() and not any( | ||
| part in {'__pycache__', '.pytest_cache'} or part.endswith('.pyc') | ||
| for part in rel.parts | ||
| ): | ||
| h.update(rel.as_posix().encode()) | ||
| h.update(file_path.read_bytes()) | ||
| return h.hexdigest() | ||
|
|
||
|
|
||
| def compute_input_hashes() -> dict[str, str]: | ||
| """Compute SHA256 hashes for all dependency resolution inputs.""" | ||
| try: | ||
| return { | ||
| DIRECT_DEP_FILE.relative_to(REPO_DIR).as_posix(): hash_file(DIRECT_DEP_FILE), | ||
| WORKFLOW_FILE.relative_to(REPO_DIR).as_posix(): hash_file(WORKFLOW_FILE), | ||
| BUILDER_DIR.relative_to(REPO_DIR).as_posix(): hash_directory(BUILDER_DIR), | ||
| } | ||
| except FileNotFoundError as e: | ||
| raise RuntimeError(f'Missing dependency resolution input: {e}') from e | ||
|
|
||
|
|
||
| def _build_number_of_wheel(wheel_info: dict) -> int: | ||
| """Extract the build number from wheel information.""" | ||
| wheel_name = PurePosixPath(wheel_info['name']).stem | ||
|
|
@@ -279,9 +306,11 @@ def generate_lockfiles(targets_dir, lockfiles): | |
| targets_dir = Path(targets_dir) | ||
| LOCK_FILE_DIR.mkdir(parents=True, exist_ok=True) | ||
| with RESOLUTION_DIR.joinpath('metadata.json').open('w', encoding='utf-8') as f: | ||
| inputs = compute_input_hashes() | ||
| contents = json.dumps( | ||
| { | ||
| 'sha256': sha256(DIRECT_DEP_FILE.read_bytes()).hexdigest(), | ||
| 'inputs': inputs, | ||
| 'sha256': inputs['agent_requirements.in'], | ||
| }, | ||
| indent=2, | ||
| sort_keys=True, | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
patched_input_filesis not used in the function.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done