-
Notifications
You must be signed in to change notification settings - Fork 811
[ECOINT-304] Add CockroachDB storage and KV metrics #2814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[ECOINT-304] Add CockroachDB storage and KV metrics #2814
Conversation
Adds the following metrics using their DataDog names: - `storage_wal_fsync_latency` - `rebalancing_replicas_queriespersecond` - `range_merges` - `rebalancing_lease_transfers` - `rebalancing_range_rebalances` See also cockroachdb/docs#19425, where these were added to the CockroachDB docs.
33425d6 to
ccd2dd5
Compare
|
Hi @estherk15! i noticed you reviewed this previous Cockroach Cloud metrics PR a while ago: Are you the right person to ask for a review on this one? Or do you know who I should ask? Thanks! |
|
hi @dd-dominic I noticed you reviewed #2812 - any chance you could take a peek at this one? |
|
@rmloveland thanks for opening a PR. Please update the changelog with an entry for 2.1.0. The current changelog also needs to be reformatted. Dates should be added to each entry and the order needs to be in descending order - the latest entry (2.1.0) should be first. See this format: https://docs.datadoghq.com/developers/integrations/agent_integration/?tab=buildanoutoftheboxintegration#bumping-an-integration-version |
Thanks @dd-dominic ! Updated the changelog and reformatted to use descending order, with dates. Please take a look! Happy to update further as needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We recently added a sample_tags column. If the integration is providing tags by default , please add them in this column. See https://docs.datadoghq.com/developers/integrations/check_references/#metrics-metadata-file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dd-dominic I don't know offhand if the integration is providing these tags. Since it's listed as an optional attribute in the documentation, could we add that info in a followup PR? I'd love to get these storage metrics documented and then do more of the metadata/housekeeping stuff separately if that's possible. Please let me know what you think!
|
This pull request has not been updated for more than 21 days. If there are no updates to this PR within 7 days, it will be closed. If you'd like to re-open this PR after it's been closed, you can start from the latest master branch or pull the latest changes into your branch and create a new pull request. |
Co-authored-by: Dominic Medina <[email protected]>
What does this PR do?
Adds the following CockroachDB metrics (related to Storage and KV layers) using their DataDog names:
storage_wal_fsync_latencyrebalancing_replicas_queriespersecondrange_mergesrebalancing_lease_transfersrebalancing_range_rebalancesSee also cockroachdb/docs#19425, where these were added to the CockroachDB docs.
Motivation
Integration of these important KV & storage metrics with DataDog
Review checklist
no-changeloglabel attached