-
Notifications
You must be signed in to change notification settings - Fork 811
[ECOINT-305] Add live bandwidth metric #2842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hey @dd-dominic - apologies, I didn't notice I was working off of my outdated fork and accidentally removed the branch completely (fortunately had backups). This should be all updated now! |
Co-authored-by: Dominic Medina <[email protected]>
Co-authored-by: Dominic Medina <[email protected]>
Co-authored-by: Dominic Medina <[email protected]>
|
Ignore the ci validation - we can merge without it passing for now |
|
Waiting on agent team to take a look |
|
Hey @dd-dominic, just a friendly bump on this one. We have a customer waiting for this feature to be implemented so they can start monitoring their bandwidth and build a data backlog view in their buckets. 🙏 |
|
Hi DD Team, we have an Enterprise customer that is urgently requesting this new capability. Are we able to get this update approved? |
dkirov-dd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I just noticed that the validate CI job is failing.
Here's how to fix it:
- Update the
assets/configuration/spec.yamlto contain the newenable_realtime_bandwidthtoggle and its description - Run
ddev validate config cloudsmith -sto sync theconf.yaml.examplewith the spec
After that we should be good to merge!
|
Thank you @dkirov-dd - That's been done. |
This pull request adds support for a new real-time bandwidth metric to the Cloudsmith Datadog integration, allowing users to monitor minute-level bandwidth usage via the Cloudsmith v2 analytics endpoint. The metric is disabled by default and can be enabled through configuration. Documentation, configuration, code, and tests have all been updated to support and verify this new feature.
Realtime Bandwidth Metric Feature:
cloudsmith.bandwidth_bytes_intervalmetric, which tracks bytes downloaded over the most recent analytics interval using Cloudsmith v2 analytics endpoints. The metric is disabled by default and can be enabled with theenable_realtime_bandwidth: trueconfiguration option. Internal defaults (1-minute interval, 120-minute look-back, 300s refresh, minimum 2 points) are used for metric collection. [1] [2] [3] [4] [5] [6]Documentation Updates:
README.mdandCHANGELOG.mdto document the new metric, its configuration, and usage instructions, including example YAML configuration and installation version bump. [1] [2] [3] [4]Versioning:
1.2.0to reflect the new feature addition.Testing:
API Changes:
ANALYTICS_METRICS_CLIENT_TIME_SERIESfor accessing Cloudsmith v2 analytics time-series data.### What does this PR do?A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Review checklist
no-changeloglabel attachedAdditional Notes
Anything else we should know when reviewing?