Skip to content

Conversation

morrisonlevi
Copy link
Contributor

@morrisonlevi morrisonlevi commented Apr 9, 2025

PROF-11721

What does this PR do?

This upgrades nix from v0.27 to v0.29. There's an off-by-one error in the new Backlog type, so this lowers the backlog used for listen from 128 to 127.

Also pins simd-json to 0.14. I noticed v0.15 requires Rust 1.85 and I was editing this file anyway.

Motivation

Version 0.29 was already in our tree, so this removes a duplicate dependency (everything is now on 0.29).

Additional Notes

I tried to use Cursor to do this upgrade, and it failed, even when I provided the changelog for versions 0.29 and 0.28. Did it all manually.

How to test the change?

Everything should test the same.

Version 0.29 was already in our tree, so this removes a duplicate
dependency (everything is now on 0.29).
@morrisonlevi morrisonlevi requested review from a team as code owners April 9, 2025 18:32
@morrisonlevi morrisonlevi changed the title Levi/nix build: upgrade nix from 0.27 to 0.29 Apr 9, 2025
@pr-commenter
Copy link

pr-commenter bot commented Apr 9, 2025

Benchmarks

Comparison

Benchmark execution time: 2025-04-10 17:33:36

Comparing candidate commit d1fae1a in PR branch levi/nix with baseline commit 951f454 in branch main.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 2 unstable metrics.

scenario:credit_card/is_card_number/ 378282246310005

  • 🟩 execution_time [-9.140µs; -9.009µs] or [-11.366%; -11.203%]
  • 🟩 throughput [+1570478.752op/s; +1593240.589op/s] or [+12.629%; +12.812%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d1fae1a 1744305708 levi/nix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 6.013ms 6.027ms ± 0.006ms 6.027ms ± 0.004ms 6.031ms 6.036ms 6.038ms 6.058ms 0.51% 0.615 2.717 0.10% 0.000ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [6.026ms; 6.028ms] or [-0.013%; +0.013%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d1fae1a 1744305708 levi/nix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 503.997µs 505.381µs ± 0.655µs 505.326µs ± 0.251µs 505.621µs 505.994µs 506.260µs 512.654µs 1.45% 6.833 74.480 0.13% 0.046µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1950631.680op/s 1978706.776op/s ± 2541.269op/s 1978919.668op/s ± 981.802op/s 1979831.403op/s 1981278.798op/s 1982710.720op/s 1984138.138op/s 0.26% -6.718 72.842 0.13% 179.695op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 453.605µs 455.210µs ± 0.484µs 455.205µs ± 0.318µs 455.548µs 456.004µs 456.245µs 456.586µs 0.30% -0.120 0.274 0.11% 0.034µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2190168.378op/s 2196788.566op/s ± 2334.712op/s 2196814.597op/s ± 1533.931op/s 2198211.343op/s 2200454.652op/s 2202427.867op/s 2204560.994op/s 0.35% 0.127 0.281 0.11% 165.089op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 176.420µs 177.265µs ± 0.577µs 177.256µs ± 0.196µs 177.431µs 177.723µs 177.910µs 182.430µs 2.92% 6.032 49.592 0.32% 0.041µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5481555.302op/s 5641323.666op/s ± 18007.310op/s 5641548.659op/s ± 6246.177op/s 5649744.179op/s 5658890.149op/s 5664252.424op/s 5668299.413op/s 0.47% -5.884 47.969 0.32% 1273.309op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.515µs 37.626µs ± 0.039µs 37.625µs ± 0.024µs 37.648µs 37.688µs 37.740µs 37.768µs 0.38% 0.442 1.268 0.10% 0.003µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26477584.618op/s 26577660.265op/s ± 27760.965op/s 26578075.100op/s ± 17225.249op/s 26596287.249op/s 26617695.755op/s 26647643.578op/s 26655988.116op/s 0.29% -0.433 1.254 0.10% 1962.997op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.227µs 48.305µs ± 0.033µs 48.302µs ± 0.023µs 48.326µs 48.367µs 48.385µs 48.397µs 0.20% 0.477 -0.093 0.07% 0.002µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20662238.843op/s 20701763.777op/s ± 13966.551op/s 20702906.006op/s ± 9914.091op/s 20712544.482op/s 20721740.091op/s 20727126.634op/s 20735155.514op/s 0.16% -0.473 -0.097 0.07% 987.584op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [505.291µs; 505.472µs] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1978354.580op/s; 1979058.971op/s] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [455.143µs; 455.277µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2196464.997op/s; 2197112.134op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [177.185µs; 177.345µs] or [-0.045%; +0.045%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5638828.026op/s; 5643819.306op/s] or [-0.044%; +0.044%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.620µs; 37.631µs] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26573812.862op/s; 26581507.668op/s] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [48.301µs; 48.310µs] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20699828.148op/s; 20703699.407op/s] or [-0.009%; +0.009%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d1fae1a 1744305708 levi/nix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 31.772µs 32.605µs ± 1.156µs 31.875µs ± 0.068µs 33.823µs 34.642µs 34.689µs 35.095µs 10.10% 0.966 -0.952 3.54% 0.082µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [32.445µs; 32.765µs] or [-0.491%; +0.491%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d1fae1a 1744305708 levi/nix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 73.420ms 73.951ms ± 0.286ms 73.894ms ± 0.147ms 74.122ms 74.485ms 74.804ms 75.044ms 1.56% 0.981 1.096 0.39% 0.020ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [73.911ms; 73.991ms] or [-0.054%; +0.054%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d1fae1a 1744305708 levi/nix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.327µs 2.386µs ± 0.017µs 2.389µs ± 0.005µs 2.393µs 2.409µs 2.415µs 2.428µs 1.63% -1.705 4.331 0.70% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.384µs; 2.388µs] or [-0.097%; +0.097%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d1fae1a 1744305708 levi/nix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 246.576ns 254.870ns ± 13.051ns 248.388ns ± 1.153ns 256.281ns 285.890ns 295.788ns 303.577ns 22.22% 1.909 2.583 5.11% 0.923ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [253.061ns; 256.679ns] or [-0.710%; +0.710%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d1fae1a 1744305708 levi/nix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 208.735µs 209.112µs ± 0.156µs 209.096µs ± 0.099µs 209.215µs 209.405µs 209.486µs 209.575µs 0.23% 0.239 0.042 0.07% 0.011µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4771572.245op/s 4782123.884op/s ± 3556.201op/s 4782483.994op/s ± 2271.138op/s 4784491.549op/s 4787885.851op/s 4789730.442op/s 4790765.321op/s 0.17% -0.234 0.040 0.07% 251.461op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.618µs 18.682µs ± 0.031µs 18.676µs ± 0.014µs 18.693µs 18.745µs 18.782µs 18.841µs 0.89% 1.780 5.049 0.16% 0.002µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 53074879.659op/s 53528111.292op/s ± 87882.005op/s 53545944.008op/s ± 39119.822op/s 53578997.578op/s 53631647.708op/s 53675157.846op/s 53711290.887op/s 0.31% -1.761 4.954 0.16% 6214.196op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.930µs 10.988µs ± 0.036µs 10.986µs ± 0.026µs 11.012µs 11.043µs 11.070µs 11.089µs 0.94% 0.237 -0.673 0.33% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 90176016.648op/s 91010979.757op/s ± 298420.881op/s 91024717.776op/s ± 211012.984op/s 91210708.175op/s 91445389.367op/s 91473394.129op/s 91495171.870op/s 0.52% -0.225 -0.689 0.33% 21101.543op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [209.091µs; 209.134µs] or [-0.010%; +0.010%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4781631.029op/s; 4782616.739op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.678µs; 18.686µs] or [-0.023%; +0.023%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [53515931.691op/s; 53540290.893op/s] or [-0.023%; +0.023%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.983µs; 10.993µs] or [-0.045%; +0.045%] None None None
normalization/normalize_name/normalize_name/good throughput [90969621.493op/s; 91052338.021op/s] or [-0.045%; +0.045%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d1fae1a 1744305708 levi/nix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.893µs 3.913µs ± 0.003µs 3.913µs ± 0.002µs 3.915µs 3.917µs 3.918µs 3.920µs 0.16% -1.702 7.479 0.08% 0.000µs 1 200
credit_card/is_card_number/ throughput 255126561.640op/s 255557756.299op/s ± 208735.524op/s 255531351.518op/s ± 122621.411op/s 255656608.895op/s 255929313.225op/s 256060618.307op/s 256900765.647op/s 0.54% 1.718 7.602 0.08% 14759.830op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 76.749µs 77.398µs ± 0.438µs 77.328µs ± 0.312µs 77.661µs 78.199µs 78.469µs 79.030µs 2.20% 0.805 0.324 0.56% 0.031µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12653423.982op/s 12920686.985op/s ± 72761.038op/s 12931945.641op/s ± 52079.559op/s 12981334.140op/s 13010989.222op/s 13021141.979op/s 13029552.328op/s 0.75% -0.777 0.238 0.56% 5144.982op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 70.784µs 71.339µs ± 0.311µs 71.295µs ± 0.205µs 71.499µs 71.941µs 72.252µs 72.441µs 1.61% 1.013 0.872 0.43% 0.022µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13804399.491op/s 14017763.473op/s ± 60841.110op/s 14026149.570op/s ± 40390.354op/s 14066459.233op/s 14088707.706op/s 14110452.410op/s 14127579.861op/s 0.72% -0.989 0.803 0.43% 4302.116op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.895µs 3.914µs ± 0.003µs 3.914µs ± 0.002µs 3.915µs 3.918µs 3.920µs 3.921µs 0.19% -1.291 8.751 0.07% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255029422.673op/s 255518637.573op/s ± 183758.075op/s 255509766.731op/s ± 103291.472op/s 255616436.139op/s 255828234.618op/s 255921369.473op/s 256734845.036op/s 0.48% 1.310 8.883 0.07% 12993.658op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 67.097µs 67.802µs ± 0.386µs 67.713µs ± 0.258µs 68.031µs 68.485µs 68.732µs 69.606µs 2.80% 0.906 1.531 0.57% 0.027µs 1 200
credit_card/is_card_number/378282246310005 throughput 14366489.736op/s 14749311.221op/s ± 83598.570op/s 14768236.477op/s ± 55981.101op/s 14809236.521op/s 14860189.500op/s 14887336.184op/s 14903708.949op/s 0.92% -0.861 1.342 0.57% 5911.312op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 51.736µs 51.831µs ± 0.035µs 51.833µs ± 0.019µs 51.852µs 51.885µs 51.901µs 51.905µs 0.14% -0.361 -0.037 0.07% 0.002µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19266122.450op/s 19293605.784op/s ± 12875.660op/s 19292802.820op/s ± 7212.049op/s 19299998.553op/s 19319761.605op/s 19323831.037op/s 19328987.683op/s 0.19% 0.365 -0.034 0.07% 910.447op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.026µs 6.046µs ± 0.017µs 6.039µs ± 0.003µs 6.045µs 6.080µs 6.105µs 6.112µs 1.22% 1.645 1.966 0.28% 0.001µs 1 200
credit_card/is_card_number/x371413321323331 throughput 163606273.742op/s 165408318.319op/s ± 469639.523op/s 165595788.884op/s ± 88280.271op/s 165662589.554op/s 165847409.691op/s 165902673.707op/s 165935331.342op/s 0.21% -1.635 1.915 0.28% 33208.529op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.895µs 3.914µs ± 0.003µs 3.914µs ± 0.002µs 3.915µs 3.917µs 3.919µs 3.921µs 0.17% -1.554 7.130 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255057857.205op/s 255514184.738op/s ± 189302.757op/s 255500025.550op/s ± 103120.188op/s 255604126.734op/s 255868504.379op/s 256001000.666op/s 256706984.902op/s 0.47% 1.569 7.232 0.07% 13385.726op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 65.949µs 66.246µs ± 0.153µs 66.214µs ± 0.075µs 66.312µs 66.491µs 66.870µs 66.898µs 1.03% 1.710 4.497 0.23% 0.011µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 14948190.660op/s 15095259.281op/s ± 34647.557op/s 15102571.980op/s ± 17036.187op/s 15115776.716op/s 15138209.144op/s 15147415.466op/s 15163264.171op/s 0.40% -1.686 4.393 0.23% 2449.952op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 59.502µs 59.651µs ± 0.059µs 59.647µs ± 0.043µs 59.692µs 59.747µs 59.788µs 59.916µs 0.45% 0.342 1.212 0.10% 0.004µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 16690105.668op/s 16764135.772op/s ± 16616.639op/s 16765227.245op/s ± 12046.520op/s 16775434.900op/s 16790637.461op/s 16803219.581op/s 16806223.345op/s 0.24% -0.333 1.185 0.10% 1174.974op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.896µs 3.913µs ± 0.003µs 3.913µs ± 0.002µs 3.915µs 3.918µs 3.919µs 3.920µs 0.17% -0.923 4.816 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 255117394.425op/s 255539475.356op/s ± 190210.566op/s 255556210.447op/s ± 104556.320op/s 255637271.915op/s 255850879.724op/s 255970621.962op/s 256649001.464op/s 0.43% 0.937 4.892 0.07% 13449.918op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 56.223µs 56.414µs ± 0.103µs 56.400µs ± 0.058µs 56.463µs 56.628µs 56.689µs 56.739µs 0.60% 0.877 0.579 0.18% 0.007µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17624530.178op/s 17726206.631op/s ± 32346.463op/s 17730349.867op/s ± 18240.454op/s 17748203.643op/s 17769331.201op/s 17782718.760op/s 17786244.119op/s 0.32% -0.868 0.561 0.18% 2287.240op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 51.740µs 51.836µs ± 0.039µs 51.842µs ± 0.019µs 51.859µs 51.894µs 51.912µs 52.017µs 0.34% 0.050 1.802 0.07% 0.003µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19224664.308op/s 19291599.999op/s ± 14394.953op/s 19289343.602op/s ± 7166.842op/s 19299409.438op/s 19317712.703op/s 19323429.490op/s 19327315.295op/s 0.20% -0.041 1.776 0.07% 1017.877op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.028µs 6.047µs ± 0.018µs 6.040µs ± 0.004µs 6.046µs 6.078µs 6.116µs 6.124µs 1.39% 1.980 3.842 0.30% 0.001µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 163281213.983op/s 165366444.097op/s ± 488814.273op/s 165556483.990op/s ± 108680.264op/s 165647294.851op/s 165777303.341op/s 165841101.033op/s 165904182.812op/s 0.21% -1.963 3.744 0.29% 34564.389op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.913µs; 3.913µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ throughput [255528827.563op/s; 255586685.035op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [77.337µs; 77.458µs] or [-0.078%; +0.078%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12910603.005op/s; 12930770.965op/s] or [-0.078%; +0.078%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [71.296µs; 71.382µs] or [-0.060%; +0.060%] None None None
credit_card/is_card_number/ 378282246310005 throughput [14009331.480op/s; 14026195.465op/s] or [-0.060%; +0.060%] None None None
credit_card/is_card_number/37828224631 execution_time [3.913µs; 3.914µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/37828224631 throughput [255493170.471op/s; 255544104.675op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/378282246310005 execution_time [67.748µs; 67.855µs] or [-0.079%; +0.079%] None None None
credit_card/is_card_number/378282246310005 throughput [14737725.263op/s; 14760897.179op/s] or [-0.079%; +0.079%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [51.826µs; 51.835µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19291821.341op/s; 19295390.227op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.043µs; 6.048µs] or [-0.040%; +0.040%] None None None
credit_card/is_card_number/x371413321323331 throughput [165343230.798op/s; 165473405.840op/s] or [-0.039%; +0.039%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.913µs; 3.914µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [255487949.196op/s; 255540420.279op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [66.225µs; 66.267µs] or [-0.032%; +0.032%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15090457.462op/s; 15100061.099op/s] or [-0.032%; +0.032%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [59.643µs; 59.659µs] or [-0.014%; +0.014%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [16761832.865op/s; 16766438.678op/s] or [-0.014%; +0.014%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.913µs; 3.914µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255513114.001op/s; 255565836.711op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [56.400µs; 56.428µs] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [17721723.722op/s; 17730689.540op/s] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [51.831µs; 51.841µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19289604.997op/s; 19293595.001op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.045µs; 6.050µs] or [-0.041%; +0.041%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165298699.139op/s; 165434189.054op/s] or [-0.041%; +0.041%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d1fae1a 1744305708 levi/nix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 146.727µs 147.328µs ± 0.229µs 147.324µs ± 0.128µs 147.447µs 147.665µs 148.046µs 148.217µs 0.61% 0.666 2.195 0.16% 0.016µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [147.296µs; 147.360µs] or [-0.022%; +0.022%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d1fae1a 1744305708 levi/nix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 68.190µs 68.533µs ± 0.310µs 68.452µs ± 0.116µs 68.663µs 68.842µs 69.045µs 71.991µs 5.17% 7.130 75.939 0.45% 0.022µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [68.490µs; 68.576µs] or [-0.063%; +0.063%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d1fae1a 1744305708 levi/nix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.548µs 25.733µs ± 11.285µs 17.737µs ± 0.144µs 35.898µs 41.954µs 55.970µs 97.901µs 451.97% 1.878 7.220 43.74% 0.798µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.169µs; 27.297µs] or [-6.078%; +6.078%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d1fae1a 1744305708 levi/nix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.193µs 3.179µs ± 1.506µs 2.976µs ± 0.024µs 2.998µs 3.613µs 13.810µs 16.924µs 468.59% 7.616 59.485 47.25% 0.106µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.970µs; 3.388µs] or [-6.565%; +6.565%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d1fae1a 1744305708 levi/nix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.920µs 4.980µs ± 0.041µs 4.986µs ± 0.042µs 5.011µs 5.036µs 5.041µs 5.042µs 1.11% -0.011 -1.546 0.81% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [4.974µs; 4.985µs] or [-0.113%; +0.113%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.51%. Comparing base (951f454) to head (d1fae1a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1014      +/-   ##
==========================================
- Coverage   71.55%   71.51%   -0.05%     
==========================================
  Files         337      337              
  Lines       50707    50705       -2     
==========================================
- Hits        36285    36263      -22     
- Misses      14422    14442      +20     
Components Coverage Δ
crashtracker 42.69% <ø> (-0.03%) ⬇️
crashtracker-ffi 6.30% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 90.93% <ø> (ø)
data-pipeline-ffi 90.35% <ø> (ø)
ddcommon 79.98% <ø> (ø)
ddcommon-ffi 66.37% <ø> (ø)
ddtelemetry 60.29% <ø> (ø)
ddtelemetry-ffi 21.43% <ø> (ø)
dogstatsd-client 82.57% <ø> (ø)
ipc 82.41% <100.00%> (-0.01%) ⬇️
profiling 77.45% <ø> (-0.02%) ⬇️
profiling-ffi 62.28% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 41.31% <ø> (-0.34%) ⬇️
sidecar-ffi 3.38% <ø> (-2.65%) ⬇️
spawn-worker 54.37% <ø> (ø)
tinybytes 89.86% <ø> (ø)
trace-mini-agent 73.82% <ø> (ø)
trace-normalization 98.24% <ø> (ø)
trace-obfuscation 96.00% <ø> (ø)
trace-protobuf 78.50% <ø> (ø)
trace-utils 92.69% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@morrisonlevi morrisonlevi enabled auto-merge (squash) April 9, 2025 19:21
@morrisonlevi
Copy link
Contributor Author

morrisonlevi commented Apr 9, 2025

There are test failures in GitLab with the sidecar failing to start. It seems possible that this PR affects it given that it changes some things in IPC and sidecar. I'm waiting on Bob's opinion and investigation into the failures.

@morrisonlevi
Copy link
Contributor Author

There is a bug in nix 0.29.0: nix-rust/nix#2500. It's been fixed but not released. Work around by lowering backlog from 128 to 127.

Copy link
Contributor

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Levi :-)

@r1viollet
Copy link
Contributor

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 78.07 MB 78.04 MB --.02% (-23.86 KB) 💪
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.78 MB 7.78 MB -0% (-680 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 24.22 MB 24.22 MB --.02% (-7.18 KB) 💪
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 72.41 MB 72.41 MB -0% (-1.84 KB) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 22.82 MB 22.82 MB -0% (-1.10 KB) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 7.72 MB 7.72 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 17.01 MB 17.01 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 61.83 KB 61.83 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 114.23 MB 114.26 MB +.02% (+32.00 KB) 🔍
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 633.90 MB 633.90 MB +0% (+786 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 5.06 MB 5.06 MB -0% (-512 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 61.83 KB 61.83 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 16.15 MB 16.15 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 26.84 MB 26.83 MB --.02% (-7.98 KB) 💪
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 14.40 MB 14.40 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 62.78 KB 62.78 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 116.22 MB 116.22 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 625.85 MB 625.85 MB -0% (-342 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 3.83 MB 3.83 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 62.78 KB 62.78 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 16.77 MB 16.77 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 24.74 MB 24.74 MB +0% (+132 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 67.29 MB 67.29 MB +0% (+760 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.27 MB 8.27 MB +0% (+8 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 23.35 MB 23.35 MB +0% (+488 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 68.23 MB 68.24 MB +0% (+1.75 KB) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 8.15 MB 8.15 MB +0% (+248 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 20.99 MB 20.99 MB -0% (-56 B) 👌

@morrisonlevi morrisonlevi merged commit a6d35c8 into main Apr 10, 2025
35 checks passed
@morrisonlevi morrisonlevi deleted the levi/nix branch April 10, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants