-
Notifications
You must be signed in to change notification settings - Fork 15
build: upgrade nix from 0.27 to 0.29 #1014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Version 0.29 was already in our tree, so this removes a duplicate dependency (everything is now on 0.29).
BenchmarksComparisonBenchmark execution time: 2025-04-10 17:33:36 Comparing candidate commit d1fae1a in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 2 unstable metrics. scenario:credit_card/is_card_number/ 378282246310005
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
BaselineOmitted due to size. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1014 +/- ##
==========================================
- Coverage 71.55% 71.51% -0.05%
==========================================
Files 337 337
Lines 50707 50705 -2
==========================================
- Hits 36285 36263 -22
- Misses 14422 14442 +20
🚀 New features to boost your workflow:
|
There are test failures in GitLab with the sidecar failing to start. It seems possible that this PR affects it given that it changes some things in IPC and sidecar. I'm waiting on Bob's opinion and investigation into the failures. |
There is a bug in nix 0.29.0: nix-rust/nix#2500. It's been fixed but not released. Work around by lowering backlog from 128 to 127. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks Levi :-)
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
PROF-11721
What does this PR do?
This upgrades nix from v0.27 to v0.29. There's an off-by-one error in the new
Backlog
type, so this lowers the backlog used forlisten
from 128 to 127.Also pins simd-json to 0.14. I noticed v0.15 requires Rust 1.85 and I was editing this file anyway.
Motivation
Version 0.29 was already in our tree, so this removes a duplicate dependency (everything is now on 0.29).
Additional Notes
I tried to use Cursor to do this upgrade, and it failed, even when I provided the changelog for versions 0.29 and 0.28. Did it all manually.
How to test the change?
Everything should test the same.