-
Notifications
You must be signed in to change notification settings - Fork 15
[Build] Remove unused build-<config/profiling/telemetry>.sh scripts #1192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] Remove unused build-<config/profiling/telemetry>.sh scripts #1192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also remove the section regarding -ffi.sh scripts from the README.md?
Done! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1192 +/- ##
=======================================
Coverage 71.72% 71.72%
=======================================
Files 349 349
Lines 55114 55114
=======================================
+ Hits 39528 39532 +4
+ Misses 15586 15582 -4
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
|
What does this PR do?
Removes unused build scripts
Motivation
We build ffi through builder crate
Additional Notes
libddprof-build
changed to use builder crate in this PRconfig
andtelemetry
deletion confirmed hereHow to test the change?
Describe here in detail how the change can be validated.