Skip to content

Conversation

gyuheon0h
Copy link
Contributor

@gyuheon0h gyuheon0h commented Aug 28, 2025

What does this PR do?

Removes unused build scripts

Motivation

We build ffi through builder crate

Additional Notes

libddprof-build changed to use builder crate in this PR
config and telemetry deletion confirmed here

How to test the change?

Describe here in detail how the change can be validated.

@gyuheon0h gyuheon0h requested review from a team as code owners August 28, 2025 19:03
Copy link
Contributor

@taegyunkim taegyunkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also remove the section regarding -ffi.sh scripts from the README.md?

@gyuheon0h gyuheon0h requested a review from a team as a code owner August 28, 2025 19:06
@gyuheon0h
Copy link
Contributor Author

Can you also remove the section regarding -ffi.sh scripts from the README.md?

Done!

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.72%. Comparing base (aa11985) to head (02562e9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1192   +/-   ##
=======================================
  Coverage   71.72%   71.72%           
=======================================
  Files         349      349           
  Lines       55114    55114           
=======================================
+ Hits        39528    39532    +4     
+ Misses      15586    15582    -4     
Components Coverage Δ
datadog-crashtracker 47.06% <ø> (-0.08%) ⬇️
datadog-crashtracker-ffi 5.93% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 90.44% <ø> (ø)
data-pipeline-ffi 88.56% <ø> (ø)
ddcommon 83.98% <ø> (ø)
ddcommon-ffi 70.64% <ø> (ø)
ddtelemetry 60.07% <ø> (ø)
ddtelemetry-ffi 21.32% <ø> (ø)
dogstatsd-client 83.26% <ø> (ø)
datadog-ipc 82.39% <ø> (ø)
datadog-profiling 77.14% <ø> (ø)
datadog-profiling-ffi 62.12% <ø> (ø)
datadog-sidecar 36.64% <ø> (ø)
datdog-sidecar-ffi 8.76% <ø> (ø)
spawn-worker 55.35% <ø> (ø)
tinybytes 92.22% <ø> (ø)
datadog-trace-normalization 98.24% <ø> (ø)
datadog-trace-obfuscation 94.17% <ø> (ø)
datadog-trace-protobuf 77.10% <ø> (ø)
datadog-trace-utils 89.92% <ø> (ø)
datadog-tracer-flare 56.08% <ø> (ø)
datadog-log 76.31% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@gleocadie gleocadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gyuheon0h
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Aug 28, 2025

View all feedbacks in Devflow UI.

2025-08-28 20:48:12 UTC ℹ️ Start processing command /merge


2025-08-28 20:48:20 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 41m (p90).


2025-08-28 21:30:08 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 80c0abe into main Aug 28, 2025
46 of 48 checks passed
@dd-mergequeue dd-mergequeue bot deleted the gyuheon0h/prof-12392-remove-unused-scripts branch August 28, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants