Skip to content

Fix cloning too much for telemetry workers #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix cloning too much for telemetry workers #1227

wants to merge 2 commits into from

Conversation

bwoebi
Copy link
Contributor

@bwoebi bwoebi commented Sep 18, 2025

Turns out telemetry workers were cloning their whole contents, so when the HashSets and HashMaps were updated, the changes weren't persisted.

@bwoebi
Fix cloning too much for telemetry workers
ddd9633 
Turns out telemetry workers were cloning their whole contents, so when the HashSets and HashMaps were updated, the changes weren't persisted.

Signed-off-by: Bob Weinand <[email protected]>
@bwoebi bwoebi requested review from a team as code owners September 18, 2025 12:38
@pr-commenter
Copy link

pr-commenter bot commented Sep 18, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-10-06 11:57:17

Comparing candidate commit 7ada2ef in PR branch bob/fix-worker-clone with baseline commit cbbd077 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7ada2ef 1759751070 bob/fix-worker-clone
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.182µs 3.244µs ± 1.448µs 3.016µs ± 0.028µs 3.043µs 3.662µs 14.473µs 14.875µs 393.23% 7.330 54.887 44.52% 0.102µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.043µs; 3.445µs] or [-6.185%; +6.185%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7ada2ef 1759751070 bob/fix-worker-clone
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.390µs 2.413µs ± 0.019µs 2.408µs ± 0.009µs 2.419µs 2.467µs 2.476µs 2.481µs 3.00% 1.784 2.961 0.80% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.411µs; 2.416µs] or [-0.111%; +0.111%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7ada2ef 1759751070 bob/fix-worker-clone
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 161.959µs 162.654µs ± 0.301µs 162.634µs ± 0.187µs 162.822µs 163.107µs 163.701µs 163.972µs 0.82% 0.874 2.639 0.18% 0.021µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [162.612µs; 162.696µs] or [-0.026%; +0.026%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7ada2ef 1759751070 bob/fix-worker-clone
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 89.230µs 89.445µs ± 0.225µs 89.425µs ± 0.051µs 89.478µs 89.587µs 89.675µs 92.377µs 3.30% 11.187 143.271 0.25% 0.016µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [89.414µs; 89.476µs] or [-0.035%; +0.035%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7ada2ef 1759751070 bob/fix-worker-clone
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 204.197µs 205.290µs ± 0.567µs 205.185µs ± 0.388µs 205.661µs 206.283µs 206.614µs 207.005µs 0.89% 0.539 -0.235 0.28% 0.040µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4830796.143op/s 4871198.409op/s ± 13428.297op/s 4873643.869op/s ± 9225.785op/s 4881139.796op/s 4889793.796op/s 4894462.945op/s 4897238.725op/s 0.48% -0.527 -0.253 0.27% 949.524op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.581µs 18.637µs ± 0.029µs 18.633µs ± 0.018µs 18.654µs 18.678µs 18.702µs 18.829µs 1.05% 1.606 8.536 0.15% 0.002µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 53109565.033op/s 53657528.586op/s ± 82769.054op/s 53667576.212op/s ± 52737.624op/s 53711468.298op/s 53767418.067op/s 53803077.121op/s 53818195.750op/s 0.28% -1.570 8.248 0.15% 5852.656op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.807µs 10.874µs ± 0.039µs 10.869µs ± 0.025µs 10.901µs 10.936µs 11.013µs 11.053µs 1.69% 1.078 2.582 0.36% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 90474182.148op/s 91964476.577op/s ± 331142.554op/s 92005305.181op/s ± 214509.096op/s 92189003.059op/s 92437943.388op/s 92512115.620op/s 92535581.711op/s 0.58% -1.041 2.429 0.36% 23415.315op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [205.211µs; 205.368µs] or [-0.038%; +0.038%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4869337.377op/s; 4873059.442op/s] or [-0.038%; +0.038%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.633µs; 18.641µs] or [-0.021%; +0.021%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [53646057.592op/s; 53668999.581op/s] or [-0.021%; +0.021%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.868µs; 10.879µs] or [-0.050%; +0.050%] None None None
normalization/normalize_name/normalize_name/good throughput [91918583.404op/s; 92010369.751op/s] or [-0.050%; +0.050%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7ada2ef 1759751070 bob/fix-worker-clone
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 59.716ms 60.479ms ± 2.146ms 60.225ms ± 0.123ms 60.354ms 60.525ms 70.041ms 81.916ms 36.02% 8.762 78.068 3.54% 0.152ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [60.182ms; 60.777ms] or [-0.492%; +0.492%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7ada2ef 1759751070 bob/fix-worker-clone
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.898µs 3.914µs ± 0.003µs 3.914µs ± 0.002µs 3.916µs 3.919µs 3.921µs 3.923µs 0.23% -0.488 4.615 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 254906730.076op/s 255474225.653op/s ± 190353.976op/s 255486433.702op/s ± 119318.402op/s 255595247.571op/s 255714398.632op/s 255807830.446op/s 256571287.755op/s 0.42% 0.502 4.688 0.07% 13460.059op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 76.655µs 78.245µs ± 0.779µs 78.142µs ± 0.517µs 78.746µs 79.700µs 80.148µs 81.019µs 3.68% 0.597 0.470 0.99% 0.055µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12342857.584op/s 12781550.267op/s ± 126585.270op/s 12797168.674op/s ± 84706.235op/s 12872746.141op/s 12971344.327op/s 13025376.149op/s 13045451.474op/s 1.94% -0.535 0.347 0.99% 8950.930op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 70.718µs 72.329µs ± 0.687µs 72.293µs ± 0.454µs 72.748µs 73.395µs 74.052µs 74.792µs 3.46% 0.399 0.361 0.95% 0.049µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13370399.801op/s 13826903.251op/s ± 130968.644op/s 13832583.481op/s ± 87474.257op/s 13919877.942op/s 14024340.091op/s 14122720.345op/s 14140705.924op/s 2.23% -0.337 0.267 0.94% 9260.882op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.893µs 3.915µs ± 0.003µs 3.915µs ± 0.002µs 3.916µs 3.919µs 3.920µs 3.922µs 0.18% -2.140 16.737 0.07% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 254980299.154op/s 255443180.330op/s ± 185737.011op/s 255447173.525op/s ± 103341.812op/s 255545391.254op/s 255686603.921op/s 255764621.752op/s 256890935.973op/s 0.57% 2.171 17.022 0.07% 13133.590op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 67.375µs 68.732µs ± 0.637µs 68.693µs ± 0.457µs 69.159µs 69.800µs 70.092µs 70.890µs 3.20% 0.279 -0.225 0.92% 0.045µs 1 200
credit_card/is_card_number/378282246310005 throughput 14106349.703op/s 14550592.376op/s ± 134494.211op/s 14557475.432op/s ± 96346.521op/s 14645535.527op/s 14763560.446op/s 14812025.270op/s 14842335.260op/s 1.96% -0.233 -0.285 0.92% 9510.177op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 53.053µs 53.127µs ± 0.039µs 53.121µs ± 0.026µs 53.148µs 53.204µs 53.230µs 53.237µs 0.22% 0.689 0.038 0.07% 0.003µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 18783777.257op/s 18822813.560op/s ± 13827.748op/s 18825094.949op/s ± 9048.025op/s 18833309.368op/s 18840561.050op/s 18846027.034op/s 18849114.929op/s 0.13% -0.686 0.032 0.07% 977.769op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.427µs 6.436µs ± 0.004µs 6.436µs ± 0.003µs 6.439µs 6.444µs 6.447µs 6.448µs 0.19% 0.276 -0.237 0.07% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 155075164.054op/s 155366948.699op/s ± 103404.855op/s 155367800.023op/s ± 71634.965op/s 155439054.065op/s 155532255.303op/s 155557398.576op/s 155584351.899op/s 0.14% -0.273 -0.240 0.07% 7311.827op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.898µs 3.914µs ± 0.003µs 3.914µs ± 0.002µs 3.916µs 3.919µs 3.921µs 3.924µs 0.27% -0.237 5.027 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254835109.715op/s 255489823.082op/s ± 183916.170op/s 255514091.602op/s ± 111167.802op/s 255612456.700op/s 255720590.983op/s 255788484.911op/s 256539214.705op/s 0.40% 0.253 5.090 0.07% 13004.837op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 64.926µs 65.122µs ± 0.125µs 65.085µs ± 0.048µs 65.150µs 65.384µs 65.512µs 65.845µs 1.17% 2.167 6.580 0.19% 0.009µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15187225.453op/s 15355764.335op/s ± 29404.306op/s 15364534.813op/s ± 11297.497op/s 15373534.848op/s 15383221.059op/s 15395031.211op/s 15402100.847op/s 0.24% -2.145 6.425 0.19% 2079.198op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 58.504µs 58.827µs ± 0.170µs 58.787µs ± 0.116µs 58.919µs 59.134µs 59.317µs 59.452µs 1.13% 0.849 0.609 0.29% 0.012µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 16820430.134op/s 16999187.652op/s ± 48910.998op/s 17010555.935op/s ± 33501.273op/s 17036490.460op/s 17059517.504op/s 17078142.556op/s 17092970.375op/s 0.48% -0.833 0.564 0.29% 3458.530op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.892µs 3.915µs ± 0.003µs 3.914µs ± 0.002µs 3.916µs 3.920µs 3.922µs 3.925µs 0.27% -0.987 10.024 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254791470.228op/s 255447410.176op/s ± 213763.857op/s 255477945.412op/s ± 107709.385op/s 255576927.793op/s 255675055.969op/s 255747290.616op/s 256916284.894op/s 0.56% 1.015 10.222 0.08% 15115.387op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 55.406µs 55.677µs ± 0.198µs 55.613µs ± 0.100µs 55.786µs 56.104µs 56.216µs 56.526µs 1.64% 1.338 1.750 0.36% 0.014µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17690913.210op/s 17960875.400op/s ± 63707.256op/s 17981262.642op/s ± 32306.659op/s 18007515.437op/s 18030988.779op/s 18045218.052op/s 18048557.840op/s 0.37% -1.318 1.664 0.35% 4504.783op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 53.058µs 53.128µs ± 0.037µs 53.125µs ± 0.028µs 53.155µs 53.196µs 53.212µs 53.229µs 0.20% 0.422 -0.568 0.07% 0.003µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 18786770.257op/s 18822509.612op/s ± 13046.139op/s 18823404.743op/s ± 10008.450op/s 18832995.029op/s 18840788.019op/s 18844445.238op/s 18847413.831op/s 0.13% -0.419 -0.571 0.07% 922.501op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.427µs 6.437µs ± 0.004µs 6.437µs ± 0.003µs 6.440µs 6.444µs 6.447µs 6.450µs 0.21% 0.307 -0.001 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 155039656.830op/s 155355651.039op/s ± 98439.272op/s 155357610.682op/s ± 68516.450op/s 155426239.835op/s 155509158.103op/s 155534121.594op/s 155582108.858op/s 0.14% -0.304 -0.007 0.06% 6960.708op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.914µs; 3.915µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ throughput [255447844.422op/s; 255500606.883op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [78.137µs; 78.353µs] or [-0.138%; +0.138%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12764006.766op/s; 12799093.768op/s] or [-0.137%; +0.137%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [72.234µs; 72.425µs] or [-0.132%; +0.132%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13808752.256op/s; 13845054.245op/s] or [-0.131%; +0.131%] None None None
credit_card/is_card_number/37828224631 execution_time [3.914µs; 3.915µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/37828224631 throughput [255417438.967op/s; 255468921.693op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/378282246310005 execution_time [68.643µs; 68.820µs] or [-0.128%; +0.128%] None None None
credit_card/is_card_number/378282246310005 throughput [14531952.772op/s; 14569231.980op/s] or [-0.128%; +0.128%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [53.122µs; 53.132µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [18820897.168op/s; 18824729.953op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.436µs; 6.437µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/x371413321323331 throughput [155352617.780op/s; 155381279.617op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.914µs; 3.914µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [255464334.070op/s; 255515312.094op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [65.105µs; 65.140µs] or [-0.027%; +0.027%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15351689.181op/s; 15359839.489op/s] or [-0.027%; +0.027%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [58.803µs; 58.850µs] or [-0.040%; +0.040%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [16992409.058op/s; 17005966.246op/s] or [-0.040%; +0.040%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.914µs; 3.915µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255417784.561op/s; 255477035.790op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [55.650µs; 55.705µs] or [-0.049%; +0.049%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [17952046.187op/s; 17969704.613op/s] or [-0.049%; +0.049%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [53.123µs; 53.133µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [18820701.543op/s; 18824317.682op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.436µs; 6.437µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [155342008.302op/s; 155369293.775op/s] or [-0.009%; +0.009%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7ada2ef 1759751070 bob/fix-worker-clone
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2597 execution_time 6.246ms 6.307ms ± 0.036ms 6.299ms ± 0.014ms 6.317ms 6.361ms 6.449ms 6.485ms 2.94% 2.230 7.017 0.57% 0.003ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2597 execution_time [6.302ms; 6.312ms] or [-0.080%; +0.080%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7ada2ef 1759751070 bob/fix-worker-clone
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 10.732ms 10.771ms ± 0.017ms 10.770ms ± 0.009ms 10.779ms 10.797ms 10.830ms 10.835ms 0.61% 0.656 1.707 0.16% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [10.768ms; 10.773ms] or [-0.022%; +0.022%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7ada2ef 1759751070 bob/fix-worker-clone
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 248.044ns 259.510ns ± 13.201ns 253.655ns ± 3.189ns 260.032ns 288.545ns 295.086ns 296.868ns 17.04% 1.452 0.704 5.07% 0.933ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [257.680ns; 261.339ns] or [-0.705%; +0.705%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7ada2ef 1759751070 bob/fix-worker-clone
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 535.909µs 538.676µs ± 2.082µs 538.201µs ± 1.467µs 540.121µs 542.680µs 544.085µs 546.021µs 1.45% 0.936 0.565 0.39% 0.147µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1831432.378op/s 1856430.020op/s ± 7148.283op/s 1858041.482op/s ± 5079.309op/s 1862234.214op/s 1864604.395op/s 1865355.605op/s 1865989.876op/s 0.43% -0.916 0.501 0.38% 505.460op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 383.138µs 384.191µs ± 0.392µs 384.184µs ± 0.246µs 384.440µs 384.828µs 384.902µs 385.059µs 0.23% -0.103 -0.404 0.10% 0.028µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2597006.454op/s 2602872.881op/s ± 2654.856op/s 2602922.361op/s ± 1665.173op/s 2604487.449op/s 2607660.370op/s 2608781.781op/s 2610024.392op/s 0.27% 0.108 -0.401 0.10% 187.727op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 190.096µs 190.664µs ± 0.433µs 190.607µs ± 0.133µs 190.776µs 191.066µs 191.261µs 195.947µs 2.80% 9.174 109.288 0.23% 0.031µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5103419.487op/s 5244865.485op/s ± 11667.693op/s 5246387.509op/s ± 3662.266op/s 5249301.086op/s 5254106.261op/s 5257443.985op/s 5260492.153op/s 0.27% -8.991 106.300 0.22% 825.030op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 36.784µs 36.909µs ± 0.073µs 36.896µs ± 0.046µs 36.950µs 37.054µs 37.111µs 37.164µs 0.73% 0.879 0.694 0.20% 0.005µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26908100.921op/s 27093904.369op/s ± 53594.190op/s 27103381.868op/s ± 33740.335op/s 27131595.823op/s 27167013.595op/s 27179990.226op/s 27185711.190op/s 0.30% -0.867 0.665 0.20% 3789.682op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 46.354µs 46.808µs ± 0.201µs 46.808µs ± 0.123µs 46.927µs 47.086µs 47.198µs 48.124µs 2.81% 1.375 8.173 0.43% 0.014µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20779681.351op/s 21364045.059op/s ± 91427.714op/s 21363864.383op/s ± 56128.112op/s 21421717.920op/s 21502328.013op/s 21536556.452op/s 21573194.012op/s 0.98% -1.271 7.443 0.43% 6464.916op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [538.388µs; 538.965µs] or [-0.054%; +0.054%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1855439.337op/s; 1857420.703op/s] or [-0.053%; +0.053%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [384.137µs; 384.246µs] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2602504.944op/s; 2603240.819op/s] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [190.604µs; 190.724µs] or [-0.031%; +0.031%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5243248.455op/s; 5246482.515op/s] or [-0.031%; +0.031%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [36.899µs; 36.919µs] or [-0.027%; +0.027%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [27086476.730op/s; 27101332.008op/s] or [-0.027%; +0.027%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [46.781µs; 46.836µs] or [-0.060%; +0.060%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21351374.057op/s; 21376716.061op/s] or [-0.059%; +0.059%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7ada2ef 1759751070 bob/fix-worker-clone
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.706µs 25.582µs ± 9.706µs 17.912µs ± 0.141µs 34.866µs 43.818µs 45.005µs 57.973µs 223.67% 0.754 -0.623 37.85% 0.686µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.237µs; 26.928µs] or [-5.258%; +5.258%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7ada2ef 1759751070 bob/fix-worker-clone
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 15.001ms 15.047ms ± 0.033ms 15.041ms ± 0.012ms 15.054ms 15.107ms 15.163ms 15.287ms 1.64% 3.275 16.320 0.22% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [15.043ms; 15.052ms] or [-0.031%; +0.031%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7ada2ef 1759751070 bob/fix-worker-clone
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 5.042µs 5.112µs ± 0.044µs 5.111µs ± 0.038µs 5.141µs 5.180µs 5.185µs 5.205µs 1.83% 0.175 -1.327 0.86% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.106µs; 5.118µs] or [-0.119%; +0.119%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7ada2ef 1759751070 bob/fix-worker-clone
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 34.152µs 34.704µs ± 0.890µs 34.299µs ± 0.085µs 34.469µs 36.563µs 36.624µs 38.292µs 11.64% 1.766 1.557 2.56% 0.063µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [34.581µs; 34.828µs] or [-0.355%; +0.355%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.84%. Comparing base (cbbd077) to head (7ada2ef).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1227      +/-   ##
==========================================
+ Coverage   71.82%   71.84%   +0.02%     
==========================================
  Files         356      356              
  Lines       56685    56690       +5     
==========================================
+ Hits        40716    40731      +15     
+ Misses      15969    15959      -10
Components Coverage Δ
datadog-crashtracker 49.33% <ø> (+0.02%) ⬆️
datadog-crashtracker-ffi 5.93% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 88.01% <ø> (ø)
data-pipeline-ffi 88.19% <ø> (ø)
ddcommon 84.54% <ø> (ø)
ddcommon-ffi 73.84% <ø> (ø)
ddtelemetry 59.45% <ø> (ø)
ddtelemetry-ffi 21.24% <ø> (ø)
dogstatsd-client 83.26% <ø> (ø)
datadog-ipc 82.39% <ø> (ø)
datadog-profiling 76.90% <ø> (ø)
datadog-profiling-ffi 62.12% <ø> (ø)
datadog-sidecar 36.98% <0.00%> (-0.04%) ⬇️
datdog-sidecar-ffi 11.03% <ø> (ø)
spawn-worker 55.35% <ø> (ø)
tinybytes 92.22% <ø> (ø)
datadog-trace-normalization 98.24% <ø> (ø)
datadog-trace-obfuscation 94.17% <ø> (ø)
datadog-trace-protobuf 59.65% <ø> (ø)
datadog-trace-utils 89.84% <ø> (ø)
datadog-tracer-flare 54.52% <ø> (ø)
datadog-log 76.31% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Oct 6, 2025 •
edited
Loading

⚠️ Tests

⚠️ Warnings

🧪 1 Test failed

test_ddog_sidecar_register_app from datadog-sidecar-ffi::sidecar (Datadog) (✨ Fix with BitsAI) 
thread 'test_ddog_sidecar_register_app' panicked at D:\a\libdatadog\libdatadog\ddcommon-ffi\src\option.rs:34:32

thread 'test_ddog_sidecar_register_app' panicked at D:\a\libdatadog\libdatadog\ddcommon-ffi\src\option.rs:34:32:
Called ffi::Option::unwrap_none but option was Some(_)
stack backtrace:
   0:     0x7ff723a85e22 - std::backtrace_rs::backtrace::win64::trace
                               at /rustc/1159e78c4747b02ef996e55082b704c09b970588/library\std\src\..\..\backtrace\src\backtrace\win64.rs:85
   1:     0x7ff723a85e22 - std::backtrace_rs::backtrace::trace_unsynchronized
                               at /rustc/1159e78c4747b02ef996e55082b704c09b970588/library\std\src\..\..\backtrace\src\backtrace\mod.rs:66
   2:     0x7ff723a85e22 - std::sys::backtrace::_print_fmt
...

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7ada2ef | Docs | Was this helpful? Give us feedback!

@dd-octo-sts
Copy link

dd-octo-sts bot commented Oct 6, 2025

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 71.31 MB 71.31 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.25 MB 7.25 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.20 MB 9.20 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 83.64 MB 83.64 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 18.50 MB 18.50 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 65.77 KB 65.77 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 125.66 MB 125.66 MB +0% (+8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 656.43 MB 656.43 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 5.92 MB 5.92 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 65.77 KB 65.77 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 17.44 MB 17.44 MB --.04% (-8.00 KB) 💪
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 32.40 MB 32.40 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 15.78 MB 15.78 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 66.79 KB 66.79 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 127.99 MB 128.02 MB +.02% (+32.00 KB) 🔍
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 645.48 MB 645.48 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 4.53 MB 4.53 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 66.79 KB 66.79 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 18.57 MB 18.57 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 30.42 MB 30.42 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 63.91 MB 63.91 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.55 MB 8.55 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 78.37 MB 78.37 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.90 MB 9.90 MB 0% (0 B) 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leiyks Leiyks Leiyks approved these changes

Assignees
No one assigned
Labels
sidecar
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bwoebi @codecov-commenter @Leiyks