Skip to content

Conversation

hoolioh
Copy link
Contributor

@hoolioh hoolioh commented Sep 30, 2025

What does this PR do?

This PR modifies send_data module and send_with_retry function so they can accept an HttpClient. This leads to some benefits:

  • Since the http client (based on hyper) maintain a pool of connections they can be reused allowing to avoid unnecessary TCP handshakes with the agent.
  • Avoid constantly recreating the client in the send functions.
  • Allow to the caller to handle the connection pool and the proxy configuration.

@pr-commenter
Copy link

pr-commenter bot commented Sep 30, 2025

Benchmarks

Comparison

Benchmark execution time: 2025-10-06 08:48:37

Comparing candidate commit 386bc6b in PR branch julio/reuse-connections with baseline commit cbbd077 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 386bc6b 1759739725 julio/reuse-connections
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.361µs 2.393µs ± 0.016µs 2.393µs ± 0.010µs 2.402µs 2.421µs 2.438µs 2.442µs 2.06% 0.607 0.452 0.65% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.391µs; 2.395µs] or [-0.090%; +0.090%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 386bc6b 1759739725 julio/reuse-connections
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 63.027ms 63.492ms ± 1.466ms 63.278ms ± 0.085ms 63.364ms 63.605ms 72.163ms 77.219ms 22.03% 7.929 64.311 2.30% 0.104ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [63.289ms; 63.695ms] or [-0.320%; +0.320%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 386bc6b 1759739725 julio/reuse-connections
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 535.515µs 538.182µs ± 2.225µs 537.831µs ± 1.412µs 539.041µs 542.320µs 545.663µs 547.030µs 1.71% 1.328 1.758 0.41% 0.157µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1828054.092op/s 1858139.800op/s ± 7641.899op/s 1859320.019op/s ± 4893.927op/s 1864400.967op/s 1866120.774op/s 1867254.273op/s 1867360.299op/s 0.43% -1.303 1.661 0.41% 540.364op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 382.248µs 383.607µs ± 0.757µs 383.722µs ± 0.489µs 384.114µs 384.554µs 384.929µs 388.771µs 1.32% 1.432 9.235 0.20% 0.054µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2572210.044op/s 2606847.478op/s ± 5128.690op/s 2606055.261op/s ± 3321.800op/s 2611198.826op/s 2614254.814op/s 2615683.645op/s 2616104.718op/s 0.39% -1.379 8.806 0.20% 362.653op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 190.145µs 190.837µs ± 0.403µs 190.730µs ± 0.330µs 191.217µs 191.487µs 191.638µs 191.757µs 0.54% 0.294 -1.184 0.21% 0.028µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5214920.932op/s 5240109.232op/s ± 11057.591op/s 5243021.795op/s ± 9078.339op/s 5249295.259op/s 5254844.638op/s 5257363.472op/s 5259137.245op/s 0.31% -0.289 -1.187 0.21% 781.890op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 36.586µs 36.820µs ± 0.161µs 36.783µs ± 0.080µs 36.916µs 37.011µs 37.065µs 38.409µs 4.42% 4.916 45.260 0.44% 0.011µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26035741.064op/s 27159486.459op/s ± 116405.159op/s 27186692.883op/s ± 59137.957op/s 27236332.585op/s 27274736.649op/s 27297125.484op/s 27332532.442op/s 0.54% -4.624 41.417 0.43% 8231.088op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 46.062µs 46.763µs ± 0.142µs 46.781µs ± 0.092µs 46.859µs 46.959µs 47.097µs 47.306µs 1.12% -0.418 2.865 0.30% 0.010µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21138957.643op/s 21384702.010op/s ± 65002.763op/s 21376237.818op/s ± 42267.714op/s 21425446.885op/s 21478556.634op/s 21534962.759op/s 21709811.701op/s 1.56% 0.461 2.969 0.30% 4596.389op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [537.873µs; 538.490µs] or [-0.057%; +0.057%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1857080.707op/s; 1859198.894op/s] or [-0.057%; +0.057%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [383.502µs; 383.711µs] or [-0.027%; +0.027%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2606136.690op/s; 2607558.265op/s] or [-0.027%; +0.027%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [190.781µs; 190.892µs] or [-0.029%; +0.029%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5238576.756op/s; 5241641.708op/s] or [-0.029%; +0.029%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [36.798µs; 36.843µs] or [-0.061%; +0.061%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [27143353.823op/s; 27175619.094op/s] or [-0.059%; +0.059%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [46.743µs; 46.783µs] or [-0.042%; +0.042%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21375693.253op/s; 21393710.768op/s] or [-0.042%; +0.042%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 386bc6b 1759739725 julio/reuse-connections
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 244.684ns 257.017ns ± 14.773ns 250.525ns ± 4.579ns 266.523ns 286.806ns 300.368ns 300.677ns 20.02% 1.401 0.950 5.73% 1.045ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [254.969ns; 259.064ns] or [-0.797%; +0.797%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 386bc6b 1759739725 julio/reuse-connections
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 15.007ms 15.061ms ± 0.032ms 15.057ms ± 0.012ms 15.070ms 15.097ms 15.172ms 15.319ms 1.74% 4.134 26.262 0.21% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [15.057ms; 15.066ms] or [-0.030%; +0.030%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 386bc6b 1759739725 julio/reuse-connections
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 10.757ms 10.787ms ± 0.017ms 10.785ms ± 0.011ms 10.797ms 10.814ms 10.834ms 10.872ms 0.81% 1.107 2.932 0.15% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [10.785ms; 10.789ms] or [-0.021%; +0.021%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 386bc6b 1759739725 julio/reuse-connections
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.179µs 3.225µs ± 1.411µs 3.013µs ± 0.025µs 3.036µs 3.693µs 13.896µs 14.874µs 393.65% 7.288 54.571 43.65% 0.100µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.029µs; 3.420µs] or [-6.065%; +6.065%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 386bc6b 1759739725 julio/reuse-connections
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 5.012µs 5.078µs ± 0.046µs 5.060µs ± 0.023µs 5.122µs 5.160µs 5.161µs 5.168µs 2.13% 0.605 -1.170 0.90% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.072µs; 5.084µs] or [-0.125%; +0.125%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 386bc6b 1759739725 julio/reuse-connections
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 34.549µs 35.100µs ± 0.860µs 34.719µs ± 0.060µs 34.812µs 36.872µs 36.933µs 39.069µs 12.53% 1.880 2.356 2.44% 0.061µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [34.981µs; 35.219µs] or [-0.340%; +0.340%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 386bc6b 1759739725 julio/reuse-connections
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.901µs 3.915µs ± 0.003µs 3.915µs ± 0.002µs 3.916µs 3.918µs 3.921µs 3.925µs 0.26% -0.187 4.165 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 254801970.003op/s 255457639.292op/s ± 170388.551op/s 255455512.423op/s ± 108549.025op/s 255568447.623op/s 255694007.863op/s 255748949.625op/s 256370891.920op/s 0.36% 0.199 4.202 0.07% 12048.290op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 76.355µs 78.387µs ± 0.768µs 78.381µs ± 0.566µs 78.935µs 79.631µs 79.881µs 79.969µs 2.03% -0.043 -0.618 0.98% 0.054µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12504804.092op/s 12758477.072op/s ± 125005.448op/s 12758234.126op/s ± 91487.632op/s 12851847.904op/s 12950158.744op/s 13017741.932op/s 13096792.974op/s 2.65% 0.084 -0.601 0.98% 8839.220op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 70.727µs 72.220µs ± 0.774µs 72.109µs ± 0.465µs 72.637µs 73.736µs 74.147µs 74.380µs 3.15% 0.601 -0.133 1.07% 0.055µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13444450.914op/s 13848075.789op/s ± 147481.440op/s 13867946.349op/s ± 89409.977op/s 13951688.923op/s 14053697.426op/s 14127617.556op/s 14138896.450op/s 1.95% -0.553 -0.191 1.06% 10428.513op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.894µs 3.915µs ± 0.003µs 3.914µs ± 0.002µs 3.916µs 3.920µs 3.921µs 3.923µs 0.23% -1.844 12.463 0.08% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 254908917.203op/s 255454335.555op/s ± 215366.479op/s 255484696.488op/s ± 106479.406op/s 255568479.574op/s 255687925.519op/s 255754562.170op/s 256801753.770op/s 0.52% 1.872 12.648 0.08% 15228.710op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 67.240µs 68.822µs ± 0.755µs 68.791µs ± 0.499µs 69.280µs 70.126µs 70.660µs 70.700µs 2.78% 0.233 -0.301 1.09% 0.053µs 1 200
credit_card/is_card_number/378282246310005 throughput 14144246.905op/s 14532027.266op/s ± 159007.836op/s 14536753.552op/s ± 105457.473op/s 14643666.684op/s 14795662.658op/s 14844356.985op/s 14872124.179op/s 2.31% -0.179 -0.334 1.09% 11243.552op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 52.782µs 52.949µs ± 0.069µs 52.944µs ± 0.047µs 53.002µs 53.050µs 53.101µs 53.217µs 0.52% 0.188 0.237 0.13% 0.005µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 18790967.291op/s 18885987.305op/s ± 24677.363op/s 18887820.189op/s ± 16857.755op/s 18902674.256op/s 18926585.323op/s 18939003.970op/s 18945921.124op/s 0.31% -0.179 0.222 0.13% 1744.953op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.427µs 6.436µs ± 0.004µs 6.435µs ± 0.002µs 6.438µs 6.444µs 6.446µs 6.447µs 0.18% 0.410 -0.213 0.07% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 155103504.141op/s 155378808.571op/s ± 103587.653op/s 155389596.676op/s ± 59549.560op/s 155445296.763op/s 155539591.339op/s 155569436.747op/s 155586563.849op/s 0.13% -0.407 -0.216 0.07% 7324.753op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.901µs 3.914µs ± 0.003µs 3.914µs ± 0.002µs 3.916µs 3.918µs 3.920µs 3.920µs 0.16% -0.581 2.852 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255083983.531op/s 255484355.348op/s ± 166160.023op/s 255480225.834op/s ± 115991.947op/s 255603500.249op/s 255724501.819op/s 255767777.624op/s 256375007.902op/s 0.35% 0.590 2.896 0.06% 11749.288op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 64.897µs 65.108µs ± 0.141µs 65.057µs ± 0.050µs 65.143µs 65.397µs 65.596µs 65.648µs 0.91% 1.594 2.244 0.22% 0.010µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15232774.600op/s 15359102.768op/s ± 33177.848op/s 15371090.821op/s ± 11880.154op/s 15379615.092op/s 15391684.651op/s 15398499.938op/s 15409142.244op/s 0.25% -1.583 2.199 0.22% 2346.028op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 58.323µs 58.811µs ± 0.208µs 58.774µs ± 0.124µs 58.917µs 59.195µs 59.367µs 59.791µs 1.73% 0.940 1.948 0.35% 0.015µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 16725010.218op/s 17003909.679op/s ± 59883.509op/s 17014351.461op/s ± 35850.463op/s 17044163.746op/s 17085291.018op/s 17125832.675op/s 17145880.662op/s 0.77% -0.908 1.827 0.35% 4234.404op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.897µs 3.916µs ± 0.003µs 3.916µs ± 0.002µs 3.918µs 3.920µs 3.921µs 3.922µs 0.15% -1.397 6.916 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254959333.238op/s 255372351.904op/s ± 188635.871op/s 255351538.617op/s ± 113437.307op/s 255479631.890op/s 255677683.206op/s 255761151.841op/s 256576080.080op/s 0.48% 1.412 7.029 0.07% 13338.570op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 55.314µs 55.650µs ± 0.199µs 55.574µs ± 0.084µs 55.765µs 56.032µs 56.248µs 56.504µs 1.67% 1.466 2.281 0.36% 0.014µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17697804.676op/s 17969578.111op/s ± 63925.469op/s 17993963.925op/s ± 27025.786op/s 18013452.897op/s 18033690.360op/s 18041229.942op/s 18078738.329op/s 0.47% -1.444 2.175 0.35% 4520.213op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 52.668µs 52.913µs ± 0.059µs 52.921µs ± 0.038µs 52.954µs 53.009µs 53.038µs 53.067µs 0.28% -0.498 1.095 0.11% 0.004µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 18843937.402op/s 18898982.084op/s ± 21159.319op/s 18896223.593op/s ± 13439.028op/s 18912997.958op/s 18933144.190op/s 18950165.798op/s 18987025.131op/s 0.48% 0.507 1.116 0.11% 1496.190op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.428µs 6.436µs ± 0.005µs 6.436µs ± 0.003µs 6.439µs 6.446µs 6.448µs 6.450µs 0.22% 0.773 0.232 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 155033686.406op/s 155364156.011op/s ± 108761.793op/s 155379886.080op/s ± 70315.884op/s 155446035.351op/s 155514004.985op/s 155542692.694op/s 155569259.354op/s 0.12% -0.770 0.226 0.07% 7690.620op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.914µs; 3.915µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ throughput [255434025.077op/s; 255481253.506op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [78.280µs; 78.493µs] or [-0.136%; +0.136%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12741152.519op/s; 12775801.625op/s] or [-0.136%; +0.136%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [72.113µs; 72.328µs] or [-0.149%; +0.149%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13827636.280op/s; 13868515.299op/s] or [-0.148%; +0.148%] None None None
credit_card/is_card_number/37828224631 execution_time [3.914µs; 3.915µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/37828224631 throughput [255424487.832op/s; 255484183.277op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/378282246310005 execution_time [68.717µs; 68.926µs] or [-0.152%; +0.152%] None None None
credit_card/is_card_number/378282246310005 throughput [14509990.310op/s; 14554064.223op/s] or [-0.152%; +0.152%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.940µs; 52.959µs] or [-0.018%; +0.018%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [18882567.260op/s; 18889407.350op/s] or [-0.018%; +0.018%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.435µs; 6.436µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/x371413321323331 throughput [155364452.318op/s; 155393164.823op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.914µs; 3.914µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ throughput [255461327.167op/s; 255507383.529op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [65.089µs; 65.128µs] or [-0.030%; +0.030%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15354504.637op/s; 15363700.898op/s] or [-0.030%; +0.030%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [58.782µs; 58.840µs] or [-0.049%; +0.049%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [16995610.400op/s; 17012208.957op/s] or [-0.049%; +0.049%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.915µs; 3.916µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255346208.786op/s; 255398495.021op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [55.623µs; 55.678µs] or [-0.050%; +0.050%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [17960718.656op/s; 17978437.566op/s] or [-0.049%; +0.049%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.905µs; 52.921µs] or [-0.016%; +0.016%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [18896049.606op/s; 18901914.562op/s] or [-0.016%; +0.016%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.436µs; 6.437µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [155349082.673op/s; 155379229.350op/s] or [-0.010%; +0.010%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 386bc6b 1759739725 julio/reuse-connections
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.853µs 26.413µs ± 10.210µs 18.192µs ± 0.259µs 35.652µs 42.887µs 50.184µs 71.732µs 294.29% 0.891 0.522 38.56% 0.722µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.998µs; 27.828µs] or [-5.357%; +5.357%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 386bc6b 1759739725 julio/reuse-connections
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 204.461µs 205.227µs ± 0.511µs 205.182µs ± 0.277µs 205.417µs 205.919µs 207.459µs 208.307µs 1.52% 2.646 12.369 0.25% 0.036µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4800606.174op/s 4872672.767op/s ± 12042.679op/s 4873728.287op/s ± 6580.495op/s 4880582.533op/s 4885878.687op/s 4888893.041op/s 4890904.412op/s 0.35% -2.592 11.965 0.25% 851.546op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.628µs 18.732µs ± 0.059µs 18.719µs ± 0.037µs 18.772µs 18.841µs 18.873µs 18.885µs 0.89% 0.576 -0.400 0.31% 0.004µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 52951745.702op/s 53384515.375op/s ± 166490.162op/s 53420931.589op/s ± 105561.420op/s 53504566.216op/s 53624250.649op/s 53649831.567op/s 53681333.954op/s 0.49% -0.564 -0.416 0.31% 11772.632op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.855µs 10.922µs ± 0.029µs 10.920µs ± 0.015µs 10.936µs 10.969µs 10.994µs 11.099µs 1.65% 1.363 6.365 0.27% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 90094613.099op/s 91557752.034op/s ± 245747.615op/s 91576756.073op/s ± 129895.733op/s 91699770.757op/s 91945297.183op/s 92026160.877op/s 92120011.983op/s 0.59% -1.311 6.053 0.27% 17376.981op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [205.157µs; 205.298µs] or [-0.034%; +0.034%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4871003.767op/s; 4874341.766op/s] or [-0.034%; +0.034%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.724µs; 18.740µs] or [-0.043%; +0.043%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [53361441.439op/s; 53407589.310op/s] or [-0.043%; +0.043%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.918µs; 10.926µs] or [-0.037%; +0.037%] None None None
normalization/normalize_name/normalize_name/good throughput [91523693.778op/s; 91591810.290op/s] or [-0.037%; +0.037%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 386bc6b 1759739725 julio/reuse-connections
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 160.026µs 160.697µs ± 0.278µs 160.672µs ± 0.150µs 160.828µs 161.193µs 161.560µs 161.805µs 0.70% 0.640 1.487 0.17% 0.020µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [160.658µs; 160.735µs] or [-0.024%; +0.024%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 386bc6b 1759739725 julio/reuse-connections
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 88.716µs 88.984µs ± 0.160µs 88.959µs ± 0.052µs 89.029µs 89.128µs 89.218µs 90.871µs 2.15% 8.403 95.980 0.18% 0.011µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [88.962µs; 89.007µs] or [-0.025%; +0.025%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 386bc6b 1759739725 julio/reuse-connections
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2597 execution_time 6.212ms 6.260ms ± 0.026ms 6.255ms ± 0.013ms 6.271ms 6.308ms 6.326ms 6.422ms 2.67% 1.830 6.659 0.42% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2597 execution_time [6.257ms; 6.264ms] or [-0.058%; +0.058%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 91.04478% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.85%. Comparing base (cbbd077) to head (386bc6b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1249      +/-   ##
==========================================
+ Coverage   71.82%   71.85%   +0.03%     
==========================================
  Files         356      356              
  Lines       56685    56698      +13     
==========================================
+ Hits        40716    40743      +27     
+ Misses      15969    15955      -14     
Components Coverage Δ
datadog-crashtracker 49.28% <ø> (-0.03%) ⬇️
datadog-crashtracker-ffi 5.93% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 87.88% <100.00%> (-0.14%) ⬇️
data-pipeline-ffi 88.19% <ø> (ø)
ddcommon 84.54% <ø> (ø)
ddcommon-ffi 73.84% <ø> (ø)
ddtelemetry 59.49% <ø> (+0.03%) ⬆️
ddtelemetry-ffi 21.24% <ø> (ø)
dogstatsd-client 83.26% <ø> (ø)
datadog-ipc 82.49% <ø> (+0.10%) ⬆️
datadog-profiling 76.90% <ø> (ø)
datadog-profiling-ffi 62.12% <ø> (ø)
datadog-sidecar 36.92% <100.00%> (-0.10%) ⬇️
datdog-sidecar-ffi 10.53% <ø> (-0.51%) ⬇️
spawn-worker 55.35% <ø> (ø)
tinybytes 92.22% <ø> (ø)
datadog-trace-normalization 98.24% <ø> (ø)
datadog-trace-obfuscation 94.17% <ø> (ø)
datadog-trace-protobuf 59.65% <ø> (ø)
datadog-trace-utils 90.00% <87.50%> (+0.15%) ⬆️
datadog-tracer-flare 56.08% <ø> (+1.55%) ⬆️
datadog-log 76.31% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hoolioh hoolioh force-pushed the julio/reuse-connections branch 2 times, most recently from 555352d to 1805508 Compare September 30, 2025 11:55
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Sep 30, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 386bc6b | Docs | Was this helpful? Give us feedback!

@dd-octo-sts
Copy link

dd-octo-sts bot commented Sep 30, 2025

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.25 MB 7.25 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 71.31 MB 71.31 MB +0% (+2.04 KB) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 83.64 MB 83.64 MB +0% (+4.27 KB) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.20 MB 9.20 MB +0% (+176 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 18.50 MB 18.50 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 65.77 KB 65.77 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 125.66 MB 125.64 MB --.01% (-16.00 KB) 💪
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 656.43 MB 658.76 MB +.35% (+2.33 MB) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 5.92 MB 5.92 MB -0% (-512 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 65.77 KB 65.77 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 17.44 MB 17.44 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 32.40 MB 32.40 MB +0% (+1.51 KB) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 15.78 MB 15.78 MB +0% (+512 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 66.79 KB 66.79 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 127.99 MB 128.01 MB +.01% (+24.00 KB) 🔍
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 645.48 MB 647.81 MB +.36% (+2.33 MB) 🔍
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 4.53 MB 4.53 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 66.79 KB 66.79 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 18.57 MB 18.57 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 30.42 MB 30.42 MB +0% (+1.69 KB) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 63.91 MB 63.91 MB +0% (+1.21 KB) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.55 MB 8.55 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 78.37 MB 78.37 MB +0% (+128 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.90 MB 9.90 MB +0% (+152 B) 👌

@hoolioh hoolioh force-pushed the julio/reuse-connections branch from 58e37dd to 386bc6b Compare October 6, 2025 08:35
@hoolioh hoolioh marked this pull request as ready for review October 6, 2025 08:36
@hoolioh hoolioh requested review from a team as code owners October 6, 2025 08:36
Copy link
Contributor

@bantonsson bantonsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Has this been cleared with Serverless?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants