Skip to content

[crashtracking] upload to both telemetry intake and errors intake #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[crashtracking] upload to both telemetry intake and errors intake #1259

wants to merge 7 commits into from
+958 −8

Conversation

gyuheon0h
Copy link
Contributor

@gyuheon0h gyuheon0h commented Oct 3, 2025 •
edited
Loading

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Errors Intake endpoints and conditions; this was largely follows how Telemetry handles CrashInfo uploads

  1. Agent Proxy Mode
  • Endpoint: http://localhost:8126/evp_proxy/v4/api/v2/errorsintake
  • Path: /evp_proxy/v4/api/v2/errorsintake
  • When used: Default behavior - when either condition is true:
    • No DD_API_KEY is set
    • _DD_DIRECT_SUBMISSION_ENABLED is false/unset
  • Headers: X-Datadog-EVP-Subdomain: event-platform-intake
  • Authentication: No API key needed (agent handles it)
  1. Direct Errors Intake Submission
  • Endpoint: https://event-platform-intake.{site}/api/v2/errorsintake
  • Path: /api/v2/errorsintake
  • When used: When both conditions are met:
    • _DD_DIRECT_SUBMISSION_ENABLED=true
    • DD_API_KEY is set
  • Headers: DD-API-KEY: {api_key} (added automatically)
  • Default site: event-platform-intake.datad0g.com
  1. Custom Agent Host/Port
  • Endpoint: http://{host}:{port}/evp_proxy/v4/api/v2/errorsintake
  • When used: Agent proxy mode with custom location
  • Config: DD_AGENT_HOST and/or DD_TRACE_AGENT_PORT
  • Defaults: host=localhost, port=8126
  1. Unix Domain Socket (UDS)
  • Endpoint: unix:///var/run/datadog/apm.socket/evp_proxy/v4/api/v2/errorsintake
  • When used: Unix systems when socket file exists at /var/run/datadog/apm.socket
  • Priority: Used as fallback when explicit host/port not configured
  • Path: Still uses agent proxy path
  1. Windows Named Pipes
  • Endpoint: windows:{pipe_name}/evp_proxy/v4/api/v2/errorsintake
  • When used: Windows systems with DD_TRACE_PIPE_NAME set
  • Config: DD_TRACE_PIPE_NAME environment variable
  • Path: Uses agent proxy path
  1. Direct Agent URL Override
  • Endpoint: {DD_TRACE_AGENT_URL}/evp_proxy/v4/api/v2/errorsintake
  • When used: When DD_TRACE_AGENT_URL is explicitly set
  • Supports: http://, https://, unix:// schemes
  • Path: Agent proxy path appended to custom URL
  1. File Endpoint (Testing)
  • Endpoint: file://{path}.errors
  • When used: Testing/debugging with file:// URLs
  • Behavior: Writes JSON payload to file instead of HTTP request
  • File extension: Automatically appends .errors to the base path

How to test the change?

Unit tests
Run a tracer that points to the latest commit on this PR for libdatadog locally and crash a program

@pr-commenter
Copy link

pr-commenter bot commented Oct 3, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-10-09 02:25:52

Comparing candidate commit 9ee8161 in PR branch gyuheon0h/prof-12603-dual-uploads with baseline commit f65f27b in branch main.

Found 11 performance improvements and 0 performance regressions! Performance is the same for 42 metrics, 2 unstable metrics.

scenario:benching serializing traces from their internal representation to msgpack

  • 🟩 execution_time [-646.475µs; -633.366µs] or [-4.282%; -4.195%]

scenario:credit_card/is_card_number/x371413321323331

  • 🟩 execution_time [-401.724ns; -397.932ns] or [-6.243%; -6.184%]
  • 🟩 throughput [+10244818.265op/s; +10347118.544op/s] or [+6.593%; +6.658%]

scenario:credit_card/is_card_number_no_luhn/x371413321323331

  • 🟩 execution_time [-401.944ns; -399.348ns] or [-6.246%; -6.205%]
  • 🟩 throughput [+10281178.244op/s; +10350197.070op/s] or [+6.617%; +6.661%]

scenario:normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...

  • 🟩 execution_time [-18.027µs; -17.891µs] or [-8.799%; -8.733%]
  • 🟩 throughput [+467290.010op/s; +470681.765op/s] or [+9.573%; +9.643%]

scenario:normalization/normalize_name/normalize_name/bad-name

  • 🟩 execution_time [-775.087ns; -757.837ns] or [-4.159%; -4.067%]
  • 🟩 throughput [+2275978.860op/s; +2327041.630op/s] or [+4.241%; +4.337%]

scenario:normalization/normalize_name/normalize_name/good

  • 🟩 execution_time [-937.560ns; -915.527ns] or [-8.624%; -8.421%]
  • 🟩 throughput [+8465435.476op/s; +8680186.700op/s] or [+9.204%; +9.437%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9ee8161 1759954062 gyuheon0h/prof-12603-dual-uploads
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 186.600µs 186.912µs ± 0.241µs 186.881µs ± 0.108µs 186.979µs 187.228µs 188.029µs 188.128µs 0.67% 2.707 9.988 0.13% 0.017µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 5315529.146op/s 5350132.808op/s ± 6874.840op/s 5351000.554op/s ± 3096.695op/s 5354497.879op/s 5356885.703op/s 5358593.034op/s 5359063.986op/s 0.15% -2.689 9.882 0.13% 486.125op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 17.698µs 17.869µs ± 0.036µs 17.868µs ± 0.020µs 17.887µs 17.929µs 17.961µs 17.991µs 0.68% -0.106 2.512 0.20% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 55584660.301op/s 55962708.604op/s ± 112790.749op/s 55964511.039op/s ± 64031.774op/s 56030890.765op/s 56132905.888op/s 56204194.377op/s 56505049.668op/s 0.97% 0.134 2.577 0.20% 7975.510op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 9.853µs 9.946µs ± 0.071µs 9.918µs ± 0.042µs 10.011µs 10.062µs 10.092µs 10.186µs 2.70% 0.623 -0.706 0.71% 0.005µs 1 200
normalization/normalize_name/normalize_name/good throughput 98173154.963op/s 100552110.260op/s ± 711138.032op/s 100825964.765op/s ± 430115.423op/s 101105581.819op/s 101439613.968op/s 101484340.971op/s 101496885.363op/s 0.67% -0.604 -0.752 0.71% 50285.053op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [186.878µs; 186.945µs] or [-0.018%; +0.018%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [5349180.021op/s; 5351085.595op/s] or [-0.018%; +0.018%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [17.864µs; 17.874µs] or [-0.028%; +0.028%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [55947076.891op/s; 55978340.317op/s] or [-0.028%; +0.028%] None None None
normalization/normalize_name/normalize_name/good execution_time [9.936µs; 9.955µs] or [-0.098%; +0.098%] None None None
normalization/normalize_name/normalize_name/good throughput [100453553.368op/s; 100650667.152op/s] or [-0.098%; +0.098%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9ee8161 1759954062 gyuheon0h/prof-12603-dual-uploads
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 237.669ns 252.597ns ± 15.095ns 245.583ns ± 5.700ns 262.411ns 281.125ns 294.524ns 295.738ns 20.42% 1.169 0.340 5.96% 1.067ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [250.505ns; 254.689ns] or [-0.828%; +0.828%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9ee8161 1759954062 gyuheon0h/prof-12603-dual-uploads
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.892µs 3.912µs ± 0.003µs 3.912µs ± 0.002µs 3.914µs 3.916µs 3.918µs 3.927µs 0.39% -0.719 11.976 0.08% 0.000µs 1 200
credit_card/is_card_number/ throughput 254642216.234op/s 255636680.560op/s ± 195527.082op/s 255638288.917op/s ± 118869.578op/s 255759451.304op/s 255872456.762op/s 255919311.602op/s 256963102.129op/s 0.52% 0.750 12.105 0.08% 13825.853op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 76.811µs 78.544µs ± 0.845µs 78.548µs ± 0.569µs 79.025µs 79.903µs 80.515µs 81.807µs 4.15% 0.550 0.814 1.07% 0.060µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12223836.787op/s 12733222.112op/s ± 136219.039op/s 12731016.359op/s ± 92855.399op/s 12836347.145op/s 12940958.358op/s 12991028.366op/s 13018997.769op/s 2.26% -0.471 0.607 1.07% 9632.141op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 69.828µs 70.988µs ± 0.566µs 70.930µs ± 0.346µs 71.317µs 71.962µs 72.386µs 73.009µs 2.93% 0.524 0.608 0.80% 0.040µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13696897.565op/s 14087849.822op/s ± 111880.324op/s 14098466.088op/s ± 69088.355op/s 14164796.528op/s 14271039.633op/s 14314108.097op/s 14320862.063op/s 1.58% -0.469 0.501 0.79% 7911.134op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.892µs 3.912µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.917µs 3.919µs 3.920µs 0.21% -0.763 7.886 0.08% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255121494.126op/s 255650568.769op/s ± 195389.456op/s 255665833.953op/s ± 115653.460op/s 255775897.084op/s 255898381.357op/s 255964836.290op/s 256910758.691op/s 0.49% 0.785 8.017 0.08% 13816.121op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 66.773µs 68.203µs ± 0.668µs 68.201µs ± 0.443µs 68.593µs 69.347µs 69.747µs 70.413µs 3.24% 0.355 -0.075 0.98% 0.047µs 1 200
credit_card/is_card_number/378282246310005 throughput 14201883.419op/s 14663498.873op/s ± 143235.831op/s 14662647.892op/s ± 95201.177op/s 14763066.800op/s 14884260.243op/s 14928239.835op/s 14976213.119op/s 2.14% -0.302 -0.144 0.97% 10128.303op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 52.132µs 52.193µs ± 0.032µs 52.186µs ± 0.020µs 52.211µs 52.253µs 52.291µs 52.323µs 0.26% 1.032 1.312 0.06% 0.002µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19111941.728op/s 19159588.428op/s ± 11631.859op/s 19162390.933op/s ± 7398.524op/s 19168105.710op/s 19174107.094op/s 19177036.497op/s 19182223.833op/s 0.10% -1.028 1.298 0.06% 822.497op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.026µs 6.035µs ± 0.013µs 6.032µs ± 0.002µs 6.035µs 6.067µs 6.107µs 6.111µs 1.31% 4.139 18.292 0.22% 0.001µs 1 200
credit_card/is_card_number/x371413321323331 throughput 163636044.224op/s 165696490.973op/s ± 357110.015op/s 165786480.113op/s ± 63415.833op/s 165841841.897op/s 165899701.575op/s 165914352.985op/s 165939206.400op/s 0.09% -4.119 18.112 0.21% 25251.491op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.894µs 3.911µs ± 0.002µs 3.911µs ± 0.001µs 3.912µs 3.914µs 3.916µs 3.918µs 0.18% -1.342 11.863 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255252032.683op/s 255707540.691op/s ± 152157.485op/s 255719498.614op/s ± 79418.830op/s 255789705.450op/s 255893666.725op/s 255961028.033op/s 256792549.581op/s 0.42% 1.363 12.025 0.06% 10759.159op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 63.955µs 64.437µs ± 0.167µs 64.430µs ± 0.105µs 64.535µs 64.711µs 64.837µs 65.188µs 1.18% 0.529 1.824 0.26% 0.012µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15340284.383op/s 15519047.991op/s ± 40202.632op/s 15520774.212op/s ± 25271.234op/s 15546057.528op/s 15576005.865op/s 15612868.352op/s 15636099.062op/s 0.74% -0.502 1.759 0.26% 2842.755op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 57.796µs 58.038µs ± 0.166µs 58.001µs ± 0.090µs 58.102µs 58.324µs 58.485µs 58.867µs 1.49% 1.495 3.399 0.28% 0.012µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 16987411.248op/s 17230272.006op/s ± 48997.634op/s 17241155.076op/s ± 26649.970op/s 17265180.448op/s 17284772.807op/s 17292733.830op/s 17302270.058op/s 0.35% -1.468 3.251 0.28% 3464.656op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.890µs 3.911µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.916µs 3.917µs 3.921µs 0.25% -1.405 12.379 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 255069468.274op/s 255680215.933op/s ± 192051.017op/s 255696075.066op/s ± 113298.064op/s 255800408.058op/s 255903995.157op/s 255981394.463op/s 257070132.392op/s 0.54% 1.433 12.598 0.07% 13580.058op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.545µs 54.827µs ± 0.224µs 54.757µs ± 0.138µs 54.952µs 55.260µs 55.527µs 55.591µs 1.52% 1.094 0.832 0.41% 0.016µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17988418.997op/s 18239476.072op/s ± 74064.858op/s 18262456.973op/s ± 46057.478op/s 18299342.596op/s 18321071.437op/s 18330570.023op/s 18333412.645op/s 0.39% -1.074 0.768 0.41% 5237.176op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 52.135µs 52.196µs ± 0.034µs 52.189µs ± 0.019µs 52.211µs 52.264µs 52.319µs 52.359µs 0.33% 1.532 3.817 0.06% 0.002µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19098901.873op/s 19158741.082op/s ± 12469.313op/s 19161145.987op/s ± 6809.026op/s 19167051.360op/s 19173963.483op/s 19176852.446op/s 19180957.146op/s 0.10% -1.525 3.785 0.06% 881.714op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.027µs 6.035µs ± 0.008µs 6.033µs ± 0.003µs 6.036µs 6.046µs 6.068µs 6.105µs 1.19% 4.564 30.206 0.14% 0.001µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 163799710.420op/s 165699899.252op/s ± 223722.554op/s 165747884.567op/s ± 73364.648op/s 165810695.221op/s 165885631.828op/s 165900787.401op/s 165929397.392op/s 0.11% -4.518 29.663 0.13% 15819.573op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.911µs; 3.912µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ throughput [255609582.387op/s; 255663778.733op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [78.427µs; 78.661µs] or [-0.149%; +0.149%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12714343.463op/s; 12752100.760op/s] or [-0.148%; +0.148%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [70.909µs; 71.066µs] or [-0.110%; +0.110%] None None None
credit_card/is_card_number/ 378282246310005 throughput [14072344.285op/s; 14103355.359op/s] or [-0.110%; +0.110%] None None None
credit_card/is_card_number/37828224631 execution_time [3.911µs; 3.912µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/37828224631 throughput [255623489.669op/s; 255677647.868op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/378282246310005 execution_time [68.110µs; 68.296µs] or [-0.136%; +0.136%] None None None
credit_card/is_card_number/378282246310005 throughput [14643647.764op/s; 14683349.981op/s] or [-0.135%; +0.135%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.189µs; 52.198µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19157976.364op/s; 19161200.492op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.033µs; 6.037µs] or [-0.030%; +0.030%] None None None
credit_card/is_card_number/x371413321323331 throughput [165646998.959op/s; 165745982.986op/s] or [-0.030%; +0.030%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.910µs; 3.911µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ throughput [255686453.127op/s; 255728628.255op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [64.414µs; 64.461µs] or [-0.036%; +0.036%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15513476.293op/s; 15524619.689op/s] or [-0.036%; +0.036%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [58.015µs; 58.061µs] or [-0.040%; +0.040%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17223481.405op/s; 17237062.607op/s] or [-0.039%; +0.039%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.911µs; 3.912µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255653599.509op/s; 255706832.357op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.796µs; 54.858µs] or [-0.057%; +0.057%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18229211.395op/s; 18249740.749op/s] or [-0.056%; +0.056%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.191µs; 52.200µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19157012.955op/s; 19160469.209op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.034µs; 6.036µs] or [-0.019%; +0.019%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165668893.457op/s; 165730905.046op/s] or [-0.019%; +0.019%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9ee8161 1759954062 gyuheon0h/prof-12603-dual-uploads
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2597 execution_time 9.719ms 9.795ms ± 0.054ms 9.784ms ± 0.022ms 9.811ms 9.881ms 9.968ms 10.251ms 4.78% 3.733 25.164 0.55% 0.004ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2597 execution_time [9.787ms; 9.802ms] or [-0.076%; +0.076%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9ee8161 1759954062 gyuheon0h/prof-12603-dual-uploads
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 534.205µs 534.918µs ± 0.397µs 534.880µs ± 0.243µs 535.107µs 535.569µs 535.951µs 536.525µs 0.31% 0.904 1.329 0.07% 0.028µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1863844.820op/s 1869446.974op/s ± 1385.217op/s 1869576.682op/s ± 850.085op/s 1870446.546op/s 1871313.533op/s 1871686.851op/s 1871938.898op/s 0.13% -0.899 1.311 0.07% 97.950op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 379.759µs 380.545µs ± 0.416µs 380.515µs ± 0.219µs 380.734µs 381.267µs 381.444µs 383.338µs 0.74% 1.830 9.245 0.11% 0.029µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2608662.711op/s 2627814.057op/s ± 2866.757op/s 2628018.944op/s ± 1512.339op/s 2629526.773op/s 2631613.423op/s 2632780.408op/s 2633252.298op/s 0.20% -1.805 9.041 0.11% 202.710op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 193.998µs 194.415µs ± 0.177µs 194.397µs ± 0.101µs 194.527µs 194.706µs 194.859µs 195.019µs 0.32% 0.330 0.360 0.09% 0.012µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5127709.657op/s 5143648.497op/s ± 4672.447op/s 5144107.780op/s ± 2668.438op/s 5146471.630op/s 5150374.469op/s 5153916.802op/s 5154681.129op/s 0.21% -0.324 0.354 0.09% 330.392op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 35.868µs 36.061µs ± 0.110µs 36.045µs ± 0.071µs 36.127µs 36.224µs 36.314µs 36.723µs 1.88% 1.445 6.167 0.30% 0.008µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 27231082.497op/s 27731274.277op/s ± 84095.642op/s 27743140.946op/s ± 54830.991op/s 27793794.490op/s 27851656.491op/s 27869351.130op/s 27879950.854op/s 0.49% -1.390 5.805 0.30% 5946.460op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 44.897µs 45.066µs ± 0.150µs 45.046µs ± 0.121µs 45.174µs 45.266µs 45.323µs 46.225µs 2.62% 2.397 15.916 0.33% 0.011µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21633096.908op/s 22190136.890op/s ± 73278.628op/s 22199682.716op/s ± 59341.478op/s 22250489.960op/s 22272073.722op/s 22272741.089op/s 22273109.403op/s 0.33% -2.280 14.734 0.33% 5181.582op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [534.863µs; 534.973µs] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1869254.996op/s; 1869638.952op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [380.487µs; 380.603µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2627416.752op/s; 2628211.361op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [194.390µs; 194.439µs] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5143000.941op/s; 5144296.053op/s] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [36.045µs; 36.076µs] or [-0.042%; +0.042%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [27719619.430op/s; 27742929.125op/s] or [-0.042%; +0.042%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [45.045µs; 45.086µs] or [-0.046%; +0.046%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [22179981.177op/s; 22200292.603op/s] or [-0.046%; +0.046%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9ee8161 1759954062 gyuheon0h/prof-12603-dual-uploads
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 14.376ms 14.458ms ± 0.034ms 14.455ms ± 0.015ms 14.468ms 14.504ms 14.584ms 14.672ms 1.50% 2.176 9.586 0.24% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [14.454ms; 14.463ms] or [-0.033%; +0.033%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9ee8161 1759954062 gyuheon0h/prof-12603-dual-uploads
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 86.599µs 86.842µs ± 0.170µs 86.831µs ± 0.058µs 86.887µs 86.957µs 87.966µs 88.137µs 1.50% 5.159 34.481 0.20% 0.012µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [86.818µs; 86.866µs] or [-0.027%; +0.027%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9ee8161 1759954062 gyuheon0h/prof-12603-dual-uploads
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 34.221µs 34.805µs ± 0.972µs 34.362µs ± 0.044µs 34.456µs 36.877µs 36.920µs 38.652µs 12.48% 1.791 1.556 2.78% 0.069µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [34.671µs; 34.940µs] or [-0.387%; +0.387%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9ee8161 1759954062 gyuheon0h/prof-12603-dual-uploads
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.164µs 3.163µs ± 1.439µs 2.989µs ± 0.023µs 3.008µs 3.403µs 13.808µs 15.160µs 407.18% 7.515 57.030 45.39% 0.102µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.963µs; 3.362µs] or [-6.306%; +6.306%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9ee8161 1759954062 gyuheon0h/prof-12603-dual-uploads
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 10.454ms 10.488ms ± 0.014ms 10.487ms ± 0.009ms 10.497ms 10.511ms 10.529ms 10.544ms 0.54% 0.713 1.369 0.14% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [10.486ms; 10.490ms] or [-0.019%; +0.019%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9ee8161 1759954062 gyuheon0h/prof-12603-dual-uploads
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.392µs 2.440µs ± 0.018µs 2.437µs ± 0.007µs 2.444µs 2.489µs 2.497µs 2.500µs 2.57% 1.397 3.245 0.73% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.437µs; 2.442µs] or [-0.102%; +0.102%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9ee8161 1759954062 gyuheon0h/prof-12603-dual-uploads
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 59.896ms 60.271ms ± 1.948ms 60.009ms ± 0.044ms 60.051ms 60.251ms 73.484ms 77.283ms 28.79% 8.003 63.216 3.22% 0.138ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [60.002ms; 60.541ms] or [-0.448%; +0.448%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9ee8161 1759954062 gyuheon0h/prof-12603-dual-uploads
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.312µs 25.598µs ± 10.051µs 18.048µs ± 0.253µs 34.879µs 44.727µs 45.604µs 70.223µs 289.09% 0.997 0.527 39.16% 0.711µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.205µs; 26.991µs] or [-5.441%; +5.441%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9ee8161 1759954062 gyuheon0h/prof-12603-dual-uploads
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 156.271µs 157.306µs ± 0.517µs 157.178µs ± 0.254µs 157.554µs 158.155µs 158.910µs 160.786µs 2.30% 2.303 10.538 0.33% 0.037µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [157.234µs; 157.377µs] or [-0.046%; +0.046%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9ee8161 1759954062 gyuheon0h/prof-12603-dual-uploads
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.980µs 5.042µs ± 0.032µs 5.049µs ± 0.022µs 5.066µs 5.078µs 5.085µs 5.094µs 0.88% -0.672 -0.907 0.63% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.038µs; 5.047µs] or [-0.088%; +0.088%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 88.33992% with 59 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.00%. Comparing base (4ad519f) to head (c1a86f5).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1259      +/-   ##
==========================================
+ Coverage   71.67%   72.00%   +0.33%     
==========================================
  Files         355      357       +2     
  Lines       56457    57181     +724     
==========================================
+ Hits        40465    41174     +709     
- Misses      15992    16007      +15
Components Coverage Δ
datadog-crashtracker 53.28% <88.33%> (+3.99%) ⬆️
datadog-crashtracker-ffi 5.93% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 88.03% <ø> (-2.44%) ⬇️
data-pipeline-ffi 88.19% <ø> (ø)
ddcommon 84.57% <ø> (+0.02%) ⬆️
ddcommon-ffi 73.84% <ø> (ø)
ddtelemetry 59.45% <ø> (-0.04%) ⬇️
ddtelemetry-ffi 21.24% <ø> (ø)
dogstatsd-client 83.26% <ø> (ø)
datadog-ipc 82.49% <ø> (+0.10%) ⬆️
datadog-profiling 76.90% <ø> (ø)
datadog-profiling-ffi 62.12% <ø> (ø)
datadog-sidecar 37.01% <ø> (-0.18%) ⬇️
datdog-sidecar-ffi 11.03% <ø> (-0.84%) ⬇️
spawn-worker 55.35% <ø> (ø)
tinybytes 92.22% <ø> (ø)
datadog-trace-normalization 98.24% <ø> (ø)
datadog-trace-obfuscation 94.17% <ø> (ø)
datadog-trace-protobuf 59.65% <ø> (ø)
datadog-trace-utils 89.84% <ø> (+0.07%) ⬆️
datadog-tracer-flare 54.52% <ø> (ø)
datadog-log 76.31% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@datadog-datadog-prod-us1

This comment has been minimized.

Sign in to view
@dd-octo-sts
Copy link

dd-octo-sts bot commented Oct 3, 2025 •
edited
Loading

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.25 MB 7.25 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 71.29 MB 71.56 MB +.37% (+271.22 KB) 🔍
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.27 MB 9.34 MB +.77% (+73.40 KB) 🔍
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 83.62 MB 84.05 MB +.51% (+444.82 KB) 🔍
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 18.47 MB 18.54 MB +.37% (+71.00 KB) 🔍
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 65.77 KB 65.77 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 125.30 MB 125.61 MB +.24% (+320.00 KB) 🔍
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 654.82 MB 659.61 MB +.73% (+4.79 MB) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 5.92 MB 5.96 MB +.70% (+42.50 KB) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 65.77 KB 65.77 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 17.44 MB 17.51 MB +.35% (+64.00 KB) 🔍
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 32.39 MB 32.54 MB +.45% (+151.14 KB) 🔍
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 15.75 MB 15.81 MB +.40% (+65.50 KB) 🔍
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 66.79 KB 66.79 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 127.62 MB 127.95 MB +.26% (+344.00 KB) 🔍
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 645.00 MB 649.76 MB +.73% (+4.76 MB) 🔍
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 4.53 MB 4.56 MB +.61% (+28.50 KB) 🔍
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 66.79 KB 66.79 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 18.57 MB 18.64 MB +.37% (+72.00 KB) 🔍
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 30.42 MB 30.55 MB +.42% (+132.71 KB) 🔍
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 63.91 MB 64.15 MB +.37% (+242.98 KB) 🔍
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.56 MB 8.59 MB +.36% (+32.00 KB) 🔍
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 78.33 MB 78.70 MB +.47% (+378.21 KB) 🔍
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.91 MB 9.96 MB +.49% (+50.60 KB) 🔍

@gyuheon0h gyuheon0h force-pushed the gyuheon0h/prof-12603-dual-uploads branch from 7a55094 to d42530c Compare October 6, 2025 17:45
@gyuheon0h gyuheon0h force-pushed the gyuheon0h/prof-12603-dual-uploads branch from 74a5f22 to 9e55d5f Compare October 7, 2025 14:46
@gyuheon0h gyuheon0h marked this pull request as ready for review October 7, 2025 14:47
@gyuheon0h gyuheon0h requested a review from a team as a code owner October 7, 2025 14:47
@gyuheon0h gyuheon0h changed the title [crashtracking] upload to both telemetry intake and errors intake [WIP] upload to both telemetry intake and errors intake Oct 7, 2025
@gyuheon0h gyuheon0h changed the title [WIP] upload to both telemetry intake and errors intake [WIP][crashtracking] upload to both telemetry intake and errors intake Oct 7, 2025
@gyuheon0h gyuheon0h requested a review from a team as a code owner October 7, 2025 17:22
@gyuheon0h gyuheon0h changed the title [WIP][crashtracking] upload to both telemetry intake and errors intake [crashtracking] upload to both telemetry intake and errors intake Oct 7, 2025
gleocadie
gleocadie reviewed Oct 8, 2025
View reviewed changes
@gyuheon0h gyuheon0h force-pushed the gyuheon0h/prof-12603-dual-uploads branch 2 times, most recently from f1a953b to 9ee8161 Compare October 9, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gleocadie gleocadie gleocadie left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
crashtracker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gyuheon0h @codecov-commenter @gleocadie