-
Notifications
You must be signed in to change notification settings - Fork 15
[APMSP-2308] feat(ddtelemetry): filled kernel information #1261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksComparisonBenchmark execution time: 2025-10-08 10:00:46 Comparing candidate commit 2110469 in PR branch Found 14 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics. scenario:credit_card/is_card_number/378282246310005
scenario:credit_card/is_card_number/x371413321323331
scenario:credit_card/is_card_number_no_luhn/x371413321323331
scenario:normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...
scenario:normalization/normalize_name/normalize_name/good
scenario:normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...
scenario:normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
BaselineOmitted due to size. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1261 +/- ##
==========================================
+ Coverage 71.82% 71.90% +0.07%
==========================================
Files 356 356
Lines 56685 56691 +6
==========================================
+ Hits 40716 40765 +49
+ Misses 15969 15926 -43
🚀 New features to boost your workflow:
|
b110d4a
to
bb667ee
Compare
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
…, and documentation for unsafe function
ccf0a2d
to
86d533c
Compare
86d533c
to
6c0d362
Compare
0c74f3e
to
492e809
Compare
492e809
to
ce9e8d3
Compare
Kernel namePython implemplatform.system():
https://docs.python.org/3/library/platform.html#platform.system This implemsys_info::os_type():
https://docs.rs/sys-info/latest/sys_info/fn.os_type.html Kernel releasePython implemplatform.release():
https://docs.python.org/3/library/platform.html#platform.release This implemsys_info::os_release():
https://docs.rs/sys-info/latest/sys_info/fn.os_release.html Kernel versionPython implemplatform.version():
https://docs.python.org/3/library/platform.html#platform.version This implemUnixI tested in on mac and linux docker, and both python and rust implem return a string equivalent to libc::uname().version
Windows"{major}.{minor}.{build}" |
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
Tests failed on this commit 80a5488: What to do next?
|
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
|
What does this PR do?
Add os information to telemetry
Motivation
https://datadoghq.atlassian.net/browse/APMSP-2308
Additional Notes
What's the policy around unsafe ? Is there a better way to get uname information without using external crates that do just this but abstracted and increasing the package size ?