Skip to content

Prevent span start overflow panic #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dd-mergequeue merged 3 commits into from
Dec 17, 2025
Merged

Prevent span start overflow panic #1373

dd-mergequeue merged 3 commits into from
Dec 17, 2025

Conversation

@VianneyRuhlmann
Copy link
Contributor

@VianneyRuhlmann VianneyRuhlmann commented Nov 26, 2025 •
edited
Loading

for Dev Agent Session identified by Workflow Automation

You can ask for changes by mentioning @DataDog in a comment.

Feedback (especially what can be better) welcome in #code-gen-feedback!

What does this PR do?

  • add a regression test that exercises span normalization with an i64::MIN start value
  • guard normalize_span_start_duration with checked_add to avoid overflowing when computing start + duration

Motivation

A libFuzzer input produced an overflow panic in normalize_span_start_duration when start was near negative, because we were subtracting from i64::MAX before clamping the duration.

Additional Notes

cargo test -p libdd-trace-normalization currently cannot run in this sandbox because Cargo attempts to fetch the patched proptest git dependency from GitHub, but the environment has no network access.

How to test the change?

Run cargo test -p libdd-trace-normalization test_normalize_span_start_duration_handles_min_start in an environment that can download the workspace dependencies.

@datadog-datadog-prod-us1 @VianneyRuhlmann
avoid span duration overflow
fd37423 
Co-authored-by: VianneyRuhlmann <[email protected]>
@VianneyRuhlmann VianneyRuhlmann requested review from a team as code owners November 26, 2025 16:34
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Nov 26, 2025

Bits AI Dev Agent Status: ✅ Done [Fix CI Errors]

You can ask for changes by mentioning @DataDog in a comment.

@datadog-datadog-prod-us1

This comment has been minimized.

Sign in to view
@pr-commenter
Copy link

pr-commenter bot commented Nov 26, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-12-17 14:41:04

Comparing candidate commit aadcd56 in PR branch dd/fix-span-overflow-check with baseline commit 660c550 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aadcd56 1765981477 dd/fix-span-overflow-check
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.361µs 2.389µs ± 0.015µs 2.386µs ± 0.005µs 2.391µs 2.433µs 2.437µs 2.454µs 2.84% 2.093 4.420 0.64% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.387µs; 2.391µs] or [-0.089%; +0.089%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aadcd56 1765981477 dd/fix-span-overflow-check
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample2_frames_x1000 execution_time 525.113µs 525.824µs ± 0.532µs 525.736µs ± 0.212µs 525.972µs 526.529µs 527.932µs 530.097µs 0.83% 3.764 22.923 0.10% 0.038µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample2_frames_x1000 execution_time [525.750µs; 525.898µs] or [-0.014%; +0.014%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aadcd56 1765981477 dd/fix-span-overflow-check
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.407µs 33.840µs ± 0.692µs 33.555µs ± 0.070µs 33.648µs 35.168µs 35.199µs 38.505µs 14.75% 2.609 9.630 2.04% 0.049µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.744µs; 33.936µs] or [-0.284%; +0.284%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aadcd56 1765981477 dd/fix-span-overflow-check
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sdk_test_data/rules-based execution_time 144.089µs 145.950µs ± 1.638µs 145.689µs ± 0.525µs 146.285µs 147.548µs 152.700µs 160.621µs 10.25% 5.147 37.216 1.12% 0.116µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sdk_test_data/rules-based execution_time [145.723µs; 146.177µs] or [-0.156%; +0.156%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aadcd56 1765981477 dd/fix-span-overflow-check
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample_frames_x1000 execution_time 3.896ms 3.901ms ± 0.007ms 3.900ms ± 0.002ms 3.902ms 3.906ms 3.909ms 3.994ms 2.40% 11.396 146.613 0.18% 0.000ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample_frames_x1000 execution_time [3.900ms; 3.902ms] or [-0.025%; +0.025%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aadcd56 1765981477 dd/fix-span-overflow-check
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.858µs 25.522µs ± 9.697µs 18.076µs ± 0.166µs 34.017µs 43.696µs 44.814µs 69.309µs 283.43% 0.996 0.694 37.90% 0.686µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.178µs; 26.866µs] or [-5.266%; +5.266%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aadcd56 1765981477 dd/fix-span-overflow-check
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.976µs 5.044µs ± 0.042µs 5.045µs ± 0.043µs 5.086µs 5.102µs 5.107µs 5.107µs 1.23% -0.028 -1.395 0.83% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.039µs; 5.050µs] or [-0.115%; +0.115%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aadcd56 1765981477 dd/fix-span-overflow-check
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2597 execution_time 9.711ms 9.905ms ± 0.050ms 9.902ms ± 0.029ms 9.935ms 9.973ms 10.049ms 10.115ms 2.16% 0.531 3.029 0.50% 0.004ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2597 execution_time [9.898ms; 9.912ms] or [-0.070%; +0.070%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aadcd56 1765981477 dd/fix-span-overflow-check
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 533.876µs 534.656µs ± 0.721µs 534.553µs ± 0.203µs 534.837µs 535.319µs 535.511µs 543.460µs 1.67% 9.178 109.330 0.13% 0.051µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1840062.025op/s 1870363.533op/s ± 2492.158op/s 1870720.658op/s ± 710.827op/s 1871332.876op/s 1872433.507op/s 1872944.147op/s 1873092.476op/s 0.13% -9.069 107.547 0.13% 176.222op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 380.462µs 380.986µs ± 0.259µs 380.934µs ± 0.149µs 381.132µs 381.470µs 381.730µs 381.798µs 0.23% 0.671 0.484 0.07% 0.018µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2619186.062op/s 2624770.822op/s ± 1783.156op/s 2625126.663op/s ± 1026.004op/s 2625960.249op/s 2627421.669op/s 2628020.977op/s 2628382.485op/s 0.12% -0.666 0.476 0.07% 126.088op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 189.811µs 190.503µs ± 0.278µs 190.455µs ± 0.189µs 190.667µs 191.032µs 191.147µs 191.337µs 0.46% 0.477 -0.129 0.15% 0.020µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5226370.173op/s 5249280.638op/s ± 7661.539op/s 5250587.308op/s ± 5216.008op/s 5255097.950op/s 5260301.752op/s 5264165.297op/s 5268400.700op/s 0.34% -0.469 -0.136 0.15% 541.753op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.222µs 37.373µs ± 0.044µs 37.379µs ± 0.024µs 37.399µs 37.433µs 37.504µs 37.527µs 0.40% -0.071 1.365 0.12% 0.003µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26647344.417op/s 26757110.022op/s ± 31510.580op/s 26753218.938op/s ± 17439.716op/s 26774047.166op/s 26810925.956op/s 26831187.443op/s 26865637.547op/s 0.42% 0.083 1.358 0.12% 2228.134op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 45.833µs 45.921µs ± 0.092µs 45.910µs ± 0.024µs 45.934µs 45.992µs 46.031µs 47.085µs 2.56% 10.173 125.645 0.20% 0.007µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21238015.860op/s 21776656.882op/s ± 42854.134op/s 21781944.583op/s ± 11270.897op/s 21792318.960op/s 21806854.944op/s 21813522.822op/s 21818557.362op/s 0.17% -10.028 123.179 0.20% 3030.245op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [534.556µs; 534.756µs] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1870018.144op/s; 1870708.922op/s] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [380.950µs; 381.022µs] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2624523.694op/s; 2625017.950op/s] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [190.464µs; 190.541µs] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5248218.822op/s; 5250342.453op/s] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.367µs; 37.379µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26752742.958op/s; 26761477.085op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [45.908µs; 45.934µs] or [-0.028%; +0.028%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21770717.711op/s; 21782596.053op/s] or [-0.027%; +0.027%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aadcd56 1765981477 dd/fix-span-overflow-check
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 89.779µs 90.308µs ± 0.169µs 90.274µs ± 0.091µs 90.409µs 90.577µs 90.724µs 91.331µs 1.17% 1.490 6.698 0.19% 0.012µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [90.285µs; 90.332µs] or [-0.026%; +0.026%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aadcd56 1765981477 dd/fix-span-overflow-check
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 10.678ms 10.705ms ± 0.013ms 10.705ms ± 0.009ms 10.713ms 10.726ms 10.736ms 10.764ms 0.55% 0.821 2.091 0.13% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [10.704ms; 10.707ms] or [-0.017%; +0.017%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aadcd56 1765981477 dd/fix-span-overflow-check
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.204µs 3.169µs ± 1.428µs 3.000µs ± 0.024µs 3.018µs 3.357µs 13.788µs 15.180µs 405.97% 7.525 57.189 44.96% 0.101µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.971µs; 3.367µs] or [-6.246%; +6.246%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aadcd56 1765981477 dd/fix-span-overflow-check
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 160.760µs 161.616µs ± 0.421µs 161.515µs ± 0.155µs 161.684µs 162.384µs 163.406µs 164.642µs 1.94% 3.140 15.879 0.26% 0.030µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [161.558µs; 161.674µs] or [-0.036%; +0.036%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aadcd56 1765981477 dd/fix-span-overflow-check
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.899µs 3.912µs ± 0.003µs 3.912µs ± 0.001µs 3.913µs 3.916µs 3.922µs 3.925µs 0.33% 0.746 4.819 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 254801493.493op/s 255630937.855op/s ± 180780.361op/s 255645253.572op/s ± 97955.296op/s 255742223.043op/s 255860077.580op/s 255941300.184op/s 256448984.905op/s 0.31% -0.732 4.809 0.07% 12783.102op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 77.072µs 78.410µs ± 0.828µs 78.247µs ± 0.637µs 79.027µs 79.853µs 80.410µs 80.670µs 3.10% 0.477 -0.555 1.05% 0.059µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12396201.335op/s 12754810.710op/s ± 134022.985op/s 12780081.289op/s ± 103186.824op/s 12871114.061op/s 12941040.833op/s 12967357.125op/s 12974957.515op/s 1.52% -0.439 -0.613 1.05% 9476.856op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 70.654µs 70.964µs ± 0.333µs 70.901µs ± 0.194µs 71.046µs 71.616µs 72.150µs 72.469µs 2.21% 1.746 3.593 0.47% 0.024µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13799010.464op/s 14091873.107op/s ± 65609.964op/s 14104126.949op/s ± 38696.106op/s 14143130.538op/s 14149551.375op/s 14153133.979op/s 14153521.542op/s 0.35% -1.711 3.408 0.46% 4639.325op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.894µs 3.912µs ± 0.003µs 3.912µs ± 0.002µs 3.914µs 3.917µs 3.920µs 3.921µs 0.25% -0.660 6.555 0.08% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255009220.140op/s 255601874.966op/s ± 194861.909op/s 255637885.536op/s ± 124312.993op/s 255713549.602op/s 255846862.802op/s 255895034.198op/s 256813443.521op/s 0.46% 0.678 6.664 0.08% 13778.818op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 67.435µs 67.646µs ± 0.227µs 67.536µs ± 0.062µs 67.748µs 68.104µs 68.375µs 68.740µs 1.78% 1.832 3.674 0.34% 0.016µs 1 200
credit_card/is_card_number/378282246310005 throughput 14547494.769op/s 14783101.858op/s ± 49349.652op/s 14806853.352op/s ± 13670.006op/s 14817377.450op/s 14822548.432op/s 14826710.512op/s 14829072.396op/s 0.15% -1.809 3.542 0.33% 3489.547op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 44.591µs 45.177µs ± 0.181µs 45.192µs ± 0.116µs 45.306µs 45.439µs 45.523µs 45.561µs 0.82% -0.433 0.151 0.40% 0.013µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 21948522.607op/s 22135731.166op/s ± 88944.428op/s 22128036.354op/s ± 57165.007op/s 22192891.064op/s 22279513.816op/s 22372734.171op/s 22425873.397op/s 1.35% 0.457 0.191 0.40% 6289.321op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.028µs 6.034µs ± 0.003µs 6.033µs ± 0.002µs 6.036µs 6.040µs 6.043µs 6.045µs 0.19% 0.833 0.648 0.05% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 165435386.100op/s 165726015.331op/s ± 84371.513op/s 165746243.208op/s ± 55521.882op/s 165786764.503op/s 165832666.964op/s 165864582.306op/s 165892568.093op/s 0.09% -0.830 0.641 0.05% 5965.967op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.896µs 3.912µs ± 0.002µs 3.911µs ± 0.002µs 3.913µs 3.915µs 3.918µs 3.919µs 0.20% -0.771 6.815 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255151984.568op/s 255637905.992op/s ± 159803.102op/s 255663082.252op/s ± 100193.583op/s 255739351.893op/s 255835110.374op/s 255939273.055op/s 256641618.097op/s 0.38% 0.786 6.909 0.06% 11299.786op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 64.199µs 65.852µs ± 0.126µs 65.857µs ± 0.020µs 65.882µs 65.931µs 65.952µs 66.000µs 0.22% -11.401 146.551 0.19% 0.009µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15151468.332op/s 15185714.709op/s ± 29708.002op/s 15184473.117op/s ± 4522.456op/s 15188081.153op/s 15196984.918op/s 15232279.632op/s 15576553.843op/s 2.58% 11.507 148.440 0.20% 2100.673op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 52.956µs 53.022µs ± 0.032µs 53.020µs ± 0.025µs 53.046µs 53.081µs 53.092µs 53.117µs 0.18% 0.309 -0.447 0.06% 0.002µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 18826540.721op/s 18860075.930op/s ± 11506.656op/s 18860820.422op/s ± 8849.018op/s 18868640.320op/s 18877452.866op/s 18881041.870op/s 18883584.500op/s 0.12% -0.307 -0.449 0.06% 813.643op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.893µs 3.912µs ± 0.004µs 3.911µs ± 0.001µs 3.913µs 3.916µs 3.923µs 3.947µs 0.92% 3.796 39.322 0.10% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 253345583.489op/s 255633253.982op/s ± 247630.755op/s 255668821.188op/s ± 86406.493op/s 255748150.987op/s 255841177.074op/s 255904392.887op/s 256902276.966op/s 0.48% -3.718 38.665 0.10% 17510.139op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 49.744µs 49.811µs ± 0.033µs 49.808µs ± 0.024µs 49.832µs 49.863µs 49.890µs 49.936µs 0.26% 0.441 0.041 0.07% 0.002µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 20025551.009op/s 20075968.225op/s ± 13402.196op/s 20077150.195op/s ± 9744.110op/s 20086879.752op/s 20095325.425op/s 20100195.937op/s 20102784.236op/s 0.13% -0.437 0.033 0.07% 947.678op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 44.651µs 45.170µs ± 0.166µs 45.178µs ± 0.122µs 45.294µs 45.431µs 45.523µs 45.527µs 0.77% -0.221 -0.246 0.37% 0.012µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 21965096.472op/s 22138753.241op/s ± 81306.086op/s 22134840.590op/s ± 59862.550op/s 22197082.750op/s 22271876.064op/s 22322450.246op/s 22395874.317op/s 1.18% 0.240 -0.224 0.37% 5749.208op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.028µs 6.035µs ± 0.004µs 6.035µs ± 0.002µs 6.037µs 6.043µs 6.047µs 6.050µs 0.25% 0.994 0.976 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 165301722.031op/s 165688496.165op/s ± 110391.051op/s 165708558.847op/s ± 64289.862op/s 165772454.996op/s 165830873.726op/s 165861545.665op/s 165886207.268op/s 0.11% -0.990 0.965 0.07% 7805.826op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.912µs; 3.912µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ throughput [255605883.436op/s; 255655992.274op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [78.296µs; 78.525µs] or [-0.146%; +0.146%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12736236.413op/s; 12773385.007op/s] or [-0.146%; +0.146%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [70.918µs; 71.011µs] or [-0.065%; +0.065%] None None None
credit_card/is_card_number/ 378282246310005 throughput [14082780.197op/s; 14100966.017op/s] or [-0.065%; +0.065%] None None None
credit_card/is_card_number/37828224631 execution_time [3.912µs; 3.913µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/37828224631 throughput [255574868.980op/s; 255628880.953op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/378282246310005 execution_time [67.614µs; 67.677µs] or [-0.047%; +0.047%] None None None
credit_card/is_card_number/378282246310005 throughput [14776262.471op/s; 14789941.245op/s] or [-0.046%; +0.046%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [45.151µs; 45.202µs] or [-0.056%; +0.056%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [22123404.323op/s; 22148058.008op/s] or [-0.056%; +0.056%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.034µs; 6.034µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/x371413321323331 throughput [165714322.251op/s; 165737708.412op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.911µs; 3.912µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ throughput [255615758.819op/s; 255660053.165op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [65.834µs; 65.869µs] or [-0.027%; +0.027%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15181597.466op/s; 15189831.953op/s] or [-0.027%; +0.027%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [53.018µs; 53.027µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [18858481.218op/s; 18861670.642op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.911µs; 3.912µs] or [-0.013%; +0.013%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255598934.741op/s; 255667573.223op/s] or [-0.013%; +0.013%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [49.806µs; 49.815µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [20074110.809op/s; 20077825.640op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [45.147µs; 45.193µs] or [-0.051%; +0.051%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [22127485.000op/s; 22150021.483op/s] or [-0.051%; +0.051%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.035µs; 6.036µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165673197.027op/s; 165703795.303op/s] or [-0.009%; +0.009%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aadcd56 1765981477 dd/fix-span-overflow-check
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 242.003ns 254.923ns ± 14.231ns 248.298ns ± 4.172ns 263.126ns 285.061ns 292.181ns 293.417ns 18.17% 1.274 0.255 5.57% 1.006ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [252.951ns; 256.895ns] or [-0.774%; +0.774%] None None None

Group 16

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aadcd56 1765981477 dd/fix-span-overflow-check
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 204.260µs 204.842µs ± 0.349µs 204.792µs ± 0.229µs 205.048µs 205.478µs 205.659µs 206.173µs 0.67% 0.734 0.247 0.17% 0.025µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4850286.088op/s 4881827.089op/s ± 8308.119op/s 4882992.288op/s ± 5457.233op/s 4888154.726op/s 4892642.304op/s 4894534.213op/s 4895729.561op/s 0.26% -0.726 0.223 0.17% 587.473op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.566µs 18.651µs ± 0.067µs 18.633µs ± 0.025µs 18.664µs 18.815µs 18.862µs 18.881µs 1.33% 1.662 2.391 0.36% 0.005µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 52964057.155op/s 53616340.248op/s ± 191955.397op/s 53668930.990op/s ± 73214.832op/s 53724624.660op/s 53816974.627op/s 53841896.307op/s 53861111.365op/s 0.36% -1.645 2.335 0.36% 13573.296op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.799µs 10.876µs ± 0.038µs 10.874µs ± 0.025µs 10.899µs 10.947µs 10.984µs 11.003µs 1.18% 0.533 0.589 0.35% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 90886083.383op/s 91946555.634op/s ± 324631.446op/s 91962772.235op/s ± 209399.711op/s 92162533.616op/s 92472891.578op/s 92552854.900op/s 92601166.775op/s 0.69% -0.508 0.543 0.35% 22954.910op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [204.794µs; 204.890µs] or [-0.024%; +0.024%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4880675.663op/s; 4882978.514op/s] or [-0.024%; +0.024%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.642µs; 18.661µs] or [-0.050%; +0.050%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [53589737.076op/s; 53642943.420op/s] or [-0.050%; +0.050%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.871µs; 10.881µs] or [-0.049%; +0.049%] None None None
normalization/normalize_name/normalize_name/good throughput [91901564.837op/s; 91991546.430op/s] or [-0.049%; +0.049%] None None None

Group 17

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aadcd56 1765981477 dd/fix-span-overflow-check
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 60.868ms 61.375ms ± 2.488ms 61.022ms ± 0.069ms 61.174ms 61.351ms 80.130ms 83.372ms 36.62% 8.002 62.598 4.04% 0.176ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [61.031ms; 61.720ms] or [-0.562%; +0.562%] None None None

Group 18

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aadcd56 1765981477 dd/fix-span-overflow-check
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 13.866ms 13.913ms ± 0.031ms 13.905ms ± 0.011ms 13.919ms 13.973ms 14.024ms 14.095ms 1.36% 2.433 8.196 0.22% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [13.909ms; 13.917ms] or [-0.031%; +0.031%] None None None

Group 19

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aadcd56 1765981477 dd/fix-span-overflow-check
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
single_flag_killswitch/rules-based execution_time 186.796ns 190.030ns ± 2.328ns 189.836ns ± 1.661ns 191.222ns 194.585ns 195.802ns 197.477ns 4.03% 0.770 -0.000 1.22% 0.165ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
single_flag_killswitch/rules-based execution_time [189.708ns; 190.353ns] or [-0.170%; +0.170%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.45%. Comparing base (660c550) to head (aadcd56).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1373      +/-   ##
==========================================
- Coverage   71.45%   71.45%   -0.01%     
==========================================
  Files         406      406              
  Lines       65203    65216      +13     
==========================================
+ Hits        46590    46597       +7     
- Misses      18613    18619       +6
Components Coverage Δ
libdd-crashtracker 58.99% <ø> (+0.03%) ⬆️
libdd-crashtracker-ffi 16.74% <ø> (ø)
libdd-alloc 98.73% <ø> (ø)
libdd-data-pipeline 86.62% <ø> (ø)
libdd-data-pipeline-ffi 81.08% <ø> (ø)
libdd-common 81.21% <ø> (ø)
libdd-common-ffi 74.96% <ø> (ø)
libdd-telemetry 59.92% <ø> (-0.04%) ⬇️
libdd-telemetry-ffi 21.17% <ø> (ø)
libdd-dogstatsd-client 83.75% <ø> (ø)
datadog-ipc 82.61% <ø> (-0.11%) ⬇️
libdd-profiling 81.83% <ø> (-0.03%) ⬇️
libdd-profiling-ffi 63.41% <ø> (ø)
datadog-sidecar 36.22% <ø> (ø)
datdog-sidecar-ffi 12.62% <ø> (ø)
spawn-worker 55.18% <ø> (ø)
libdd-tinybytes 92.44% <ø> (ø)
libdd-trace-normalization 82.33% <100.00%> (+0.28%) ⬆️
libdd-trace-obfuscation 94.17% <ø> (ø)
libdd-trace-protobuf 61.18% <ø> (ø)
libdd-trace-utils 90.07% <ø> (ø)
datadog-tracer-flare 63.49% <ø> (ø)
libdd-log 75.57% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dd-octo-sts
Copy link

dd-octo-sts bot commented Nov 27, 2025 •
edited
Loading

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.38 MB 7.38 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 85.96 MB 85.96 MB 0% (0 B) 👌
aarch64-apple-darwin
Artifact Baseline Commit Change
/aarch64-apple-darwin/lib/libdatadog_profiling.a 57.99 MB 57.99 MB 0% (0 B) 👌
/aarch64-apple-darwin/lib/libdatadog_profiling.dylib 8.43 MB 8.43 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.53 MB 9.53 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 99.69 MB 99.69 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 19.57 MB 19.57 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 69.82 KB 69.82 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 138.53 MB 138.53 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 735.63 MB 735.64 MB +0% (+4.36 KB) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 6.34 MB 6.34 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 69.82 KB 69.82 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 19.67 MB 19.67 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 38.64 MB 38.64 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 16.70 MB 16.70 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 70.90 KB 70.90 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 141.08 MB 141.08 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 724.37 MB 724.38 MB +0% (+4.50 KB) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 4.87 MB 4.87 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 70.90 KB 70.90 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 20.90 MB 20.90 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 36.39 MB 36.39 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 74.31 MB 74.31 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.85 MB 8.85 MB 0% (0 B) 👌
x86_64-apple-darwin
Artifact Baseline Commit Change
/x86_64-apple-darwin/lib/libdatadog_profiling.a 59.35 MB 59.35 MB 0% (0 B) 👌
/x86_64-apple-darwin/lib/libdatadog_profiling.dylib 9.47 MB 9.47 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 93.92 MB 93.92 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.28 MB 10.28 MB 0% (0 B) 👌

@VianneyRuhlmann
Copy link
Contributor Author

VianneyRuhlmann commented Dec 17, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Dec 17, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-12-17 14:26:08 UTC ℹ️ Start processing command /merge

2025-12-17 14:26:15 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-12-17 14:49:18 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 34m (p90).

2025-12-17 15:12:51 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 978619c into main Dec 17, 2025
37 of 38 checks passed
@dd-mergequeue dd-mergequeue bot deleted the dd/fix-span-overflow-check branch December 17, 2025 15:12
@github-actions github-actions bot mentioned this pull request Jan 14, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekump ekump ekump approved these changes

Assignees

No one assigned

Labels

Bits AI mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@VianneyRuhlmann @codecov-commenter @ekump @edznux-dd