Skip to content

refactor: harden and simplify ProfileStatus more #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dd-mergequeue merged 1 commit into from
Dec 19, 2025
Merged

refactor: harden and simplify ProfileStatus more #1419

dd-mergequeue merged 1 commit into from
Dec 19, 2025

Conversation

@morrisonlevi
Copy link
Contributor

@morrisonlevi morrisonlevi commented Dec 19, 2025

What does this PR do?

This simplifies ProfileStatus and hardens it:

  • Removes unnecessary conversions.
  • Replaces FLAG_STATIC and FLAG_ALLOCATED with a single IS_ALLOCATED_MASK. This is not a breaking change, these were private and the observable FFI semantics are the same.
  • Introduces debug checks in some places to surface issues earlier.

It also notes that it could be modified in the future to hold error codes as well.

Motivation

We merged in a PR to simplify things in #1416 to make it into a release, and it came up in review that as part of that, we did lose a bit of hardening to detect bad flags. Since the release was already slightly delayed, we chose to push a small bit of that into a new PR and not delay the release.

Additional Notes

None.

How to test the change?

cargo test -p "libdd-profiling-ffi" --lib

@pr-commenter
Copy link

pr-commenter bot commented Dec 19, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-12-19 01:09:45

Comparing candidate commit 033e544 in PR branch levi/harden-profile-status with baseline commit 5974f2e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 033e544 1766104814 levi/harden-profile-status
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 244.569ns 255.753ns ± 13.630ns 249.225ns ± 3.401ns 258.978ns 289.355ns 291.673ns 297.601ns 19.41% 1.544 1.209 5.32% 0.964ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [253.864ns; 257.642ns] or [-0.739%; +0.739%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 033e544 1766104814 levi/harden-profile-status
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
single_flag_killswitch/rules-based execution_time 185.464ns 188.496ns ± 2.680ns 187.940ns ± 1.521ns 189.545ns 193.204ns 199.590ns 202.989ns 8.01% 2.115 6.668 1.42% 0.189ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
single_flag_killswitch/rules-based execution_time [188.125ns; 188.868ns] or [-0.197%; +0.197%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 033e544 1766104814 levi/harden-profile-status
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sdk_test_data/rules-based execution_time 144.302µs 146.041µs ± 1.685µs 145.760µs ± 0.559µs 146.334µs 147.988µs 152.300µs 161.528µs 10.82% 5.615 42.652 1.15% 0.119µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sdk_test_data/rules-based execution_time [145.807µs; 146.274µs] or [-0.160%; +0.160%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 033e544 1766104814 levi/harden-profile-status
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.326µs 2.399µs ± 0.020µs 2.401µs ± 0.004µs 2.405µs 2.428µs 2.440µs 2.529µs 5.33% 0.248 10.200 0.84% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.396µs; 2.402µs] or [-0.117%; +0.117%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 033e544 1766104814 levi/harden-profile-status
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.894µs 3.912µs ± 0.003µs 3.912µs ± 0.002µs 3.914µs 3.917µs 3.918µs 3.920µs 0.21% -0.990 7.160 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 255070384.951op/s 255598343.670op/s ± 186232.016op/s 255597983.487op/s ± 119047.715op/s 255723854.270op/s 255854968.074op/s 255909086.799op/s 256790036.104op/s 0.47% 1.008 7.278 0.07% 13168.592op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 77.479µs 79.399µs ± 1.032µs 79.252µs ± 0.798µs 80.198µs 81.148µs 81.547µs 81.793µs 3.21% 0.269 -0.908 1.30% 0.073µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12225925.553op/s 12596770.026op/s ± 163231.842op/s 12617972.171op/s ± 127682.344op/s 12722926.244op/s 12844494.614op/s 12890731.491op/s 12906716.605op/s 2.29% -0.229 -0.929 1.29% 11542.234op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 70.627µs 70.972µs ± 0.324µs 70.901µs ± 0.186µs 71.119µs 71.726µs 71.957µs 72.155µs 1.77% 1.425 1.650 0.45% 0.023µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13859039.804op/s 14090350.706op/s ± 63857.204op/s 14104233.465op/s ± 37024.362op/s 14140819.951op/s 14149468.385op/s 14156089.443op/s 14158990.603op/s 0.39% -1.403 1.570 0.45% 4515.386op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.891µs 3.912µs ± 0.003µs 3.912µs ± 0.002µs 3.914µs 3.916µs 3.918µs 3.927µs 0.40% -0.576 10.932 0.08% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 254637220.632op/s 255643872.271op/s ± 200539.452op/s 255652129.139op/s ± 125524.999op/s 255773605.250op/s 255883186.774op/s 255913328.589op/s 256974335.731op/s 0.52% 0.606 11.051 0.08% 14180.281op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 67.428µs 67.693µs ± 0.275µs 67.585µs ± 0.125µs 67.821µs 68.089µs 68.507µs 69.683µs 3.10% 2.686 13.450 0.41% 0.019µs 1 200
credit_card/is_card_number/378282246310005 throughput 14350635.675op/s 14772920.180op/s ± 59425.291op/s 14796139.698op/s ± 27315.207op/s 14814564.198op/s 14827535.326op/s 14830184.899op/s 14830531.615op/s 0.23% -2.589 12.510 0.40% 4202.003op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 44.621µs 45.085µs ± 0.161µs 45.086µs ± 0.113µs 45.200µs 45.330µs 45.431µs 45.500µs 0.92% -0.152 -0.359 0.36% 0.011µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 21978193.870op/s 22180493.221op/s ± 79191.766op/s 22179838.602op/s ± 55823.329op/s 22232609.133op/s 22312613.212op/s 22354349.502op/s 22410777.848op/s 1.04% 0.169 -0.353 0.36% 5599.703op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.027µs 6.035µs ± 0.004µs 6.034µs ± 0.002µs 6.037µs 6.044µs 6.047µs 6.048µs 0.23% 0.873 0.680 0.07% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 165339804.749op/s 165702142.603op/s ± 116217.173op/s 165714226.817op/s ± 66586.492op/s 165785721.455op/s 165858753.756op/s 165907612.127op/s 165917416.610op/s 0.12% -0.869 0.672 0.07% 8217.795op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.890µs 3.912µs ± 0.003µs 3.912µs ± 0.002µs 3.913µs 3.916µs 3.918µs 3.920µs 0.21% -1.959 17.305 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255108327.257op/s 255637876.891op/s ± 183997.571op/s 255653867.297op/s ± 105318.144op/s 255742939.243op/s 255862379.252op/s 255944891.421op/s 257076386.976op/s 0.56% 1.993 17.597 0.07% 13010.593op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 65.544µs 65.850µs ± 0.079µs 65.860µs ± 0.033µs 65.896µs 65.949µs 65.991µs 66.003µs 0.22% -1.456 2.602 0.12% 0.006µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15150836.980op/s 15186022.200op/s ± 18252.010op/s 15183639.424op/s ± 7589.761op/s 15190550.941op/s 15229558.953op/s 15245990.562op/s 15256979.894op/s 0.48% 1.465 2.626 0.12% 1290.612op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 52.945µs 53.032µs ± 0.039µs 53.033µs ± 0.033µs 53.063µs 53.092µs 53.106µs 53.158µs 0.24% 0.110 -0.597 0.07% 0.003µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 18811757.806op/s 18856400.524op/s ± 13778.720op/s 18856264.782op/s ± 11563.184op/s 18868352.114op/s 18876735.181op/s 18882737.422op/s 18887568.203op/s 0.17% -0.107 -0.600 0.07% 974.303op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.891µs 3.913µs ± 0.003µs 3.913µs ± 0.002µs 3.915µs 3.917µs 3.919µs 3.920µs 0.19% -1.462 10.350 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 255103466.055op/s 255580965.007op/s ± 198487.245op/s 255581895.610op/s ± 131678.414op/s 255712063.218op/s 255835766.932op/s 255911516.500op/s 256970642.737op/s 0.54% 1.486 10.541 0.08% 14035.168op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 49.739µs 49.796µs ± 0.030µs 49.791µs ± 0.019µs 49.813µs 49.854µs 49.886µs 49.903µs 0.23% 0.836 0.686 0.06% 0.002µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 20038819.480op/s 20081859.212op/s ± 12261.208op/s 20083937.871op/s ± 7683.923op/s 20090643.787op/s 20097582.865op/s 20102752.954op/s 20104919.674op/s 0.10% -0.832 0.678 0.06% 866.998op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 44.516µs 45.098µs ± 0.161µs 45.110µs ± 0.110µs 45.219µs 45.342µs 45.406µs 45.442µs 0.74% -0.495 0.349 0.36% 0.011µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 22006023.505op/s 22174427.296op/s ± 79067.290op/s 22168152.128op/s ± 53910.053op/s 22225264.572op/s 22316431.851op/s 22368528.278op/s 22463630.926op/s 1.33% 0.517 0.393 0.36% 5590.902op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.027µs 6.035µs ± 0.004µs 6.035µs ± 0.003µs 6.038µs 6.042µs 6.045µs 6.048µs 0.22% 0.631 0.521 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 165349950.505op/s 165693507.382op/s ± 99066.176op/s 165706102.644op/s ± 69867.188op/s 165768582.713op/s 165829177.644op/s 165871637.651op/s 165923845.558op/s 0.13% -0.627 0.512 0.06% 7005.036op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.912µs; 3.913µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ throughput [255572533.703op/s; 255624153.636op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [79.256µs; 79.542µs] or [-0.180%; +0.180%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12574147.662op/s; 12619392.389op/s] or [-0.180%; +0.180%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [70.927µs; 71.017µs] or [-0.063%; +0.063%] None None None
credit_card/is_card_number/ 378282246310005 throughput [14081500.712op/s; 14099200.700op/s] or [-0.063%; +0.063%] None None None
credit_card/is_card_number/37828224631 execution_time [3.911µs; 3.912µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/37828224631 throughput [255616079.432op/s; 255671665.111op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/378282246310005 execution_time [67.654µs; 67.731µs] or [-0.056%; +0.056%] None None None
credit_card/is_card_number/378282246310005 throughput [14764684.407op/s; 14781155.954op/s] or [-0.056%; +0.056%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [45.063µs; 45.108µs] or [-0.049%; +0.049%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [22169518.003op/s; 22191468.438op/s] or [-0.049%; +0.049%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.034µs; 6.036µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/x371413321323331 throughput [165686036.020op/s; 165718249.185op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.911µs; 3.912µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [255612376.597op/s; 255663377.185op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [65.839µs; 65.861µs] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15183492.647op/s; 15188551.753op/s] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [53.027µs; 53.038µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [18854490.926op/s; 18858310.122op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.912µs; 3.913µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255553456.584op/s; 255608473.430op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [49.792µs; 49.800µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [20080159.927op/s; 20083558.498op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [45.075µs; 45.120µs] or [-0.049%; +0.049%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [22163469.330op/s; 22185385.262op/s] or [-0.049%; +0.049%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.035µs; 6.036µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165679777.763op/s; 165707237.001op/s] or [-0.008%; +0.008%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 033e544 1766104814 levi/harden-profile-status
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 60.936ms 61.386ms ± 2.343ms 61.080ms ± 0.053ms 61.138ms 61.273ms 75.836ms 83.304ms 36.39% 8.252 67.738 3.81% 0.166ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [61.061ms; 61.711ms] or [-0.529%; +0.529%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 033e544 1766104814 levi/harden-profile-status
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.178µs 3.209µs ± 1.408µs 3.000µs ± 0.024µs 3.021µs 3.727µs 13.889µs 14.734µs 391.07% 7.295 54.628 43.75% 0.100µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.014µs; 3.404µs] or [-6.079%; +6.079%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 033e544 1766104814 levi/harden-profile-status
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.944µs 5.033µs ± 0.049µs 5.034µs ± 0.048µs 5.074µs 5.099µs 5.103µs 5.104µs 1.38% -0.068 -1.341 0.96% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.026µs; 5.040µs] or [-0.134%; +0.134%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 033e544 1766104814 levi/harden-profile-status
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.554µs 25.183µs ± 9.910µs 17.861µs ± 0.198µs 33.844µs 43.300µs 50.314µs 60.184µs 236.95% 1.000 0.045 39.25% 0.701µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [23.810µs; 26.556µs] or [-5.454%; +5.454%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 033e544 1766104814 levi/harden-profile-status
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 204.281µs 205.081µs ± 0.510µs 204.965µs ± 0.264µs 205.286µs 205.983µs 206.505µs 208.142µs 1.55% 1.707 6.165 0.25% 0.036µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4804421.730op/s 4876143.643op/s ± 12065.144op/s 4878872.111op/s ± 6274.088op/s 4884194.108op/s 4891886.467op/s 4893446.564op/s 4895215.919op/s 0.33% -1.669 5.899 0.25% 853.134op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.568µs 18.634µs ± 0.057µs 18.617µs ± 0.016µs 18.648µs 18.751µs 18.815µs 19.066µs 2.41% 3.349 17.451 0.30% 0.004µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 52448593.711op/s 53665784.465op/s ± 161777.989op/s 53714664.995op/s ± 47167.947op/s 53754103.449op/s 53806751.276op/s 53830261.216op/s 53855359.110op/s 0.26% -3.276 16.658 0.30% 11439.431op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.723µs 10.834µs ± 0.055µs 10.824µs ± 0.038µs 10.871µs 10.927µs 11.001µs 11.009µs 1.70% 0.627 0.335 0.51% 0.004µs 1 200
normalization/normalize_name/normalize_name/good throughput 90837585.917op/s 92301176.664op/s ± 467590.635op/s 92383086.239op/s ± 326710.707op/s 92663892.996op/s 92968859.403op/s 93117685.905op/s 93256877.152op/s 0.95% -0.598 0.274 0.51% 33063.651op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [205.011µs; 205.152µs] or [-0.034%; +0.034%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4874471.530op/s; 4877815.756op/s] or [-0.034%; +0.034%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.626µs; 18.642µs] or [-0.042%; +0.042%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [53643363.592op/s; 53688205.339op/s] or [-0.042%; +0.042%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.827µs; 10.842µs] or [-0.070%; +0.070%] None None None
normalization/normalize_name/normalize_name/good throughput [92236373.099op/s; 92365980.229op/s] or [-0.070%; +0.070%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 033e544 1766104814 levi/harden-profile-status
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 10.771ms 10.802ms ± 0.014ms 10.801ms ± 0.009ms 10.811ms 10.825ms 10.838ms 10.872ms 0.66% 0.820 2.388 0.13% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [10.800ms; 10.804ms] or [-0.018%; +0.018%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 033e544 1766104814 levi/harden-profile-status
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2597 execution_time 9.671ms 9.966ms ± 0.072ms 9.970ms ± 0.035ms 10.006ms 10.080ms 10.147ms 10.157ms 1.87% -0.759 2.726 0.72% 0.005ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2597 execution_time [9.956ms; 9.976ms] or [-0.101%; +0.101%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 033e544 1766104814 levi/harden-profile-status
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample2_frames_x1000 execution_time 526.777µs 527.412µs ± 0.348µs 527.337µs ± 0.194µs 527.592µs 528.000µs 528.397µs 529.374µs 0.39% 1.650 5.441 0.07% 0.025µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample2_frames_x1000 execution_time [527.364µs; 527.460µs] or [-0.009%; +0.009%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 033e544 1766104814 levi/harden-profile-status
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample_frames_x1000 execution_time 3.922ms 3.927ms ± 0.008ms 3.925ms ± 0.001ms 3.927ms 3.932ms 3.942ms 4.022ms 2.46% 10.215 123.947 0.19% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample_frames_x1000 execution_time [3.926ms; 3.928ms] or [-0.027%; +0.027%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 033e544 1766104814 levi/harden-profile-status
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 533.924µs 534.815µs ± 0.645µs 534.695µs ± 0.259µs 534.964µs 535.884µs 537.224µs 539.405µs 0.88% 3.079 14.601 0.12% 0.046µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1853894.165op/s 1869809.368op/s ± 2248.052op/s 1870225.493op/s ± 907.899op/s 1871119.697op/s 1871973.322op/s 1872474.169op/s 1872924.497op/s 0.14% -3.054 14.364 0.12% 158.961op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 380.049µs 380.752µs ± 0.335µs 380.697µs ± 0.214µs 380.932µs 381.370µs 381.723µs 381.967µs 0.33% 0.916 0.801 0.09% 0.024µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2618024.828op/s 2626381.275op/s ± 2307.863op/s 2626759.566op/s ± 1479.118op/s 2628144.618op/s 2629285.152op/s 2630054.190op/s 2631236.646op/s 0.17% -0.911 0.787 0.09% 163.191op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 190.021µs 190.548µs ± 0.238µs 190.548µs ± 0.180µs 190.738µs 190.911µs 191.088µs 191.159µs 0.32% 0.019 -0.603 0.12% 0.017µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5231257.110op/s 5248023.797op/s ± 6548.699op/s 5248022.204op/s ± 4970.931op/s 5252751.987op/s 5258315.029op/s 5261829.897op/s 5262582.633op/s 0.28% -0.014 -0.605 0.12% 463.063op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.061µs 37.243µs ± 0.071µs 37.249µs ± 0.053µs 37.298µs 37.345µs 37.364µs 37.379µs 0.35% -0.440 -0.417 0.19% 0.005µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26753131.078op/s 26850814.634op/s ± 51191.626op/s 26846248.241op/s ± 38438.725op/s 26887311.137op/s 26938896.861op/s 26975397.673op/s 26982402.788op/s 0.51% 0.448 -0.407 0.19% 3619.795op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 45.805µs 45.899µs ± 0.106µs 45.895µs ± 0.026µs 45.919µs 45.949µs 45.978µs 47.293µs 3.05% 11.531 149.876 0.23% 0.007µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21144902.493op/s 21786979.981op/s ± 48864.758op/s 21788839.515op/s ± 12317.161op/s 21802057.545op/s 21820130.025op/s 21828147.523op/s 21831894.894op/s 0.20% -11.400 147.603 0.22% 3455.260op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [534.725µs; 534.904µs] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1869497.809op/s; 1870120.926op/s] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [380.706µs; 380.799µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2626061.428op/s; 2626701.123op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [190.515µs; 190.581µs] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5247116.211op/s; 5248931.384op/s] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.233µs; 37.253µs] or [-0.026%; +0.026%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26843719.967op/s; 26857909.301op/s] or [-0.026%; +0.026%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [45.885µs; 45.914µs] or [-0.032%; +0.032%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21780207.795op/s; 21793752.166op/s] or [-0.031%; +0.031%] None None None

Group 16

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 033e544 1766104814 levi/harden-profile-status
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.109µs 33.704µs ± 1.005µs 33.232µs ± 0.081µs 33.461µs 35.770µs 35.832µs 38.292µs 15.23% 1.856 2.255 2.97% 0.071µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.565µs; 33.844µs] or [-0.413%; +0.413%] None None None

Group 17

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 033e544 1766104814 levi/harden-profile-status
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 161.976µs 162.554µs ± 0.718µs 162.430µs ± 0.141µs 162.615µs 163.033µs 164.422µs 171.159µs 5.37% 9.215 103.178 0.44% 0.051µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [162.455µs; 162.654µs] or [-0.061%; +0.061%] None None None

Group 18

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 033e544 1766104814 levi/harden-profile-status
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 13.882ms 13.922ms ± 0.039ms 13.909ms ± 0.012ms 13.922ms 14.009ms 14.026ms 14.117ms 1.49% 1.991 4.016 0.28% 0.003ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [13.917ms; 13.928ms] or [-0.039%; +0.039%] None None None

Group 19

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 033e544 1766104814 levi/harden-profile-status
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 89.174µs 89.512µs ± 0.193µs 89.495µs ± 0.105µs 89.600µs 89.748µs 89.892µs 91.374µs 2.10% 4.568 41.436 0.22% 0.014µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [89.485µs; 89.539µs] or [-0.030%; +0.030%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2025

Codecov Report

❌ Patch coverage is 38.88889% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.42%. Comparing base (5974f2e) to head (033e544).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1419      +/-   ##
==========================================
- Coverage   71.51%   71.42%   -0.10%     
==========================================
  Files         411      411              
  Lines       66083    66028      -55     
==========================================
- Hits        47260    47161      -99     
- Misses      18823    18867      +44
Components Coverage Δ
libdd-crashtracker 58.70% <ø> (+0.06%) ⬆️
libdd-crashtracker-ffi 14.72% <ø> (ø)
libdd-alloc 98.73% <ø> (ø)
libdd-data-pipeline 85.66% <ø> (ø)
libdd-data-pipeline-ffi 75.75% <ø> (ø)
libdd-common 81.33% <ø> (ø)
libdd-common-ffi 74.96% <ø> (ø)
libdd-telemetry 59.92% <ø> (-0.04%) ⬇️
libdd-telemetry-ffi 21.17% <ø> (ø)
libdd-dogstatsd-client 83.75% <ø> (ø)
datadog-ipc 82.71% <ø> (ø)
libdd-profiling 81.72% <38.88%> (-0.62%) ⬇️
libdd-profiling-ffi 67.83% <38.88%> (-3.17%) ⬇️
datadog-sidecar 36.17% <ø> (ø)
datdog-sidecar-ffi 12.37% <ø> (ø)
spawn-worker 55.18% <ø> (ø)
libdd-tinybytes 92.44% <ø> (ø)
libdd-trace-normalization 82.33% <ø> (ø)
libdd-trace-obfuscation 94.17% <ø> (ø)
libdd-trace-protobuf 61.18% <ø> (ø)
libdd-trace-utils 90.07% <ø> (ø)
datadog-tracer-flare 61.06% <ø> (ø)
libdd-log 75.57% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@morrisonlevi morrisonlevi marked this pull request as ready for review December 19, 2025 01:23
@morrisonlevi morrisonlevi requested a review from a team as a code owner December 19, 2025 01:23
@dd-octo-sts
Copy link

dd-octo-sts bot commented Dec 19, 2025

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 87.06 MB 87.06 MB +0% (+2.91 KB) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.50 MB 7.50 MB 0% (0 B) 👌
aarch64-apple-darwin
Artifact Baseline Commit Change
/aarch64-apple-darwin/lib/libdatadog_profiling.a 58.87 MB 58.87 MB +0% (+1.88 KB) 👌
/aarch64-apple-darwin/lib/libdatadog_profiling.dylib 8.49 MB 8.49 MB +0% (+48 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 100.73 MB 100.73 MB +0% (+3.03 KB) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.62 MB 9.62 MB +0% (+120 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 20.06 MB 20.06 MB +.01% (+2.50 KB) 🔍
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 74.31 KB 74.31 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 142.05 MB 142.05 MB +0% (+8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 748.19 MB 748.21 MB +0% (+24.29 KB) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 6.40 MB 6.41 MB +0% (+512 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 74.31 KB 74.31 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 19.90 MB 19.90 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 38.99 MB 38.99 MB +0% (+2.29 KB) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 17.12 MB 17.12 MB +.01% (+2.00 KB) 🔍
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 75.46 KB 75.46 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 144.70 MB 144.71 MB +0% (+8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 736.83 MB 736.85 MB +0% (+24.68 KB) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 4.92 MB 4.92 MB +0% (+512 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 75.46 KB 75.46 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 21.16 MB 21.17 MB +.03% (+8.00 KB) 🔍
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 36.77 MB 36.77 MB +0% (+2.13 KB) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 75.34 MB 75.34 MB +0% (+2.46 KB) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.93 MB 8.93 MB 0% (0 B) 👌
x86_64-apple-darwin
Artifact Baseline Commit Change
/x86_64-apple-darwin/lib/libdatadog_profiling.a 60.20 MB 60.20 MB +0% (+1.60 KB) 👌
/x86_64-apple-darwin/lib/libdatadog_profiling.dylib 9.54 MB 9.54 MB +0% (+40 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 94.90 MB 94.90 MB +0% (+2.80 KB) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.35 MB 10.35 MB +0% (+40 B) 👌

@gyuheon0h
Copy link
Contributor

gyuheon0h commented Dec 19, 2025

LGTM!

@gyuheon0h
Copy link
Contributor

gyuheon0h commented Dec 19, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Dec 19, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-12-19 04:48:18 UTC ℹ️ Start processing command /merge

2025-12-19 04:48:22 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 27m (p90).

2025-12-19 05:11:50 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 5027515 into main Dec 19, 2025
38 of 39 checks passed
@dd-mergequeue dd-mergequeue bot deleted the levi/harden-profile-status branch December 19, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gyuheon0h gyuheon0h gyuheon0h approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@morrisonlevi @codecov-commenter @gyuheon0h