Skip to content

[SVLS-8217] feat(trace-stats): Allow custom buffer length #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lym953 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[SVLS-8217] feat(trace-stats): Allow custom buffer length #1424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84f08ad
Support custom buffer len for trace stats concentrator
lym953 Dec 13, 2025
57470f8
Update doc
lym953 Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libdd-trace-stats/benches/span_concentrator_bench.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ pub fn criterion_benchmark(c: &mut Criterion) {
now,
vec![],
vec!["db_name".into(), "bucket_s3".into()],
2,
);
let mut spans = vec![];
for trace_id in 1..100 {
Expand Down
4 changes: 3 additions & 1 deletion libdd-trace-stats/src/span_concentrator/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,13 @@ impl SpanConcentrator {
/// - `now` the current system time, used to define the oldest bucket
/// - `span_kinds_stats_computed` list of span kinds eligible for stats computation
/// - `peer_tags_keys` list of keys considered as peer tags for aggregation
/// - `buffer_len` number of buckets to keep when flushing
pub fn new(
bucket_size: Duration,
now: SystemTime,
span_kinds_stats_computed: Vec<String>,
peer_tag_keys: Vec<String>,
buffer_len: usize,
) -> SpanConcentrator {
SpanConcentrator {
bucket_size: bucket_size.as_nanos() as u64,
Expand All @@ -87,7 +89,7 @@ impl SpanConcentrator {
system_time_to_unix_duration(now).as_nanos() as u64,
bucket_size.as_nanos() as u64,
),
buffer_len: 2,
buffer_len,
span_kinds_stats_computed,
peer_tag_keys,
}
Expand Down
14 changes: 10 additions & 4 deletions libdd-trace-stats/src/span_concentrator/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ fn assert_counts_equal(expected: Vec<pb::ClientGroupedStats>, actual: Vec<pb::Cl
fn test_concentrator_oldest_timestamp_cold() {
let now = SystemTime::now();
let mut concentrator =
SpanConcentrator::new(Duration::from_nanos(BUCKET_SIZE), now, vec![], vec![]);
SpanConcentrator::new(Duration::from_nanos(BUCKET_SIZE), now, vec![], vec![], 2);
let mut spans = vec![
get_test_span(now, 1, 0, 50, 5, "A1", "resource1", 0),
get_test_span(now, 1, 0, 40, 4, "A1", "resource1", 0),
Expand Down Expand Up @@ -150,7 +150,7 @@ fn test_concentrator_oldest_timestamp_cold() {
fn test_concentrator_oldest_timestamp_hot() {
let now = SystemTime::now();
let mut concentrator =
SpanConcentrator::new(Duration::from_nanos(BUCKET_SIZE), now, vec![], vec![]);
SpanConcentrator::new(Duration::from_nanos(BUCKET_SIZE), now, vec![], vec![], 2);
let mut spans = vec![
get_test_span(now, 1, 0, 50, 5, "A1", "resource1", 0),
get_test_span(now, 1, 0, 40, 4, "A1", "resource1", 0),
Expand Down Expand Up @@ -223,7 +223,7 @@ fn test_concentrator_oldest_timestamp_hot() {
fn test_concentrator_stats_totals() {
let now = SystemTime::now();
let mut concentrator =
SpanConcentrator::new(Duration::from_nanos(BUCKET_SIZE), now, vec![], vec![]);
SpanConcentrator::new(Duration::from_nanos(BUCKET_SIZE), now, vec![], vec![], 2);
let aligned_now = align_timestamp(
system_time_to_unix_duration(now).as_nanos() as u64,
concentrator.bucket_size,
Expand Down Expand Up @@ -283,7 +283,7 @@ fn test_concentrator_stats_totals() {
fn test_concentrator_stats_counts() {
let now = SystemTime::now();
let mut concentrator =
SpanConcentrator::new(Duration::from_nanos(BUCKET_SIZE), now, vec![], vec![]);
SpanConcentrator::new(Duration::from_nanos(BUCKET_SIZE), now, vec![], vec![], 2);
let aligned_now = align_timestamp(
system_time_to_unix_duration(now).as_nanos() as u64,
concentrator.bucket_size,
Expand Down Expand Up @@ -578,6 +578,7 @@ fn test_span_should_be_included_in_stats() {
now,
get_span_kinds(),
vec![],
2,
);
for span in &spans {
concentrator.add_span(span);
Expand Down Expand Up @@ -656,6 +657,7 @@ fn test_ignore_partial_spans() {
now,
get_span_kinds(),
vec![],
2,
);
for span in &spans {
concentrator.add_span(span);
Expand All @@ -679,6 +681,7 @@ fn test_force_flush() {
now,
get_span_kinds(),
vec![],
2,
);
for span in &spans {
concentrator.add_span(span);
Expand Down Expand Up @@ -760,12 +763,14 @@ fn test_peer_tags_aggregation() {
now,
get_span_kinds(),
vec![],
2,
);
let mut concentrator_with_peer_tags = SpanConcentrator::new(
Duration::from_nanos(BUCKET_SIZE),
now,
get_span_kinds(),
vec!["db.instance".to_string(), "db.system".to_string()],
2,
);
for span in &spans {
concentrator_without_peer_tags.add_span(span);
Expand Down Expand Up @@ -1014,6 +1019,7 @@ fn test_pb_span() {
now,
get_span_kinds(),
vec!["db.instance".to_string(), "db.system".to_string()],
2,
);
let aligned_now = align_timestamp(
system_time_to_unix_duration(now).as_nanos() as u64,
Expand Down
Loading