-
Notifications
You must be signed in to change notification settings - Fork 16
[WIP][crashtracking] Add minimal LD preload test for crashtracker collector #1428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1428 +/- ##
==========================================
- Coverage 71.41% 71.37% -0.04%
==========================================
Files 411 412 +1
Lines 66047 66094 +47
==========================================
+ Hits 47168 47177 +9
- Misses 18879 18917 +38
🚀 New features to boost your workflow:
|
BenchmarksComparisonBenchmark execution time: 2026-01-06 16:02:24 Comparing candidate commit 5d2087f in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-apple-darwin
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-apple-darwin
x86_64-unknown-linux-gnu
|
c9a32e0 to
5d2087f
Compare
| } | ||
|
|
||
| void *ptr = real_malloc(size); | ||
| log_line("malloc", size, ptr); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be a global atomic that controls whether to log, enabled when the signal handler is active disabled otherwise?

What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.