Skip to content

chore(crashtracking): cfg child helper function with the same conditions as its parent test_crasht_tracking_validate_callstack #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dd-mergequeue merged 1 commit into from
Jan 6, 2026
Merged

chore(crashtracking): cfg child helper function with the same conditions as its parent test_crasht_tracking_validate_callstack #1431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions bin_tests/tests/crashtracker_bin_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,13 +299,17 @@ fn test_crash_tracking_errors_intake_uds_socket() {
// This test is disabled for now on x86_64 musl and macos
// It seems that on aarch64 musl, libc has CFI which allows
// unwinding passed the signal frame.
// Don't forget to update the ignore condition for this and also
// `test_crash_tracking_callstack` when this is revisited.
#[test]
#[cfg(not(any(all(target_arch = "x86_64", target_env = "musl"), target_os = "macos")))]
#[cfg_attr(miri, ignore)]
fn test_crasht_tracking_validate_callstack() {
test_crash_tracking_callstack()
}

// This test is disabled for now on x86_64 musl and macos for the reason mentioned above.
#[cfg(not(any(all(target_arch = "x86_64", target_env = "musl"), target_os = "macos")))]
fn test_crash_tracking_callstack() {
use bin_tests::test_runner::run_custom_crash_test;

Expand Down
Loading