-
Notifications
You must be signed in to change notification settings - Fork 16
feat(serverless): [SLES-2652] Log error details when trace request fails (2) #1441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
lgtm; theres a new PR title lint rule where titles need to be in the format of something like: |
BenchmarksComparisonBenchmark execution time: 2026-01-12 20:10:20 Comparing candidate commit 6acb83c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1441 +/- ##
==========================================
+ Coverage 71.29% 71.33% +0.03%
==========================================
Files 413 413
Lines 66148 66148
==========================================
+ Hits 47159 47184 +25
+ Misses 18989 18964 -25
🚀 New features to boost your workflow:
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
## Overview Upgrade libdatadog, mainly to patch DataDog/libdatadog#1441 to add logging to network errors to help debug support tickets. ## Testing None
What does this PR do?
When the request to send traces fails, log more details of the error.
Motivation
This is similar to #1392. That PR only touched the debug-level log, so error details are not shown if log level is
warn, causing difficulty in debugging support tickets such as SLES-2652. This PR add details to the error-level log message as well.Additional Notes
How to test the change?
Not tested. Should be safe.