Skip to content

ci: make semver-check takes precedence over public api #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 1 commit into from
Feb 10, 2026
Merged

ci: make semver-check takes precedence over public api #1546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions scripts/semver-level.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,13 +112,10 @@ compute_semver_results() {
fi
fi

# Check for changed items (major change)
if echo "$PUBLIC_API_OUTPUT" | grep -q "^Changed items in the public API$"; then
if ! echo "$PUBLIC_API_OUTPUT" | grep -A 2 "^Changed items in the public API$" | grep -q "^(none)$"; then
LEVEL="major"
log_verbose "Detected changed items (major change)" >&2
fi
fi
# TODO: Improve parsing changed items with an allowlist. Right now is not working because there is some occasions
# in which changed items are not a breaking change. Examples:
# - Adding #[repr(c)] is not a breaking change (https://doc.rust-lang.org/cargo/reference/semver.html#repr-c-add).
# - Removing #[repr(c)] is a breaking change.

# Check for added items (minor change) - only if not already major
if [[ "$LEVEL" != "major" ]]; then
Expand Down
Loading