[python_basic_memory] Add first memory correctness check #79
+104
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
This is our first Memory Profiling correctness check for Python! 🚀
The goal is both to validate that what we report is correct and that the Memory Profiling feature continues to work over time – which we've been somewhat blind to lately.
Questions
The numbers don't make sense to me. Here is a profile I captured, I think the memory should be roughly ~75% and ~25% (since I allocate
bytearray(1024)on one side andbytearray(3 * 1024)on the other) but for some reason we're getting 60% and 40% which sounds more likebytearray(2 * 1024)for the second allocation.One possible explanation is that the
bytearrayoverhead might be significant enough to bias the numbers but that would be sort of huge. According to my research, thePyObjectoverhead should be roughly 60 bytes, so far from enough to explain skewing the results so much...