Skip to content

[AGENTONB-2490] Support remote_updates through embedded installer#864

Closed
tbavelier wants to merge 7 commits intomainfrom
tbavelier/agentonb-2490-puppet
Closed

[AGENTONB-2490] Support remote_updates through embedded installer#864
tbavelier wants to merge 7 commits intomainfrom
tbavelier/agentonb-2490-puppet

Conversation

@tbavelier
Copy link
Member

@tbavelier tbavelier commented Sep 1, 2025

What does this PR do?

  • Stops managing Agent through deprecated installer and moves installer steps to the end (ensure it is done after Agent installation if there's one to avoid doing 2 keys installation on Ubuntu) c21e93c
  • Adds a new fact to check if an upgrade is running (datadog-agent-exp service), and if yes, moves ensure running (i.e. Puppet restarts the Agent service) to stopped to avoid interfering with the remote upgrade
    • Once the upgrade is over, at the next Puppet runs, we get back to the original state with running (as the fact will not be true): 91a5eee and c1f5c3a

Motivation

Additional Notes

Describe your test plan

  • Unit/kitchen tests to ensure default behaviour is not changed
  • Manually tested with VMs the following flow:
    1. Agent is installed with remote_updates, service is started
    2. Upgrade is started, Agent is not re-started despite service being dead
    3. Did a config change (datadog.yaml), and ensured Puppet did not restart Agent service
    4. Upgrade is finished, manually stopped Agent service and ensured Puppet did restart it (ensure => running)

@tbavelier tbavelier closed this Sep 2, 2025
@tbavelier tbavelier deleted the tbavelier/agentonb-2490-puppet branch September 2, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant