-
Notifications
You must be signed in to change notification settings - Fork 8
fix make file #1122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix make file #1122
Conversation
Binary Size Analysis (Agent Data Plane)Target: 85eb93a (baseline) vs df7ebf5 (comparison) diff
|
| Module | File Size | Symbols |
|---|---|---|
| anon.6963da505859e1c5d18d13cd64b99327.1.llvm.14730529422364632719 | +130 B | 1 |
| anon.6963da505859e1c5d18d13cd64b99327.1.llvm.4946000044969667943 | -129 B | 1 |
| anon.6963da505859e1c5d18d13cd64b99327.4.llvm.14730529422364632719 | +115 B | 1 |
| anon.6963da505859e1c5d18d13cd64b99327.4.llvm.4946000044969667943 | -114 B | 1 |
| anon.6963da505859e1c5d18d13cd64b99327.3.llvm.14730529422364632719 | +109 B | 1 |
| anon.6963da505859e1c5d18d13cd64b99327.3.llvm.4946000044969667943 | -108 B | 1 |
| anon.6963da505859e1c5d18d13cd64b99327.0.llvm.14730529422364632719 | +97 B | 1 |
| anon.6963da505859e1c5d18d13cd64b99327.0.llvm.4946000044969667943 | -96 B | 1 |
| anon.6963da505859e1c5d18d13cd64b99327.2.llvm.14730529422364632719 | +95 B | 1 |
| anon.6963da505859e1c5d18d13cd64b99327.2.llvm.4946000044969667943 | -94 B | 1 |
| [Unmapped] | +3 B | 1 |
Detailed Symbol Changes
FILE SIZE VM SIZE
-------------- --------------
[NEW] +130 [NEW] +40 anon.6963da505859e1c5d18d13cd64b99327.1.llvm.14730529422364632719
[NEW] +115 [NEW] +25 anon.6963da505859e1c5d18d13cd64b99327.4.llvm.14730529422364632719
[NEW] +109 [NEW] +19 anon.6963da505859e1c5d18d13cd64b99327.3.llvm.14730529422364632719
[NEW] +97 [NEW] +7 anon.6963da505859e1c5d18d13cd64b99327.0.llvm.14730529422364632719
[NEW] +95 [NEW] +5 anon.6963da505859e1c5d18d13cd64b99327.2.llvm.14730529422364632719
+0.0% +3 [ = ] 0 [Unmapped]
[DEL] -94 [DEL] -5 anon.6963da505859e1c5d18d13cd64b99327.2.llvm.4946000044969667943
[DEL] -96 [DEL] -7 anon.6963da505859e1c5d18d13cd64b99327.0.llvm.4946000044969667943
[DEL] -108 [DEL] -19 anon.6963da505859e1c5d18d13cd64b99327.3.llvm.4946000044969667943
[DEL] -114 [DEL] -25 anon.6963da505859e1c5d18d13cd64b99327.4.llvm.4946000044969667943
[DEL] -129 [DEL] -40 anon.6963da505859e1c5d18d13cd64b99327.1.llvm.4946000044969667943
+0.0% +8 [ = ] 0 TOTAL
Regression Detector (Agent Data Plane)Regression Detector ResultsRun ID: cf575dba-3497-4923-8982-d02f51d70b07 Baseline: 85eb93a Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | dsd_uds_500mb_3k_contexts_throughput | ingress throughput | +1.78 | [+1.64, +1.91] | 1 | (metrics) (profiles) (logs) |
| ➖ | otlp_ingest_metrics_adp | memory utilization | +1.50 | [+1.35, +1.66] | 1 | |
| ➖ | otlp_ingest_logs_adp | memory utilization | +0.80 | [+0.42, +1.19] | 1 | (metrics) (profiles) (logs) |
| ➖ | quality_gates_rss_dsd_heavy | memory utilization | +0.18 | [+0.04, +0.31] | 1 | (metrics) (profiles) (logs) |
| ➖ | quality_gates_rss_dsd_medium | memory utilization | +0.01 | [-0.16, +0.17] | 1 | (metrics) (profiles) (logs) |
| ➖ | dsd_uds_100mb_3k_contexts_throughput | ingress throughput | +0.00 | [-0.02, +0.02] | 1 | (metrics) (profiles) (logs) |
| ➖ | dsd_uds_1mb_3k_contexts_throughput | ingress throughput | +0.00 | [-0.05, +0.06] | 1 | (metrics) (profiles) (logs) |
| ➖ | dsd_uds_512kb_3k_contexts_throughput | ingress throughput | -0.00 | [-0.05, +0.05] | 1 | (metrics) (profiles) (logs) |
| ➖ | quality_gates_rss_dsd_ultraheavy | ingress throughput | -0.00 | [-0.08, +0.08] | 1 | (metrics) (profiles) (logs) |
| ➖ | dsd_uds_10mb_3k_contexts_throughput | ingress throughput | -0.01 | [-0.20, +0.17] | 1 | (metrics) (profiles) (logs) |
| ➖ | quality_gates_rss_dsd_low | memory utilization | -0.05 | [-0.18, +0.07] | 1 | (metrics) (profiles) (logs) |
| ➖ | quality_gates_rss_idle | memory utilization | -0.09 | [-0.11, -0.06] | 1 | (metrics) (profiles) (logs) |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | quality_gates_rss_dsd_heavy | memory_usage | 10/10 | (metrics) (profiles) (logs) |
| ✅ | quality_gates_rss_dsd_low | memory_usage | 10/10 | (metrics) (profiles) (logs) |
| ✅ | quality_gates_rss_dsd_medium | memory_usage | 10/10 | (metrics) (profiles) (logs) |
| ✅ | quality_gates_rss_dsd_ultraheavy | memory_usage | 10/10 | (metrics) (profiles) (logs) |
| ✅ | quality_gates_rss_idle | memory_usage | 10/10 | (metrics) (profiles) (logs) |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Summary
make build-adpbuilds with profile devel and creates the binary at:target/devel/agent-data-plane
The run-adp-standalone target in the Makefile expects the binary at:
target/debug/agent-data-plane
Change Type
How did you test this PR?
References