-
Notifications
You must be signed in to change notification settings - Fork 8
Go like Scheduler, NativeCheck, http-check #1165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| pub add_index: usize, | ||
| pub schedule_index: usize, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we doing this weird sharded scheduling bucket logic? If I add a check, having to wait up to interval_secs - 1 for it to start seems... terrible.
Maybe this matches the current Agent behavior, but if so, then I would say it's a poor design that we should not be emulating here short of a very good reason why it's absolutely required.
dd0510b to
b300ace
Compare
4010d8f to
3894fb0
Compare
This reverts commit 3894fb0.
Summary
This PR bundles multiples changes around check execution:
send_to_worker(), we would needsync:mpmcto exactly match the Go one. In the meantime, a pattern similar to what is done in work-stealing queue is used.lib/core-checklibrarySinktraitNativeChecktype to run Rust based check, compiled in Salukiasynccode inrun()http_chunk, not exhaustivechecksandpython-checksChange Type
How did you test this PR?
References