fix(agent-data-plane): allow check config files without `init_config` #1166

Enzu83 · 2026-02-05T14:30:42Z

Summary

This PR allows check configs that don't have init_config explicitly defined. Check configs like these are valid in the Agent, so should be in ADP to keep full compatibility between the Agent and ADP.

Change Type

Bug fix
New feature
Non-functional (chore, refactoring, docs)
Performance

How did you test this PR?

New unit test parsing a config file without init_config

pr-commenter · 2026-02-05T14:48:16Z

Binary Size Analysis (Agent Data Plane)

Target: 98de5fa (baseline) vs 47d7aa7 (comparison) diff
Analysis Type: Stripped binaries (debug symbols excluded)
Baseline Size: 26.95 MiB
Comparison Size: 26.95 MiB
Size Change: -88 B (-0.00%)
Pass/Fail Threshold: +5%
Result: PASSED ✅

Changes by Module

Module	File Size	Symbols
`[Unmapped]`	+633 B	1
`figment`	-540 B	7
`saluki_config::ConfigurationLoader::with_default_secrets_resolution`	-174 B	1
`unicode_segmentation`	+8 B	1
`tokio`	-6 B	1
`std`	-4 B	7
`[sections]`	-3 B	3
`agent_data_plane::internal::remote_agent`	-2 B	1
`saluki_core::data_model::event`	+0 B	4
`hickory_proto`	+0 B	8
`rustls`	+0 B	12
`http`	+0 B	26
`crossbeam_channel`	+0 B	8
`aho_corasick`	+0 B	60
`hashbrown`	+0 B	2
`regex_syntax`	+0 B	2
`aws_lc_rs`	+0 B	6
`h2`	+0 B	18
`core`	+0 B	20
`tonic`	+0 B	2

Detailed Symbol Changes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [NEW] +10.9Ki  [NEW] +10.7Ki    <saluki_core::data_model::event::Event as core::clone::Clone>::clone.10330
  [NEW] +5.52Ki  [NEW] +5.38Ki    <hickory_proto::rr::record_data::RData as core::clone::Clone>::clone.8521
  [NEW] +4.71Ki  [NEW] +4.59Ki    <rustls::error::Error as core::clone::Clone>::clone.10303
  [NEW] +3.84Ki  [NEW] +3.73Ki    <rustls::error::Error as core::clone::Clone>::clone.9760
  [NEW] +3.66Ki  [NEW] +3.54Ki    <rustls::error::Error as core::fmt::Debug>::fmt.9893
  [NEW] +3.55Ki  [NEW] +3.44Ki    <rustls::error::Error as core::fmt::Debug>::fmt.9761
  [NEW] +2.85Ki  [NEW] +2.70Ki    <saluki_core::data_model::event::metric::value::MetricValues as core::clone::Clone>::clone.10331
  [NEW] +2.33Ki  [NEW] +2.22Ki    <figment::error::Kind as core::fmt::Debug>::fmt.10581
  [NEW] +2.20Ki  [NEW] +2.08Ki    <figment::error::Actual as core::fmt::Debug>::fmt.10582
  [NEW] +1.49Ki  [NEW] +1.36Ki    <hickory_proto::rr::rdata::svcb::SVCB as core::clone::Clone>::clone.8523
  -0.0%     -88  -0.1%    -632    [260 Others]
  [DEL] -1.49Ki  [DEL] -1.36Ki    <hickory_proto::rr::rdata::svcb::SVCB as core::clone::Clone>::clone.8525
  [DEL] -2.20Ki  [DEL] -2.08Ki    <figment::error::Actual as core::fmt::Debug>::fmt.10584
  [DEL] -2.33Ki  [DEL] -2.22Ki    <figment::error::Kind as core::fmt::Debug>::fmt.10583
  [DEL] -2.85Ki  [DEL] -2.70Ki    <saluki_core::data_model::event::metric::value::MetricValues as core::clone::Clone>::clone.10333
  [DEL] -3.55Ki  [DEL] -3.44Ki    <rustls::error::Error as core::fmt::Debug>::fmt.9763
  [DEL] -3.66Ki  [DEL] -3.54Ki    <rustls::error::Error as core::fmt::Debug>::fmt.9895
  [DEL] -3.84Ki  [DEL] -3.73Ki    <rustls::error::Error as core::clone::Clone>::clone.9762
  [DEL] -4.71Ki  [DEL] -4.59Ki    <rustls::error::Error as core::clone::Clone>::clone.10305
  [DEL] -5.52Ki  [DEL] -5.38Ki    <hickory_proto::rr::record_data::RData as core::clone::Clone>::clone.8523
  [DEL] -10.9Ki  [DEL] -10.7Ki    <saluki_core::data_model::event::Event as core::clone::Clone>::clone.10332
  -0.0%     -88  -0.0%    -632    TOTAL

tobz · 2026-02-05T14:48:20Z

lib/saluki-env/src/autodiscovery/providers/local.rs


 #[derive(Debug, Deserialize)]
 struct LocalCheckConfig {
+    #[serde(default = "HashMap::new")]


Should just be able to do #[serde(default)] since HashMap<K, V> implements Default.

Fixed, thanks!

pr-commenter · 2026-02-05T15:23:53Z

Regression Detector (Agent Data Plane)

Regression Detector Results

Run ID: 373bcf8f-19ee-457f-ae9e-afb233b68f6a

Baseline: 98de5fa
Comparison: 47d7aa7
Diff

❌ Experiments with retried target crashes

This is a critical error. One or more replicates failed with a non-zero exit code. These replicates may have been retried. See Replicate Execution Details for more information.

otlp_ingest_logs_5mb_cpu
quality_gates_rss_dsd_heavy
otlp_ingest_traces_5mb_cpu
otlp_ingest_metrics_5mb_memory
otlp_ingest_logs_5mb_throughput

Optimization Goals: ❌ Regression(s) detected

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
❌	otlp_ingest_metrics_5mb_memory	memory utilization	+7.10	[+6.88, +7.31]	1	(metrics) (profiles) (logs)

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	otlp_ingest_logs_5mb_cpu	% cpu utilization	+0.69	[-4.50, +5.88]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_logs_5mb_throughput	ingress throughput	-0.02	[-0.14, +0.11]	1	(metrics) (profiles) (logs)
✅	otlp_ingest_logs_5mb_memory	memory utilization	-5.11	[-5.60, -4.62]	1	(metrics) (profiles) (logs)

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
❌	otlp_ingest_metrics_5mb_memory	memory utilization	+7.10	[+6.88, +7.31]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_traces_5mb_cpu	% cpu utilization	+2.13	[-0.63, +4.90]	1	(metrics) (profiles) (logs)
➖	dsd_uds_10mb_3k_contexts_cpu	% cpu utilization	+1.93	[-28.42, +32.27]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_traces_5mb_memory	memory utilization	+1.52	[+1.26, +1.78]	1	(metrics) (profiles) (logs)
➖	quality_gates_rss_idle	memory utilization	+0.74	[+0.68, +0.80]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_logs_5mb_cpu	% cpu utilization	+0.69	[-4.50, +5.88]	1	(metrics) (profiles) (logs)
➖	dsd_uds_500mb_3k_contexts_throughput	ingress throughput	+0.65	[+0.51, +0.78]	1	(metrics) (profiles) (logs)
➖	dsd_uds_100mb_3k_contexts_memory	memory utilization	+0.53	[+0.33, +0.73]	1	(metrics) (profiles) (logs)
➖	quality_gates_rss_dsd_low	memory utilization	+0.52	[+0.36, +0.69]	1	(metrics) (profiles) (logs)
➖	dsd_uds_10mb_3k_contexts_memory	memory utilization	+0.29	[+0.09, +0.49]	1	(metrics) (profiles) (logs)
➖	quality_gates_rss_dsd_ultraheavy	memory utilization	+0.21	[+0.08, +0.34]	1	(metrics) (profiles) (logs)
➖	quality_gates_rss_dsd_heavy	memory utilization	+0.18	[+0.05, +0.31]	1	(metrics) (profiles) (logs)
➖	dsd_uds_500mb_3k_contexts_memory	memory utilization	+0.18	[-0.01, +0.37]	1	(metrics) (profiles) (logs)
➖	quality_gates_rss_dsd_medium	memory utilization	+0.07	[-0.13, +0.26]	1	(metrics) (profiles) (logs)
➖	dsd_uds_1mb_3k_contexts_memory	memory utilization	+0.06	[-0.13, +0.25]	1	(metrics) (profiles) (logs)
➖	dsd_uds_512kb_3k_contexts_memory	memory utilization	+0.03	[-0.16, +0.22]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_metrics_5mb_throughput	ingress throughput	+0.02	[-0.11, +0.14]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_traces_5mb_throughput	ingress throughput	+0.00	[-0.08, +0.08]	1	(metrics) (profiles) (logs)
➖	dsd_uds_100mb_3k_contexts_throughput	ingress throughput	-0.00	[-0.06, +0.06]	1	(metrics) (profiles) (logs)
➖	dsd_uds_512kb_3k_contexts_throughput	ingress throughput	-0.00	[-0.06, +0.05]	1	(metrics) (profiles) (logs)
➖	dsd_uds_1mb_3k_contexts_throughput	ingress throughput	-0.00	[-0.06, +0.05]	1	(metrics) (profiles) (logs)
➖	dsd_uds_10mb_3k_contexts_throughput	ingress throughput	-0.01	[-0.17, +0.14]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_logs_5mb_throughput	ingress throughput	-0.02	[-0.14, +0.11]	1	(metrics) (profiles) (logs)
➖	otlp_ingest_metrics_5mb_cpu	% cpu utilization	-0.57	[-6.26, +5.11]	1	(metrics) (profiles) (logs)
➖	dsd_uds_500mb_3k_contexts_cpu	% cpu utilization	-0.80	[-2.05, +0.45]	1	(metrics) (profiles) (logs)
➖	dsd_uds_512kb_3k_contexts_cpu	% cpu utilization	-0.85	[-55.63, +53.93]	1	(metrics) (profiles) (logs)
➖	dsd_uds_100mb_3k_contexts_cpu	% cpu utilization	-2.66	[-8.18, +2.86]	1	(metrics) (profiles) (logs)
✅	otlp_ingest_logs_5mb_memory	memory utilization	-5.11	[-5.60, -4.62]	1	(metrics) (profiles) (logs)
➖	dsd_uds_1mb_3k_contexts_cpu	% cpu utilization	-13.64	[-62.19, +34.92]	1	(metrics) (profiles) (logs)

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	quality_gates_rss_dsd_heavy	memory_usage	10/10	(metrics) (profiles) (logs)
✅	quality_gates_rss_dsd_low	memory_usage	10/10	(metrics) (profiles) (logs)
✅	quality_gates_rss_dsd_medium	memory_usage	10/10	(metrics) (profiles) (logs)
✅	quality_gates_rss_dsd_ultraheavy	memory_usage	10/10	(metrics) (profiles) (logs)
✅	quality_gates_rss_idle	memory_usage	10/10	(metrics) (profiles) (logs)

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment	Variant	Replicates	Failure	Logs	Debug Dashboard
experiment_with_failures	baseline	0 (x8) 1 (x6)	Oom killed		Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Normal Replicate Execution Failures (non-profiling)

Experiment	Variant	Replicates	Failure	Debug Dashboard
otlp_ingest_logs_5mb_cpu	baseline	4	Failed to shutdown when requested	Debug Dashboard
otlp_ingest_logs_5mb_throughput	baseline	8	Failed to shutdown when requested	Debug Dashboard
otlp_ingest_metrics_5mb_memory	comparison	9	Failed to shutdown when requested	Debug Dashboard
otlp_ingest_traces_5mb_cpu	baseline	5	Failed to shutdown when requested	Debug Dashboard
quality_gates_rss_dsd_heavy	baseline	4	Failed to shutdown when requested	Debug Dashboard
quality_gates_rss_dsd_heavy	comparison	4	Failed to shutdown when requested	Debug Dashboard

…it-config

tobz · 2026-02-05T17:21:46Z

/gitlab resync-code

gh-worker-devflow-routing-ef8351 · 2026-02-05T17:21:50Z

View all feedbacks in Devflow UI.

2026-02-05 17:21:50 UTC ℹ️ Start processing command /gitlab resync-code

2026-02-05 17:21:55 UTC ℹ️ Devflow: /gitlab resync-code

resync successful

tobz · 2026-02-05T17:39:56Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-02-05T17:40:00Z

View all feedbacks in Devflow UI.

2026-02-05 17:39:59 UTC ℹ️ Start processing command /merge

2026-02-05 17:40:05 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-02-05 17:42:04 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 25m (p90).

2026-02-05 18:04:15 UTC ℹ️ MergeQueue: This merge request was merged

…#1166) ## Summary  This PR allows check configs that don't have `init_config` explicitly defined. Check configs like these are valid in the Agent, so should be in ADP to keep full compatibility between the Agent and ADP. ## Change Type - [x] Bug fix - [ ] New feature - [ ] Non-functional (chore, refactoring, docs) - [ ] Performance ## How did you test this PR?  New unit test parsing a config file without `init_config` Co-authored-by: tobz <[email protected]> Co-authored-by: toby.lawrence <[email protected]> ba4c142

fix: allow check config yaml files without init_config

1c63a06

dd-octo-sts bot added the area/config Configuration. label Feb 5, 2026

Enzu83 changed the title ~~fix: allow check config files without init_config~~ fix(agent-data-plane): allow check config files without init_config Feb 5, 2026

test: parsing the smallest valid config file for a check

2e1e3c7

Enzu83 force-pushed the maxime.chambre/allow-check-config-without-init-config branch from db5f0e2 to 2e1e3c7 Compare February 5, 2026 14:37

tobz requested changes Feb 5, 2026

View reviewed changes

chore: remove default method percision for init_config

b884507

Enzu83 requested a review from tobz February 5, 2026 15:31

Enzu83 marked this pull request as ready for review February 5, 2026 15:46

Enzu83 requested a review from a team as a code owner February 5, 2026 15:46

tobz approved these changes Feb 5, 2026

View reviewed changes

Merge branch 'main' into maxime.chambre/allow-check-config-without-in…

47d7aa7

…it-config

gh-worker-dd-devflow-36fce6 bot added mergequeue-status: waiting mergequeue-status: queued mergequeue-status: in_progress and removed mergequeue-status: waiting mergequeue-status: queued labels Feb 5, 2026

gh-worker-dd-mergequeue-cf854d bot merged commit ba4c142 into main Feb 5, 2026
57 of 58 checks passed

gh-worker-dd-devflow-36fce6 bot added mergequeue-status: done and removed mergequeue-status: in_progress labels Feb 5, 2026

fix(agent-data-plane): allow check config files without init_config #1166

fix(agent-data-plane): allow check config files without init_config #1166

Uh oh!

Conversation

Enzu83 commented Feb 5, 2026

Summary

Change Type

How did you test this PR?

Uh oh!

pr-commenter bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Binary Size Analysis (Agent Data Plane)

Changes by Module

Detailed Symbol Changes

Uh oh!

tobz Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Enzu83 Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

pr-commenter bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector (Agent Data Plane)

Regression Detector Results

❌ Experiments with retried target crashes

Optimization Goals: ❌ Regression(s) detected

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Replicate Execution Details

❌ Retried Normal Replicate Execution Failures (non-profiling)

Uh oh!

tobz commented Feb 5, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tobz commented Feb 5, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix(agent-data-plane): allow check config files without `init_config` #1166

fix(agent-data-plane): allow check config files without `init_config` #1166

pr-commenter bot commented Feb 5, 2026 •

edited

Loading

pr-commenter bot commented Feb 5, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 bot commented Feb 5, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 bot commented Feb 5, 2026 •

edited

Loading