Draft
Conversation
Collaborator
|
We can't migrate everything in Storedog over to OTel as the default configuration, it would introduce too many breaking changes in all of our labs and no one would ever be able to update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes significant updates to the
docker-compose.yml,services/discounts, andservices/frontendfiles to transition from Datadog instrumentation to OpenTelemetry, simplify configurations, and improve error handling and logging.Transition from Datadog to OpenTelemetry:
services/discounts/Dockerfile: Added OpenTelemetry environment variables (OTEL_SERVICE_NAME,OTEL_TRACES_EXPORTER, etc.) and replacedddtrace-runwithopentelemetry-instrumentin theCMDdirective. [1] [2]services/frontend/Dockerfile: Removed Datadog environment variables (DD_GIT_REPOSITORY_URL,DD_GIT_COMMIT_SHA) and added OpenTelemetry configurations (OTEL_TRACES_EXPORTER,OTEL_EXPORTER_OTLP_ENDPOINT, etc.). Updated theCMDdirective to use OpenTelemetry instrumentation. [1] [2]Removal of Datadog dependencies:
services/discounts/requirements.txt: Removedddtraceand added OpenTelemetry packages (opentelemetry-distro,opentelemetry-exporter-otlp). Updatedprotobufto version4.25.3. [1] [2] [3]services/dbm/requirements.txt: Updatedprotobufto version4.25.3.services/frontend/components/CheckoutSidebarView/CheckoutSidebarView.tsx: Removed Datadog RUM actions and replaced them with console logs for error handling and analytics. [1] [2] [3]Updates to
docker-compose.yml:dd-agentservice and removed its dependencies from other services (frontend,discounts,ads-java,postgres,redis, etc.). [1] [2] [3] [4] [5] [6] [7] [8]Code cleanup and refactoring:
services/discounts/discounts.py: Removed Datadog-specific imports and replacedpatchfunction calls with standard logging configuration. [1] [2]services/frontend/components/ErrorBoundary.tsx: Refactored the ErrorBoundary component to improve error handling and removed Datadog RUM integration.services/frontend/components/CheckoutSidebarView/CheckoutSidebarView.tsx: Enhanced error handling, updated type definitions, and removed Datadog-specific attributes. [1] [2] [3] [4]Addition of OpenTelemetry instrumentation:
services/frontend/instrumentation.ts: Added a commented-out example of OpenTelemetry instrumentation setup for reference.## DescriptionHow to test