Skip to content

[Feature] Add OTel Storedog variant#108

Draft
eddie-rowe wants to merge 7 commits intomainfrom
feature-add-otel-variant
Draft

[Feature] Add OTel Storedog variant#108
eddie-rowe wants to merge 7 commits intomainfrom
feature-add-otel-variant

Conversation

@eddie-rowe
Copy link
Copy Markdown
Contributor

This pull request includes significant updates to the docker-compose.yml, services/discounts, and services/frontend files to transition from Datadog instrumentation to OpenTelemetry, simplify configurations, and improve error handling and logging.

Transition from Datadog to OpenTelemetry:

  • services/discounts/Dockerfile: Added OpenTelemetry environment variables (OTEL_SERVICE_NAME, OTEL_TRACES_EXPORTER, etc.) and replaced ddtrace-run with opentelemetry-instrument in the CMD directive. [1] [2]
  • services/frontend/Dockerfile: Removed Datadog environment variables (DD_GIT_REPOSITORY_URL, DD_GIT_COMMIT_SHA) and added OpenTelemetry configurations (OTEL_TRACES_EXPORTER, OTEL_EXPORTER_OTLP_ENDPOINT, etc.). Updated the CMD directive to use OpenTelemetry instrumentation. [1] [2]

Removal of Datadog dependencies:

Updates to docker-compose.yml:

  • Commented out the dd-agent service and removed its dependencies from other services (frontend, discounts, ads-java, postgres, redis, etc.). [1] [2] [3] [4] [5] [6] [7] [8]

Code cleanup and refactoring:

Addition of OpenTelemetry instrumentation:

How to test

@arosenkranz
Copy link
Copy Markdown
Collaborator

We can't migrate everything in Storedog over to OTel as the default configuration, it would introduce too many breaking changes in all of our labs and no one would ever be able to update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants