Skip to content

Conversation

@manuel-alvarez-alvarez
Copy link
Member

@manuel-alvarez-alvarez manuel-alvarez-alvarez commented Dec 20, 2024

Motivation

In preparation for enabling V3 we have to disable V2 tests first, this is the first PR part of a three way merge:

  1. First disable automated login events V2 tests (this PR)
  2. Add support for for the V3 in the java tracer (PR)
  3. Enable automated login events V3 tests (PR)

Changes

Disables automated login events V2 test suite.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@manuel-alvarez-alvarez manuel-alvarez-alvarez marked this pull request as ready for review December 20, 2024 10:32
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/java-ato-disable-v2 branch from 84984b9 to da4e20a Compare January 2, 2025 08:05
@manuel-alvarez-alvarez manuel-alvarez-alvarez merged commit 7524561 into main Jan 2, 2025
52 checks passed
@manuel-alvarez-alvarez manuel-alvarez-alvarez deleted the malvarez/java-ato-disable-v2 branch January 2, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants