Skip to content

Conversation

mhlidd
Copy link
Contributor

@mhlidd mhlidd commented Aug 14, 2025

Motivation

#5066 broke dd-trace-java master branch since the relevant PR is not merged.

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@mhlidd mhlidd requested review from a team as code owners August 14, 2025 21:33
@mhlidd mhlidd requested review from smola and robertpi August 14, 2025 21:33
@mhlidd mhlidd enabled auto-merge (squash) August 14, 2025 21:35
@mhlidd mhlidd merged commit 496df42 into main Aug 14, 2025
96 checks passed
@mhlidd mhlidd deleted the mhlidd/disable_debugger_tests branch August 14, 2025 21:47
PerfectSlayer added a commit that referenced this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants