Skip to content

Conversation

@tylfin
Copy link
Member

@tylfin tylfin commented Aug 27, 2025

Motivation

This is still in development for Java and Python here:

But we want to have system-tests upfront to ensure it's functioning correctly for Sept releases.

Refs: DEBUG-4399, RFC here.

Changes

  • Introduced the setup_tracing_client_http_header_tags_apm_multiconfig setup method, which prepares three different RC configurations and corresponding requests to test configuration precedence.
  • Added the test_tracing_client_http_header_tags_apm_multiconfig test method to validate that header tags are correctly set or ignored based on configuration priority in the resulting spans.
  • Updated the get_rc_params utility method to accept service_name and env parameters, allowing more flexible RC configuration targeting for the new tests.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@tylfin tylfin force-pushed the tyler.finethy/DEBUG-4399-2 branch 2 times, most recently from 3cd9e4c to f12a8df Compare August 27, 2025 15:02
@tylfin tylfin requested a review from shatzi August 27, 2025 16:46
@tylfin tylfin marked this pull request as ready for review August 27, 2025 16:47
@tylfin tylfin requested a review from a team as a code owner August 27, 2025 16:47
@tylfin tylfin requested review from P403n1x87 and jpbempel August 27, 2025 16:47
@tylfin tylfin force-pushed the tyler.finethy/DEBUG-4399-2 branch from f12a8df to 1a2bb28 Compare August 28, 2025 18:23
This is still in development for Java and Python here:

- DataDog/dd-trace-java#9360
- DataDog/dd-trace-py#14364

But we want to have system-tests upfront to ensure it's functioning correctly for Sept releases.

Refs: DEBUG-4399
@tylfin tylfin force-pushed the tyler.finethy/DEBUG-4399-2 branch from 1a2bb28 to 9bbe37e Compare August 28, 2025 20:16
@tylfin tylfin merged commit b052f72 into main Aug 29, 2025
430 checks passed
@tylfin tylfin deleted the tyler.finethy/DEBUG-4399-2 branch August 29, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants