Skip to content

Fix name extraction when saving dfd files #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kr0nox wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix name extraction when saving dfd files #68

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14cbb39
fix content and name of saved dfd files
Kr0nox Jan 19, 2026
312b114
remove unused parameter
Kr0nox Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions frontend/webEditor/src/serialize/saveDfdAndDdFile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import { LabelTypeRegistry } from "../labels/LabelTypeRegistry";
import { EditorModeController } from "../settings/editorMode";
import { DfdWebSocket } from "../webSocket/webSocket";
import { Action } from "sprotty-protocol";
import { FileName } from "../fileName/fileName";
import { SETTINGS } from "../settings/Settings";
import { ConstraintRegistry } from "../constraint/constraintRegistry";
import { LoadingIndicator } from "../loadingIndicator/loadingIndicator";
Expand All @@ -28,7 +27,6 @@ export class SaveDfdAndDdFileCommand extends SaveFileCommand {
@inject(ConstraintRegistry) constraintRegistry: ConstraintRegistry,
@inject(SETTINGS.Mode) editorModeController: EditorModeController,
@inject(DfdWebSocket) private readonly dfdWebSocket: DfdWebSocket,
@inject(FileName) private readonly fileName: FileName,
@inject(LoadingIndicator) loadingIndicator: LoadingIndicator,
) {
super(labelTypeRegistry, constraintRegistry, editorModeController, loadingIndicator);
Expand All @@ -38,19 +36,20 @@ export class SaveDfdAndDdFileCommand extends SaveFileCommand {
const savedDiagram = this.createSavedDiagram(context);

const response = await this.dfdWebSocket.sendMessage("Json2DFD:" + JSON.stringify(savedDiagram));
const nameEndIndex = response.indexOf(":");
const name = response.substring(0, nameEndIndex);
const endIndex =
response.indexOf(SaveDfdAndDdFileCommand.CLOSING_TAG) + SaveDfdAndDdFileCommand.CLOSING_TAG.length;
const dfdContent = response.substring(0, endIndex).trim();
const dfdContent = response.substring(nameEndIndex + 1, endIndex).trim();
const ddContent = response.substring(endIndex).trim();

const fileName = this.fileName.getName();
return Promise.resolve([
{
fileName: fileName + ".dataflowdiagram",
fileName: name + ".dataflowdiagram",
content: dfdContent,
},
{
fileName: fileName + ".datadictionary",
fileName: name + ".datadictionary",
content: ddContent,
},
]);
Expand Down