Skip to content

Various UI Bugfixes#1317

Merged
shangyian merged 10 commits intoDataJunction:mainfrom
shangyian:fix-columns-select
Feb 25, 2025
Merged

Various UI Bugfixes#1317
shangyian merged 10 commits intoDataJunction:mainfrom
shangyian:fix-columns-select

Conversation

@shangyian
Copy link
Copy Markdown
Collaborator

@shangyian shangyian commented Feb 21, 2025

Summary

The various UI bugfixes here include:

  • Make sure that we always display the Primary Key field when creating a transform or dimension node.
  • Fix the Add Node dropdown button to not wrap around in certain width scenarios
  • Enable the ability to configure the ordering of submit handler registration
  • Fix manifest error and a number of other warnings about form labels
  • Always check if linters failed for UI code

Test Plan

  • PR has an associated issue: #
  • make check passes
  • make test shows 100% unit test coverage

Deployment Plan

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 21, 2025

Deploy Preview for thriving-cassata-78ae72 canceled.

Name Link
🔨 Latest commit 1f10625
🔍 Latest deploy log https://app.netlify.com/sites/thriving-cassata-78ae72/deploys/67be02ad0d29910008a274b2

@shangyian shangyian changed the title Fix columns select Minor UI Fixes Feb 25, 2025
@shangyian shangyian changed the title Minor UI Fixes Various UI Bugfixes Feb 25, 2025
@shangyian shangyian added the bug Something isn't working label Feb 25, 2025
@shangyian shangyian marked this pull request as ready for review February 25, 2025 19:03
@shangyian shangyian merged commit ea6d490 into DataJunction:main Feb 25, 2025
16 checks passed
@shangyian shangyian deleted the fix-columns-select branch February 26, 2025 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant