Fix FK violation when hard-deleting namespaces with backfills#1924
Merged
shangyian merged 2 commits intoDataJunction:mainfrom Mar 25, 2026
Merged
Fix FK violation when hard-deleting namespaces with backfills#1924shangyian merged 2 commits intoDataJunction:mainfrom
shangyian merged 2 commits intoDataJunction:mainfrom
Conversation
…f the node has materializations and backfills
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DELETE /namespaces/{ns}/hard?cascade=trueraised aForeignKeyViolationwhen any node in the namespace had materialization backfill records. The bulk SQL delete cascaded through node to noderevision to materialization in the database, butbackfill.materialization_idlackedON DELETE CASCADE, so Postgres blocked the materialization delete.This PR adds cascade to that FK, along with a migration to apply it to the existing database.
Test Plan
Added a regression test that creates a node w/ materialization w/ backfill and verifies that the namespace hard-delete succeeds.
make checkpassesmake testshows 100% unit test coverageDeployment Plan