Skip to content

⚡️ Speed up method DbtAdapter.build_parent_map by 3,421% #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

⚡️ Speed up method DbtAdapter.build_parent_map by 3,421% #861

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
16f0638
⚡️ Speed up method `DbtAdapter.build_parent_map` by 3,421%
codeflash-ai[bot] Aug 15, 2025
766d272
Update recce/adapter/dbt_adapter/__init__.py
misrasaurabh1 Aug 15, 2025
e2bee4a
Apply suggestions from code review
misrasaurabh1 Aug 21, 2025
5de7e61
Merge branch 'main' into codeflash/optimize-DbtAdapter.build_parent_m…
misrasaurabh1 Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions recce/adapter/dbt_adapter/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,11 +621,15 @@ def execute(

def build_parent_map(self, nodes: Dict, base: Optional[bool] = False) -> Dict[str, List[str]]:
manifest = self.curr_manifest if base is False else self.base_manifest
manifest_dict = manifest.to_dict()

try:
parent_map_source = manifest.parent_map
except AttributeError:
parent_map_source = manifest.to_dict()["parent_map"]

node_ids = nodes.keys()
node_ids = set(nodes)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The keys view is set-like, so I think we don't need to change it to set to improve the lookup time.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair. making the edit

Copy link
Collaborator

@wcchang1115 wcchang1115 Aug 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I mean we can keep the original node_ids = nodes.keys()

parent_map = {}
for k, parents in manifest_dict["parent_map"].items():
for k, parents in parent_map_source.items():
if k not in node_ids:
continue
parent_map[k] = [parent for parent in parents if parent in node_ids]
Expand Down
Loading