Feature/refactor routing #975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jared Scott <[email protected]>
- Get links to Query, Checks, Check/?id=checkId, Lineage working correctly Signed-off-by: Jared Scott <[email protected]>
Signed-off-by: Jared Scott <[email protected]>
- Cleanup Providers.tsx Signed-off-by: Jared Scott <[email protected]>
…ments Signed-off-by: Jared Scott <[email protected]>
Signed-off-by: Jared Scott <[email protected]>
Member
|
When the RunResultPane is shown on the button, switching the tab between |
Member
The loading indicator when opening the `Linage` tab can use the `Linear Progress` instead of the circular progress.
|
Signed-off-by: Jared Scott <[email protected]>
Signed-off-by: Jared Scott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
What type of PR is this?
Refactor
What this PR does / why we need it:
Refactor Routing - Remove Wouter in place of using NextJS standard routing
Which issue(s) this PR fixes:
This removes hashbang
#!style routing in favor of standard url routing. This also allows users to refresh a pageSpecial notes for your reviewer:
#!is removed - if a hashbang is provided it will rewrite to the new styleDoes this PR introduce a user-facing change?:
URL's will now be
/lineageinstead of#!/lineage