Conversation
velo
force-pushed
the
publish
branch
4 times, most recently
from
3812f6b to
f75ebef
Compare
Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
velo
commented
Mar 26, 2025
| SQRL_VERSION: 'v0.5.6' | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 |
Collaborator
Author
There was a problem hiding this comment.
I couldn't get the original workflow building without this step, so I think it never worked before.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the build workflow to publish and test various SQRL examples, making them reusable by automating Docker image builds, tests, and pushes.
- Removed manual workflow_dispatch inputs in favor of triggering builds on push to main.
- Introduced a matrix strategy to parameterize tests and Dockerfile creation for different examples.
- Added steps for QEMU, Docker Buildx, and Docker Hub login to support multi-platform builds.
Comments suppressed due to low confidence (1)
.github/workflows/build-config.yml:87
- Consider adding 'set -e' at the start of this command block (or checking the exit status of each docker run call) so that any failure in a test command causes the workflow to fail instead of continuing the loop.
while IFS= read -r cmd; do
mbroecheler
approved these changes
Mar 26, 2025
Contributor
mbroecheler
left a comment
mbroecheler
left a comment
There was a problem hiding this comment.
That's really neat. Quite the github magic ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChatGPT did most of the heavy lifting for me
https://chatgpt.com/share/67e43f8d-b7f8-8003-8df2-ffb0d842f6af