Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces a new oil and gas example to the CI workflow. The changes include removing the branch filter for pull request triggers and adding a new job step for the oil-gas example with its own test commands.
Comments suppressed due to low confidence (2)
.github/workflows/build.yml:6
- The removal of the branch filter from the 'pull_request' trigger may unintentionally widen the scope of triggering events. Please confirm that this change is intentional.
- branches: [ "main" ]
.github/workflows/build.yml:59
- [nitpick] The test command 'run -c package-local.json' in the new oil-gas block appears inconsistent with the existing pattern. Please verify that this command is correct and fully implements the intended test behavior for this example.
run -c package-local.json
velo
commented
Apr 1, 2025
.github/workflows/build.yml
Outdated
| - example: oil-gas | ||
| path: oil-gas | ||
| test_commands: | | ||
| run -c package-local.json |
Collaborator
Author
There was a problem hiding this comment.
@mbroecheler no test for this one yet, right?
Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.