Merged
Conversation
velo
approved these changes
Aug 19, 2025
Collaborator
velo
left a comment
velo
left a comment
There was a problem hiding this comment.
All good, but I think we should also lock the version here:
https://github.com/DataSQRL/datasqrl-examples/blob/main/.github/workflows/build.yml#L106
|
|
||
| ```bash | ||
| docker run -it --rm -p 8888:8888 -p 9092:9092 -v $PWD:/build datasqrl/cmd:0.7.1 run -c package.json | ||
| docker run -it --rm -p 8888:8888 -p 9092:9092 -v $PWD:/build datasqrl/cmd:latest run -c package.json |
Collaborator
There was a problem hiding this comment.
I would say to lock the version, that way we know it needs to be bumped and to run CI to validate the change
ferenc-csaky
force-pushed
the
0.7.2-updates
branch
from
8bb3fcb to
b35a97b
Compare
ferenc-csaky
force-pushed
the
0.7.2-updates
branch
from
b35a97b to
e414490
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.