Merged
Conversation
dopenguin
added
enhancement
Member
|
@dopenguin Did you notice the E2E tests breaking? |
Member
Author
This is remarked in the internal ticket for you to look at |
Member
We mixed this up with #192 and it's back to you again. |
warm-coolguy
reviewed
Jan 6, 2025
Member
Author
Tests are fixed 🏓 @warm-coolguy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setFeatureInformationto be able to set feature information to the store and trigger all relevant functionalityrenderFeaturesandfilterFeaturesto be a reusable utility functionFeaturesByLayerIdto the central types file for reusabilitysetup-actions to a separate file to stay in line with the max line linting ruleInstructions for local reproduction and review
npm run snowbox; I've added a button that adds some features for the compensation area layer