feat(filter): migrate plugin #436

oeninghe-dataport · 2026-01-02T12:20:20Z

Summary

The filter plugin is migrated to POLAR@3.

Instructions for local reproduction and review

Open snowbox.
Enable the layer "Anliegen (MML)" and move the map to Hamburg, Germany.
Use the filters and test them.

Additional hints

Layout flaws

The layout of the filter dialog is somehow broken.
It is larger than the map's height (in the snowbox).
You may scroll it, but you cannot see the bottom of the scrollbar, as it overflows.

This, however, is, as far as I can tell, not a filter-specific problem but located probably in iconMenu.
Therefore, it is not considered here.

Styling

The general styling for this component is inspired by some (deprecated) UI/UX drafts.

Date range picker

The date range picker consists of two browser-native date pickers.
This control is supported by all major browsers (https://caniuse.com/input-datetime).

This improvised date range picker already supports limiting the dates (up to or starting with today's date).
An advanced implementation (as before with Vuetify) is left open to another PR.

Relevant tickets, issues, et cetera

Closes #370

Bumps [@commitlint/cli](https://github.com/conventional-changelog/commitlint/tree/HEAD/@commitlint/cli) from 20.2.0 to 20.3.0. - [Release notes](https://github.com/conventional-changelog/commitlint/releases) - [Changelog](https://github.com/conventional-changelog/commitlint/blob/master/@commitlint/cli/CHANGELOG.md) - [Commits](https://github.com/conventional-changelog/commitlint/commits/v20.3.0/@commitlint/cli) --- updated-dependencies: - dependency-name: "@commitlint/cli" dependency-version: 20.3.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

oeninghe-dataport · 2026-01-12T09:21:20Z

src/plugins/filter/store.ts

+		/** @internal */
+		configuration,
+
+		/** @internal */
+		state,


This two fields shouldn't be internal. They should be marked as @alpha (or stable API).

state seems reasonable, configuration is redundant.

# Conflicts: # package-lock.json # src/core/types/plugin.ts

github-actions · 2026-01-19T15:47:26Z

PR Preview Action v1.8.0
🚀 View preview at https://Dataport.github.io/polar/pr-preview/pr-436/
Built to branch `gh-pages` at 2026-01-23 12:52 UTC. Preview will be ready when the GitHub Pages deployment is complete.

dopenguin

I can't seem to be able to tab through the selection of the buttons. Please take a look at this. This probably results from the <input>s being hidden and only the labels being displayed. Not sure how a ScreenReader would interpret them as well. Maybe using an actual button here seems reasonable?
Selecting a BlockButton makes it jiggle a bit, which is annoying. This should be fixable by reserving some space for the border.
Implement the old UI for layout: 'nineRegions'. As we didn't have a final draft yet, the previous layout should be available.

I've also attached a patch which adds the pointer-events to the correct elements.

🏓 @oeninghe-dataport

dopenguin · 2026-01-20T10:29:08Z

examples/iceberg/tsconfig.json

 		"types": [
 			"vitest/importMeta",
 			"vitest/jsdom",
+			"node",


Why is this added here? IIRC it was added on another PR as well.

dopenguin · 2026-01-20T18:08:11Z

src/plugins/filter/types.ts

+	 * If using `string` instead of `CategoryValue`, the string is interpreted as the `value` key.
+	 *
+	 * @remarks
+	 * The values listed here can be localized:


Suggested change

* The values listed here can be localized:

* The values listed here should be localized:

If this is not done, one would see e.g. layer.haus.category.houseType.knownValue.shed in the UI.
It also does not seem to be intended, that this is the default value. I suggest falling back to the knownValue for the category if no locale is available.

The same goes for targetProperty.

`

dopenguin · 2026-01-20T18:10:16Z

src/plugins/filter/types.ts

+	/**
+	 * Technical value of a feature property.
+	 */
+	value: string


It seems fitting to also allow multiple values here.

dopenguin · 2026-01-20T18:26:41Z

src/plugins/filter/components/FilterUI.ce.vue

@@ -0,0 +1,55 @@
+<template>
+	<PolarCard class="polar-filter-card">
+		<FilterLayerChooser


If this is not shown (only one layer configured), I'd still expect an information for which layer I am filtering.

dopenguin · 2026-01-22T18:52:12Z

src/plugins/filter/components/FilterLayerChooser.ce.vue

+		<label class="kern-label" for="select">Fachdatensatz auswählen</label>
+		<div class="kern-form-input__select-wrapper">
+			<select v-model="model" class="kern-form-input__select">
+				<option v-for="layer of layers" :key="layer">{{ layer }}</option>


I'd rather like to see the name that is defined for the layer in configuration.layers like it is done in layerChooser. I doubt someone using POLAR would understand that the layer with the id '6059' is meant to show the reports in HH.

dopenguin · 2026-01-22T19:05:53Z

src/plugins/filter/components/FilterTime.ce.vue

+const layerConfiguration = computed(
+	() => filterStore.configuration.layers[props.layer] as FilterConfiguration
+)


This variable is locally created twice. Would it be intereting to move selectedLayer from FilterUI to the store and then have a getter for layerConfiguration that can be ued in FilterCategory and FilterTime?

dopenguin · 2026-01-23T11:24:38Z

src/plugins/filter/components/FilterUI.spec.ts

+})
+/* eslint-enable no-empty-pattern */
+
+test('Component works as expected', async ({ wrapper, coreStore, store }) => {


What is "expected"?

dopenguin · 2026-01-23T11:25:31Z

src/plugins/filter/components/FilterTime.ce.vue

+	</section>
+</template>
+
+<script setup lang="ts">


A lot of this functionality seems overly complex compared to the previous implementation. Can you shed some light onto your thoughtprocess and why you deem this necessary?

dopenguin · 2026-01-23T12:36:52Z

src/plugins/filter/utils/getVectorSource.ts

This looks like a function that may of use in other plugins as well.

dopenguin · 2026-01-23T12:40:04Z

src/plugins/filter/store.ts

+		/** @internal */
+		configuration,
+
+		/** @internal */
+		state,


state seems reasonable, configuration is redundant.

oeninghe-dataport added this to the POLAR@3 milestone Jan 2, 2026

oeninghe-dataport self-assigned this Jan 2, 2026

oeninghe-dataport added the refactor Refactoring of previous code label Jan 2, 2026

oeninghe-dataport linked an issue Jan 2, 2026 that may be closed by this pull request

Migration of Filter plugin to POLAR@3 #370

Open

oeninghe-dataport force-pushed the vue3/migrate-plugin-filter branch from bd44e84 to 4640a4e Compare January 2, 2026 13:02

dependabot bot and others added 2 commits January 5, 2026 17:07

ci(iceberg): make tsc acknowledge vitest-caused node types

0328f14

oeninghe-dataport force-pushed the vue3/migrate-plugin-filter branch from 4640a4e to 22cd58a Compare January 5, 2026 16:09

fix(core): enforce usage of Icon type

07048a5

oeninghe-dataport force-pushed the vue3/migrate-plugin-filter branch 2 times, most recently from a9658ca to 9a5d3cf Compare January 7, 2026 15:33

feat(filter): migrate plugin

2fa72f1

oeninghe-dataport force-pushed the vue3/migrate-plugin-filter branch from 9a5d3cf to 2fa72f1 Compare January 7, 2026 15:38

oeninghe-dataport marked this pull request as ready for review January 7, 2026 15:45

oeninghe-dataport requested review from dopenguin and warm-coolguy as code owners January 7, 2026 15:45

oeninghe-dataport commented Jan 12, 2026

View reviewed changes

dopenguin added 2 commits January 16, 2026 16:46

Merge branch 'next' into vue3/migrate-plugin-filter

6aabb56

# Conflicts: # package-lock.json # src/core/types/plugin.ts

fix(filter): use correct import for export store

cd23d05

dopenguin removed the request for review from warm-coolguy January 19, 2026 10:33

Merge branch 'next' into vue3/migrate-plugin-filter

56ea116

dopenguin added 2 commits January 20, 2026 11:27

Merge branch 'next' into vue3/migrate-plugin-filter

9c92633

Merge branch 'next' into vue3/migrate-plugin-filter

e6916db

dopenguin mentioned this pull request Jan 22, 2026

fix(iconMenu): adjust size of the StandardMenuList #493

Merged

oeninghe-dataport and others added 2 commits January 23, 2026 10:42

style: apply new linting rule for self-closing

25d11ec

Merge branch 'next' into vue3/migrate-plugin-filter

b7b6c3b

dopenguin requested changes Jan 23, 2026

View reviewed changes

Merge branch 'next' into vue3/migrate-plugin-filter

0d1200c

	* The values listed here can be localized:
	* The values listed here should be localized:

feat(filter): migrate plugin #436

Are you sure you want to change the base?

feat(filter): migrate plugin #436

Uh oh!

Conversation

oeninghe-dataport commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Instructions for local reproduction and review

Additional hints

Layout flaws

Styling

Date range picker

Relevant tickets, issues, et cetera

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Built to branch gh-pages at 2026-01-23 12:52 UTC. Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

dopenguin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

oeninghe-dataport commented Jan 2, 2026 •

edited

Loading

github-actions bot commented Jan 19, 2026 •

edited

Loading

Built to branch `gh-pages` at 2026-01-23 12:52 UTC.
Preview will be ready when the GitHub Pages deployment is complete.