Skip to content

Dish internal terms of use#455

Merged
jedi-of-the-sea merged 7 commits intomainfrom
dish_internal_terms_of_use
Jan 14, 2026
Merged

Dish internal terms of use#455
jedi-of-the-sea merged 7 commits intomainfrom
dish_internal_terms_of_use

Conversation

@jedi-of-the-sea
Copy link
Contributor

@jedi-of-the-sea jedi-of-the-sea commented Jan 12, 2026 •
edited
Loading

Summary

  • Terms of use for user added
  • links for BKG and BKG Terms of use open in new tab

Instructions for local reproduction and review

  • start client in mode INTERN
  • open Attributions
  • check links "BKG" and "Nutzungsbedingungen" - they should open in new tab
  • check link "Benutzungshinweise" - it should open a window in the client with information how to use the client

Pull Request Checklist (for Assignee)

  • Changelogs are maintained
  • Functionality has been tested in Firefox, Chrome, Safari
  • Functionality has been tested on a smartphone
  • Functionality has been tested with 200% screen zoom
  • Screenreader functionality has been manually tested with NVDA

UI has been tested in the following tools regarding accessibility (only regarding functionality affected in this PR)

  • Chrome Lighthouse
  • Firefox Accessibility

Relevant tickets, issues, et cetera

@jedi-of-the-sea jedi-of-the-sea self-assigned this Jan 12, 2026
@jedi-of-the-sea jedi-of-the-sea added the enhancement New feature or request label Jan 12, 2026
@jedi-of-the-sea jedi-of-the-sea marked this pull request as ready for review January 13, 2026 07:41
warm-coolguy
warm-coolguy approved these changes Jan 13, 2026
View reviewed changes
Copy link
Member

@warm-coolguy warm-coolguy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 @jedi-of-the-sea

warm-coolguy
warm-coolguy requested changes Jan 13, 2026
View reviewed changes
Copy link
Member

@warm-coolguy warm-coolguy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏓 @jedi-of-the-sea

Oh wait, I just found two little cosmetic issues.

The close button is a little jumpy:
oopsie_question_mark

And the link contains a whitespace so that the outline is above the following text:
Screenshot 2026-01-13 095009

@jedi-of-the-sea
Copy link
Contributor Author

jedi-of-the-sea commented Jan 13, 2026

I fixed the mentioned issues:
jumpy button: 32fdf1f
whitespace in link: c11f862

🏓 @warm-coolguy

warm-coolguy
warm-coolguy approved these changes Jan 14, 2026
View reviewed changes
Copy link
Member

@warm-coolguy warm-coolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 @jedi-of-the-sea

@jedi-of-the-sea jedi-of-the-sea merged commit 434ce0c into main Jan 14, 2026
7 of 8 checks passed
@jedi-of-the-sea jedi-of-the-sea deleted the dish_internal_terms_of_use branch January 14, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@warm-coolguy warm-coolguy warm-coolguy approved these changes

@dopenguin dopenguin Awaiting requested review from dopenguin dopenguin is a code owner

@oeninghe-dataport oeninghe-dataport Awaiting requested review from oeninghe-dataport oeninghe-dataport is a code owner

@czirkelbach czirkelbach Awaiting requested review from czirkelbach czirkelbach is a code owner

@raschju raschju Awaiting requested review from raschju raschju is a code owner

Assignees

@jedi-of-the-sea jedi-of-the-sea

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jedi-of-the-sea @warm-coolguy @FinnDarge