feat: make font family selectable #483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warm-coolguy
requested review from
dopenguin and
oeninghe-dataport
as code owners
|
oeninghe-dataport
requested changes
Jan 20, 2026
src/core/utils/export/createMap.ts
Outdated
Comment on lines
51
to
53
| if (typeof mapConfiguration.fontFamily !== 'undefined') { | ||
| void import('@kern-ux/native/dist/fonts/fira-sans.css') | ||
| } |
Collaborator
There was a problem hiding this comment.
If we move the import here, we require the usage of this function (which is not used in iceberg, for example).
Collaborator
There was a problem hiding this comment.
Maybe, a suitable option would be loading the font in loadKern using document.adoptedStyleSheets?
Member
Author
There was a problem hiding this comment.
I've got to move it, move it.
src/core/utils/loadKern.ts
Outdated
| kernSheet.replaceSync(` | ||
| @layer kern-ux { | ||
| ${kernCss.replaceAll(':root', ':host')} | ||
| ${typeof fontFamily !== 'undefined' ? `:host { --kern-typography-font-family-default: ${fontFamily}; }` : ''} |
Collaborator
There was a problem hiding this comment.
Why is this a separate parameter? Couldn't this be done using theme? (theme allows overriding arbitrary KERN variables, although the type probably needs to be adjusted.)
Member
Author
There was a problem hiding this comment.
I've got to move it, move it.
warm-coolguy
force-pushed
the
feature/make-font-family-selectable
branch
3 times, most recently
from
fa02f29 to
1484d11
Compare
warm-coolguy
force-pushed
the
feature/make-font-family-selectable
branch
from
1484d11 to
d7a5170
Compare
Member
Author
|
🏓 @oeninghe-dataport I have ... MOVED IT. |
oeninghe-dataport
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow
fontFamilyconfiguration for map client.Instructions for local reproduction and review
I've
addedmodifieda snippetthe dataportTheme in the snowbox that can be uncommented to check the results in it. I suggest trying'Consolas', since it's easily distinguishable, and'', since it has a special meaning. When using'', set e.g.font-family: Book Antiqua;on the POLAR host node in the DOM manipulator to check whether it works as expected.I'm currently having an issue with vite and couldn't check the build. Please verify that the fonts are bundled separately to the other .css files so that they can only optionally be imported during run-time.
Pull Request Checklist (for Assignee)
Safari(Please verify in Safari!)UI has been tested in the following tools regarding accessibility (only regarding functionality affected in this PR)
Relevant tickets, issues, et cetera