refactor(geoLocation): update centering behaviour#566
Merged
jedi-of-the-sea merged 18 commits intonextfrom Mar 6, 2026
Merged
Conversation
|
dopenguin
changed the title
jedi-of-the-sea
force-pushed
the
vue3/update-behaviour-of-GeoLocation
branch
from
5f58347 to
4983c03
Compare
jedi-of-the-sea
force-pushed
the
vue3/update-behaviour-of-GeoLocation
branch
from
939bdd9 to
161ae1d
Compare
jedi-of-the-sea
requested review from
dopenguin,
oeninghe-dataport and
warm-coolguy
as code owners
dopenguin
requested changes
Mar 3, 2026
Member
dopenguin
left a comment
dopenguin
left a comment
There was a problem hiding this comment.
Will test outdoors after the changes mentioned in src/plugins/geoLocation/components/GeoLocation.ce.vue.
Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
jedi-of-the-sea
force-pushed
the
vue3/update-behaviour-of-GeoLocation
branch
from
b5dace6 to
8c9e656
Compare
Contributor
Author
|
🏓 @dopenguin I'm done |
Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The map stops centering if a user pans the map during locating, but not if they zoom.
Instructions for local reproduction and review
Please Note: the configuration for snowbox client has been altered to
keepCentered: truein this PR to enable the testing on mobile devicesPull Request Checklist (for Assignee)
UI has been tested in the following tools regarding accessibility (only regarding functionality affected in this PR)
Relevant tickets, issues, et cetera
closes #395