Merged
Conversation
…ve duplicate implementation from StripedDrawingTriangle.cs
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds methods to generate striped segment patterns for various geometric shapes, complementing the existing drawing methods. The changes introduce a data generation layer that returns Segments collections, which can then be drawn or further manipulated.
- Adds
GenerateStripedSegmentsmethods for Circle, Triangle, Rectangle, Quad, Polygon, and Ring shapes - Introduces helper methods to draw generated segments with alternating styles
- Refactors a boolean check for consistency
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| StripedDrawing.cs | Adds core helper methods for drawing generated segments and a generic dispatcher method for segment generation |
| StripedDrawingCircle.cs | Implements striped segment generation for circles with constant and curve-based spacing |
| StripedDrawingTriangle.cs | Implements striped segment generation for triangles, including boolean style refactor |
| StripedDrawingRect.cs | Implements striped segment generation for rectangles with commented code cleanup |
| StripedDrawingQuad.cs | Implements striped segment generation for quads |
| StripedDrawingPolygon.cs | Implements striped segment generation for polygons |
| StripedDrawingRing.cs | Implements radial striped segment generation for rings and ring sectors |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ShapeEngine/Geometry/StripedDrawingDef/StripedDrawingPolygon.cs
Outdated
Show resolved
Hide resolved
ShapeEngine/Geometry/StripedDrawingDef/StripedDrawingPolygon.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Refactor: StripedDrawing GenerateStripedSegments generic version now correctly uses Rect instead of Rectangle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added functions to generate striped Segments for Circle, Triangle, Rect, Quad, and Polygon. Additionally, I have added functions to generate striped Segments for inside and outside shapes.